From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A97183A9D8B for ; Fri, 6 Mar 2026 14:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772809067; cv=none; b=Lp2iY2KJFwgelUaPBUkyZJVLeNN2xXjAF/aHDcXe3MxS6o7xWgnyuRRO/9PHEA5BEZd3JiaEdGUUkV6NcudidiDfGdQB/fLqSoY0PHDDMSujHCbxdao4k3yoR7dB7VXciUNFKeFj45kEQlS7vR6d8n4K1xa0/kiz0U+OmzeM/bY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772809067; c=relaxed/simple; bh=xBZTJgf06uCCuEEDLG6TKhtW/SbYasQgQdMoCjV2exw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TloZKj6DhJjJRobkBMeeBy4rm2+93GyhpFLQYZ8I6T5XZLCqbCrzkJM3MnFMB7Txx5Yncj9N108T/j5/S91Dgsb6YM6ARtzXIYAv92wm/NanbbIFBZg0Qv4e6zMNGhF7mYdGoWWFSu2uv1H+a6RWuVuFH4FbMfyb+DV5qlEQlnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hrc4pvpD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W3yK5Vzm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hrc4pvpD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W3yK5Vzm" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Bb2Pe628982 for ; Fri, 6 Mar 2026 14:57:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Cz3OwQgqvLLNFn7ypyj4owNUYfZ/fsaAqU2Y2vb8Dlw=; b=hrc4pvpDOI7IjsgI nzvwRKIkkC/svedMYWD3Y1/AH6xJzKNOupEi9Rg3a6gycaKUsrnQ9wr1jXaTHUOO K8u5sToHH2ce+12t92X2IAdwaHpJUzKh8zzOb2LgtusZaWNmcbpTNR0FBYR7mEJu aarg5Jeut9twxCJ8iVZ87x5UqvaXIGkU8OFuRsFRQ0ngGlaTkW/rF9nCNeB0K1wS 6thTeoFmWyA7QsuR1lg95xzIyaEeWQuzNQYtC+8W2tNDwgn/kdNtItpjP9VeJFX0 56s6u5CFFB1xI+i6Ipx9IM0Mn5n2GZougyjMcbX1cJ25WmttM6Qz4OL+F/jYwr49 XAeEEw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqj4sb2fe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 14:57:45 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae50463c39so57293685ad.1 for ; Fri, 06 Mar 2026 06:57:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772809065; x=1773413865; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Cz3OwQgqvLLNFn7ypyj4owNUYfZ/fsaAqU2Y2vb8Dlw=; b=W3yK5VzmCjTBtnCTJsU809Li7xUEEQI/VfE1dfT9HIqXmo+78tM47jeSs5J5mMx0YI nqpCplbTBKuUd7tYzOrxmJEUMhvZ4eG8VpP2CSxn4IXtvu2OGbzhdE0bGQ4d9R61IVLT GZBGjbT3uMBjdriG4ISVXM3kmYE0hiuiz4VeglgrFua2J0keiAArHHosOrVSHv69sio5 e1EkN5m4m7vhyfQ5O3TJiE4T+YWi3VcGtvqW8Pxgmfd/1J2ufzLm7OSSjIBW9EF+2zXI Mxhz+CCSSL3Vi3FdY2jIzsBJy0/a8GI4GB2eOJW1NDhDe++17PlyxnmAYof+N5Ciq74S wldA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772809065; x=1773413865; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cz3OwQgqvLLNFn7ypyj4owNUYfZ/fsaAqU2Y2vb8Dlw=; b=BrX0hb6mibtu0yjxNIBrC9e8Uyqjp5oIZ2C32WAuOPRcxYlQBdme3sUHKbi3/UWfBK N+A6Mwd3dmEa9yNhgO4JiYCWnp16xZ2IXp6FLWgYeHEjDVziPtBsaCUxg+wNxx4uNSXp xLsWIDteJRct3h4N7+7viNlgPKII+OYs8ZiNyyB75t8EIfmx00wRjf2v1WYB20O9lya4 INcziKQcgnmwOnipyHCjxk+kUovPMG4nHw9tch6ulPf6E0GX1OiQ4kBC5Yr+NhVg1rlQ XosgjAbMqpA6ijRRqTv5jgDHVs+w26m7nkGhtnf52eOKfOgp8t7BQShi6x59wX5phAWw BSdQ== X-Forwarded-Encrypted: i=1; AJvYcCVWDoaY9+5fBz8nQSVrMjnA2tYG6DbF8fV16ab1KP29mxzHP/dPkvrHk28LxEF76EzK6DPklGIrGOrVUfE=@vger.kernel.org X-Gm-Message-State: AOJu0YwNUZK21vuoylQ7If7UK+zrbNjbhGxn4SFtPaErZgQqQshe1W0D oYBKwN5DafdaNHYem031AdVbjNLd/2n6KmwIwno+DSjiwvN7PXKuLOv7Fsk0kgvvD4hWjwmrOZi DHzWbNLUJKxg4vTpSWhhJJMGFXdacWvtEHmNFDf+uPGs6soHuZwCkBbJqwTk+sw+yLcM= X-Gm-Gg: ATEYQzxb0r7Op/nbAsypLxBTOQH3HxvwhzD/NvzjPpxYcCkKEsYL/ckUOO8sj60mQqJ ttqUGHLxa7Tc0hSS7Q+QRZ8bQ0jzsSi/hHJBTGOO5u8s1VSDkWsLutTb98Hd9wT7kdentbgE40X 7LVwCPqurvgoHTX2bIJsUQQDlLJJtzKRntwJQXjL58g5P6B7+AvKDoz7DtpdoePBktZTb7xgUx0 xLKLDwdLyw2+SydOk+UxVjymkfd7dIUxGdOK8gDyhH/J1dF4ZV77GHFNfVs5PyApLNLgKBXttGj 5dsH7Cf7r9ydYMyUj15rU67SeJYh6K//+4++pVwl5hooOh/GjtpHpUVzPbaJAlq1Xz/bxV1aFLo gLlxINtEL4tulIGkebcaAPhPCkKnurqLzPPZq6Dxy2tSBvnDzdPJKoTi+BhVf0GdesUfSjXk3O7 7ImP2Tmh2bCaA= X-Received: by 2002:a17:90b:4c09:b0:359:dd9:3de5 with SMTP id 98e67ed59e1d1-359be238c5dmr2079127a91.4.1772809065174; Fri, 06 Mar 2026 06:57:45 -0800 (PST) X-Received: by 2002:a17:90b:4c09:b0:359:dd9:3de5 with SMTP id 98e67ed59e1d1-359be238c5dmr2079088a91.4.1772809064580; Fri, 06 Mar 2026 06:57:44 -0800 (PST) Received: from ?IPV6:2401:4900:88f5:81:e13b:ce78:7823:d9c3? ([2401:4900:88f5:81:e13b:ce78:7823:d9c3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359bbc060d7sm1328627a91.2.2026.03.06.06.57.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 06:57:44 -0800 (PST) Message-ID: <6bcf3d43-030b-4607-9cc7-d347348aaffc@oss.qualcomm.com> Date: Fri, 6 Mar 2026 20:27:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] clk: qcom: camcc-x1p42100: Add support for camera clock controller To: Konrad Dybcio , Bryan O'Donoghue , Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jagadeesh Kona , Konrad Dybcio , Abel Vesa , Rajendra Nayak , Stephan Gerhold , Ajit Pandey , Imran Shaik , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260304-purwa-videocc-camcc-v2-0-dbbd2d258bd6@oss.qualcomm.com> <20260304-purwa-videocc-camcc-v2-5-dbbd2d258bd6@oss.qualcomm.com> <2byedzh5w6ymnoebve74a2a7oezgich25wdh4pdsqmvv3jvpkf@kyk2gz5khibe> <2f1bdd7a-04a0-49a7-b275-4332f2979378@linaro.org> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE0MyBTYWx0ZWRfX/Jv7O6w2utoN r089kN5Dgh6HPKURJS8MtHkOywmJmO4FSghkEAfrq4hcr/e7kwUZNHlsXEEvYKk3k8YlWWtk/19 QHhIPly2hMG0b0u+hw7TXuCcnJwtx3N05RLR4lMq06YTUAgTlPApS6rj9fSqW+uSdHmR/+hAu86 qHPpxp6+aYbp0rk71XVA9GPsMGuAjJAYy9mK5/d9lDpBclXtI2Fv169SIjrFu5Qq4Uiqy3cOY31 7XAKSKQ9htNSBCyOW3Wz2oKQ5lspmVqoslt95mAmuxYV1YwsfbUyIVH423EQjAOdi5D1LPpclcZ 6UF/qKX4AGCWezkrBvgEWoMKhhUJL2zmTnPAS1ySKt8NSDos1ws/Ed+mi29QuXtsaigQ+AcfOm5 py/gK1RlooDnN6QjJpwRwDsToPHeoTjvY71Crp/xFsvnfjl55uyJRf0zoH00zdWvUgXtoq9GfSd OBZsvwO7QAPM4jojHKA== X-Proofpoint-ORIG-GUID: B9CgQON1VOcpf8uEZmYbVljwMjvWd-7U X-Proofpoint-GUID: B9CgQON1VOcpf8uEZmYbVljwMjvWd-7U X-Authority-Analysis: v=2.4 cv=T8uBjvKQ c=1 sm=1 tr=0 ts=69aaeb69 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=C-5xYsbyb9TDfLoqzDsA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060143 On 3/5/2026 2:35 PM, Konrad Dybcio wrote: > On 3/5/26 3:18 AM, Bryan O'Donoghue wrote: >> On 05/03/2026 00:33, Dmitry Baryshkov wrote: >>> I've cross-checked this against X1E80100 driver. The main changes are a >>> drop of IFE_1, SPE_0, and two PLLs. However it also: >>> - uses hw_clk_ctrl for several clocks >>> - uses rcg2_shared_ops instead of rcg2_ops for several clocks Above 2 are safe to have recommendations from HW. >>> - uses hwcg_reg and BRANCH_HALT_VOTED for cam_cc_camnoc_axi_nrt_clk >>> - uses HW_CTRL_TRIGGER for cam_cc_bps_gdsc and cam_cc_ipe_0_gdsc These 2 GDSC's have support for HW control mode, so added this flag and consumer drivers can switch to HW control mode based on their requirement. >>> - uses non-AO clock for cam_cc_xo_clk_src >>> Both XO or non-AO should be fine here. Ideally if CC has any clocks with CLK_IS_CRITICAL flag, then AO parenting is required to allow XO low power modes. >>> Are all these changes expected? Are any of them also applicable to X1E? >>> >>> At this point, I'm torn between suggesting the merge of this driver into >>> X1E driver and ack'ing the current form. >> >> We can test the diff but, I'm not sure that will really answer the question if it is the right-thing-to-do. >> >> OTOH if it ain't broke, don't fix it. >> >> Reverse the question - is there any reason to have this driver at all ? Can the x1e CAMCC be used as-is ? >> >> If not, then we can accept this patch and potentially look at merging the two drivers later on. >> >> I assume the code submitted has a purpose though i.e. its not possible to just use Hamoa and Purwa interchangably. >> >> A few community members showed me CAMSS working on Purwa last year in Amsterdam with the x1e code - one error if I recall was a clock splat. >> >> So superficially it adds up to me that its not a 1:1 thing with these two parts. > > The difference between 'can/does it work in some simple use case' vs 'is it > correct' is that the exact match for clock configurations between H and P > is (according to the computer) 4 clocks (out of 200+ in the camcc topology). > > Most of the changes are small differences in frequency steps or which PLL > is used for a given OPP etc, which ends up being small in the Linux > representation of that data since many of the freq tables are reused 3, 4, > 5 times and many clocks (branches) don't even feature one. > > I would imagine almost all of the points raised by Dmitry probably apply > (but I'll let the people in the know comment on that), which would greatly > reduce the effective diff. If they do, the drivers could indeed be merged > since the delta would be just those couple freq tables and NULLifying 13 > clocks on Purwa > There is frequency table delta for most RCG's since Hamoa has an extra LowSVS_D1 corner, but along with that, few frequencies like 480MHz for cam_cc_icp_clk_src...etc is derived from PLL8 on Hamoa, but the same is derived from PLL6 on Purwa. To handle above, change is required in cam_cc_parent_map_0, cam_cc_parent_data_0 structures from X1E and these structures are used by many RCG's and all those RCG's also needs to be updated, so overall it is significant delta and hence it is good to have this separate driver. Thanks, Jagadeesh