From: Paulo Alcantara <pc@manguebit.com>
To: Ekaterina Esina <eesina@astralinux.ru>, Steve French <sfrench@samba.org>
Cc: Ekaterina Esina <eesina@astralinux.ru>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Aurelien Aptel <aaptel@suse.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org,
Anastasia Belova <abelova@astralinux.ru>
Subject: Re: [PATCH] cifs: fix check of rc in function generate_smb3signingkey
Date: Mon, 13 Nov 2023 15:49:41 -0300 [thread overview]
Message-ID: <6bcf9eb2d4ca5faa17e8e0842c4d69fd.pc@manguebit.com> (raw)
In-Reply-To: <20231113164241.32310-1-eesina@astralinux.ru>
Ekaterina Esina <eesina@astralinux.ru> writes:
> Remove extra check after condition, add check after generating key
> for encryption. The check is needed to return non zero rc before
> rewriting it with generating key for decryption.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: d70e9fa55884 ("cifs: try opening channels after mounting")
> Signed-off-by: Ekaterina Esina <eesina@astralinux.ru>
> Co-developed-by: Anastasia Belova <abelova@astralinux.ru>
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> ---
> fs/smb/client/smb2transport.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
next prev parent reply other threads:[~2023-11-13 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 16:42 Ekaterina Esina
2023-11-13 18:49 ` Paulo Alcantara [this message]
2023-11-13 22:23 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bcf9eb2d4ca5faa17e8e0842c4d69fd.pc@manguebit.com \
--to=pc@manguebit.com \
--cc=aaptel@suse.com \
--cc=abelova@astralinux.ru \
--cc=eesina@astralinux.ru \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=lvc-project@linuxtesting.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®