From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE433ACEF7 for ; Wed, 4 Feb 2026 09:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770198472; cv=none; b=DvkykqAv2TelyeTuhP9DkSG5mPi8s0nfjTrexO9hRHC56ig7uCIRkhylsD5KMwh2JANNABVtdIQK8K3WbPlzeu0PzeVlcrWaq9DoaN/lRgO+0lYxcFM/2FtabQAb+tEFBXh00zzFmiHV/4m0PLUG7P2h6ZPZn9PRU3YWL6xg3lY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770198472; c=relaxed/simple; bh=Rh+sVfi0SBsnLMs0/+qmJF+XZ0XPUgeYV8stmxMeZy8=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=YTQiUhFv6vyMp6gc4d1mteoQm2nJg3s0Q9qdSe9a7TC6AgkM4Yjtl/zccFZZzjav1KXoY/OP+OWwb4h+eaCJ6KSDEidSENvOj7I1feDxLystz0uzox/uSLhtLENJoJZ+HcrRjn0sRLu7F7LiFK6mBgWDqx4Is+wFh8srmk/8b5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SFj/t4gu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SFj/t4gu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC036C4AF09; Wed, 4 Feb 2026 09:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770198472; bh=Rh+sVfi0SBsnLMs0/+qmJF+XZ0XPUgeYV8stmxMeZy8=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=SFj/t4guVzu0ax2pXy7xveqqU026e25r7/XEXqcVog4g+DJfwrRKFsI1PuEaTZUV1 Goc4Uns1OEnR9wZ0XRuB9evV5giUok3sSmqgDsSvRmh3rqxo4rUJBqteUBuTw5c7L4 4OXIvlUN2gl9Q32+NoTx/fAbapsZhM3t1GLWuRZs8rPxO0wP+hSLvml3hvPk/g3pqu Ik0N+ft6QQAvTj6QXkTwW3ROYKT70w1Wd8LCCjNnvd6287Fri0WfRR3pIIwHwdEAHS 8s8L7ohlvCHm6QQVgBlTtVa9hqaHOzYCsO69E+a308jL1YCT52yjChbKUsdmm8Bybb OZENHxDG9t3EQ== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 9A0ADF40068; Wed, 4 Feb 2026 04:47:50 -0500 (EST) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-01.internal (MEProxy); Wed, 04 Feb 2026 04:47:50 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddukedvudegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrugcu uehivghshhgvuhhvvghlfdcuoegrrhgusgeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpedvueehiedtvedtleekuddutefgffdtleetfeetveejveejieehfefhjeei jeefudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhguodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieejtdehtddtjeel qdeffedvudeigeduhedqrghruggspeepkhgvrhhnvghlrdhorhhgseifohhrkhhofhgrrh gurdgtohhmpdhnsggprhgtphhtthhopedutddpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtohepsghpsegrlhhivghnkedruggvpdhrtghpthhtohepsghrghgvrhhsthesghhmrg hilhdrtghomhdprhgtphhtthhopehlvghnsgeskhgvrhhnvghlrdhorhhgpdhrtghpthht ohepmhhinhhgoheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepphgrvhgvlheskhgvrh hnvghlrdhorhhgpdhrtghpthhtoheprhgrfhgrvghlsehkvghrnhgvlhdrohhrghdprhgt phhtthhopeigkeeisehkvghrnhgvlhdrohhrghdprhgtphhtthhopehtghhlgieslhhinh huthhrohhnihigrdguvgdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghr rdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 6E3BE700065; Wed, 4 Feb 2026 04:47:50 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: A7_Pc3rsWUkJ Date: Wed, 04 Feb 2026 10:47:30 +0100 From: "Ard Biesheuvel" To: "Brian Gerst" , linux-kernel@vger.kernel.org, x86@kernel.org Cc: "Ingo Molnar" , "H . Peter Anvin" , "Thomas Gleixner" , "Borislav Petkov" , "Rafael J . Wysocki" , "Len Brown" , "Pavel Machek" Message-Id: <6bcfd942-79ce-40d5-b3bc-0690efd06d0d@app.fastmail.com> In-Reply-To: <20260203175821.511847-1-brgerst@gmail.com> References: <20260203175821.511847-1-brgerst@gmail.com> Subject: Re: [PATCH v2 0/4] x86 suspend cleanups Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, 3 Feb 2026, at 18:58, Brian Gerst wrote: > This patchset cleans up the do_suspend_lowlevel() function, removing > some leftover bits that are no longer necessary since it started > using the SMP trampoline to resune the kernel. > > v2: > - Reworked the first patch > - Added more cleanups > > Brian Gerst (4): > x86/acpi/suspend: Remove indirect jump > x86/acpi/suspend: Remove segment reloads on resume > x86/acpi/suspend: Clean up stack usage > x86/acpi/suspend: Remove redundant register saves > This all looks correct to me - the stack changes in patch #3 do result in the stack misalignment to be different than it was before, but it is still 8 byte aligned throughout, which is all we care about in the kernel IIRC? So Reviewed-by: Ard Biesheuvel Tested-by: Ard Biesheuvel # qemu SMP suspend/resume