From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04133C0650E for ; Mon, 1 Jul 2019 18:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D04CC20B7C for ; Mon, 1 Jul 2019 18:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MbbSSbaZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727207AbfGASUM (ORCPT ); Mon, 1 Jul 2019 14:20:12 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:37431 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbfGASUL (ORCPT ); Mon, 1 Jul 2019 14:20:11 -0400 Received: by mail-io1-f68.google.com with SMTP id e5so30987042iok.4; Mon, 01 Jul 2019 11:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hsjfJFtXIc876oA6kbyjhF6TaAGhe5n/zUVcDCGFCBA=; b=MbbSSbaZuJ4ZksgU1YmbHop1HrlARCU+BRELQFsae+Da/z+8Cyk8LOHDXiBrbcc0I2 xdJphRwekKsFouuPzwmXTQrtGeDleRLUDeoDuGhuOJ3uFZg1W+nW4WKrXXnMOjGY8NVU 59u07k+5rq9mLpNc9P5JkESuM/px1EImjv/EiGLh5qZcMtsEZXfrKZzq3t2cZU0aooEx bflZlMadd45a1vyhdL6hFe8RHwpfBSga1FwCevz7bXCgTPMLKA3qEE31+85rZdzLOal0 w1lcZyxKGEFzCo5KoIq0F4eL4tX4v1nmEiQTGEBsPFg2k/VQrM7Va67Y/vTubuzV6RuC 0qug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hsjfJFtXIc876oA6kbyjhF6TaAGhe5n/zUVcDCGFCBA=; b=cL6OEQVRBKpTxfCBIiZCxgQf4boHJiOInTmW+6jn8OpED5WWQcFx3I+JE9wcBpy1UL VFZDbugM/9g9yjEeKf/iiDTY78b3WT66RIcXFdKH0xWAmhFHGG1Dk0htc61tRvd/JQZT /j5Z0+6XeI6sD0o3i8Y92/GlQuCxzzYOtcvj0BEWwXvhw2x3wijsM6uEeP7Q+nA1iWqt 2DK+fv1F//r4M69Fs4yacVlcEYkMkXZJUofeRcWdBz31SSm/kErYH2TS3kWQ1vHIO20n mDv4YtxIW3d7c3b7R4DseAuxvA3D3+k8+OYB+ui0ByzcAfX+llebohNn4xYpEr0Tl85u ybUg== X-Gm-Message-State: APjAAAX0w/OQbCs0IXiTGia4QYHsTfwdEeGZNbxgOMifAoJz7qrfRGt8 sz5lNnqNGQVUxsJuZ51v4xk= X-Google-Smtp-Source: APXvYqw3Din4wvxfk4QaVEIEM27/5WZC4/u2nLVeZAhuBD6dLmBFItt4JO4en3d51uvHf+IEXQDZBw== X-Received: by 2002:a5e:c241:: with SMTP id w1mr6151368iop.58.1562005210771; Mon, 01 Jul 2019 11:20:10 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:f191:fe61:9293:d1ca? ([2601:282:800:fd80:f191:fe61:9293:d1ca]) by smtp.googlemail.com with ESMTPSA id j23sm12048683ioo.6.2019.07.01.11.20.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jul 2019 11:20:10 -0700 (PDT) Subject: Re: [PATCH net v2] ipv4: don't set IPv6 only flags to IPv4 addresses To: Matteo Croce , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI References: <20190701170155.1967-1-mcroce@redhat.com> From: David Ahern Message-ID: <6bd2b840-41eb-c3c5-2405-adc104066617@gmail.com> Date: Mon, 1 Jul 2019 12:20:05 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/1/19 11:19 AM, David Ahern wrote: > I guess at this point we can fail the address add, so this is the best > option. bleh, that should be 'can not'