From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF4CC433FE for ; Wed, 26 Oct 2022 21:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233119AbiJZVe7 (ORCPT ); Wed, 26 Oct 2022 17:34:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbiJZVex (ORCPT ); Wed, 26 Oct 2022 17:34:53 -0400 Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA51E1D65D for ; Wed, 26 Oct 2022 14:34:50 -0700 (PDT) Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4MyMXT2zJSz9s87; Wed, 26 Oct 2022 21:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1666820089; bh=mK3QrnEPLUpU6dHFP51aqQ6A2Mwbwznsppi0dUK+dZg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QZOI114NIArbQbJ0bZ7rwElb3r1YLigD342ZVithOM433yAP/6AIKoHy23erpeygV ilbY8AkaLnGZ7AwImfvhJiiO4hVwCx/L49PqoqPDWG78C1uvB4AsvPaqdNSsmB/DbP 4l6LhpGkkur/kAStPKwB1o+LhK6xCXmlAgVSCzS8= X-Riseup-User-ID: A767155213843DF22C00E5927121719B7D7796EFC684842424197403131875F9 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4MyMXN4lYFz5vNH; Wed, 26 Oct 2022 21:34:44 +0000 (UTC) Message-ID: <6bd861cb-1eae-7f02-719b-8babfe7185dc@riseup.net> Date: Wed, 26 Oct 2022 18:34:41 -0300 MIME-Version: 1.0 Subject: Re: [PATCH] drm/tests: Add back seed value information Content-Language: en-US To: Arthur Grillo , David Airlie , Daniel Vetter , Javier Martinez Canillas , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , "Jason A. Donenfeld" Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Gow , Daniel Latypov , andrealmeid@riseup.net, melissa.srw@gmail.com, =?UTF-8?Q?Micha=c5=82_Winiarski?= References: <20221026211458.68432-1-arthurgrillo@riseup.net> From: =?UTF-8?Q?Ma=c3=adra_Canal?= In-Reply-To: <20221026211458.68432-1-arthurgrillo@riseup.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arthur, On 10/26/22 18:14, Arthur Grillo wrote: > As reported by Michał the drm_mm and drm_buddy unit tests lost the > printk with seed value after they being refactored into kunit. This Some grammar nits: - s/being/were - s/kunit/KUnit > patch adds back this important information to assure reproducibility > converting them to use the kunit api. > > Signed-off-by: Arthur Grillo > Reported-by: Michał Winiarski I believe that Michał's should come before your tag, as the SoB chain should reflect the real route a patch took as it was propagated to the maintainers [1]. > --- > drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++ > drivers/gpu/drm/tests/drm_mm_test.c | 4 +++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c > index 62f69589a72d..83c8863bc643 100644 > --- a/drivers/gpu/drm/tests/drm_buddy_test.c > +++ b/drivers/gpu/drm/tests/drm_buddy_test.c > @@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test) > while (!random_seed) > random_seed = get_random_u32(); > > + kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n", > + random_seed); I'm getting some compiling errors here: ERROR:root:../drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error: expected ')' random_seed); ^ ../drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '(' kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n", ^ You can reproduce it by running: $ ./tools/testing/kunit/kunit.py --kunitconfig=drivers/gpu/drm/tests Moreover, could you address the checkpatch issues? There are some misaligned parenthesis and the line are too big. > + > return 0; > } > > diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c > index c4b66eeae203..492347069d58 100644 > --- a/drivers/gpu/drm/tests/drm_mm_test.c > +++ b/drivers/gpu/drm/tests/drm_mm_test.c > @@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test) > while (!random_seed) > random_seed = get_random_u32(); > > + kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n", > + random_seed, max_iterations, max_prime); > + Same here. > return 0; > } > > @@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = { > }; > > kunit_test_suite(drm_mm_test_suite); > - There is no need to change this line. Thanks for your patch! [1] https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin Best Regards, - Maíra Canal > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL");