From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429AbeBTJdp (ORCPT ); Tue, 20 Feb 2018 04:33:45 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:46900 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbeBTJdm (ORCPT ); Tue, 20 Feb 2018 04:33:42 -0500 X-Google-Smtp-Source: AH8x225Rd4psSv3negpJUM6GHboifdZSrtSp79vX5DmytUqGwgHSkB52uRJvdUolEVBCSRJw1Sb9YQ== From: Srinivas Kandagatla Subject: Re: [PATCH v3 02/25] soc: qcom: add support to APR bus driver To: Rob Herring Cc: andy.gross@linaro.org, broonie@kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, david.brown@linaro.org, mark.rutland@arm.com, lgirdwood@gmail.com, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rohkumar@qti.qualcomm.com, spatakok@qti.qualcomm.com References: <20180213165837.1620-1-srinivas.kandagatla@linaro.org> <20180213165837.1620-3-srinivas.kandagatla@linaro.org> <20180219030819.qovj4swuvged6c24@rob-hp-laptop> Message-ID: <6be00df2-de80-0d40-9603-8b0fd94efa41@linaro.org> Date: Tue, 20 Feb 2018 09:33:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180219030819.qovj4swuvged6c24@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for review comments, On 19/02/18 03:08, Rob Herring wrote: > On Tue, Feb 13, 2018 at 04:58:14PM +0000,srinivas.kandagatla@linaro.org wrote: >> From: Srinivas Kandagatla >> >> This patch adds support toi APR bus (Asynchronous Packet Router) driver. >> ARP driver is made as a bus driver so that the apr devices can added removed >> more dynamically depending on the state of the services on the dsp. >> APR is used for communication between application processor and QDSP to >> use services on QDSP like Audio and others. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/soc/qcom/Kconfig | 9 + >> drivers/soc/qcom/Makefile | 1 + >> drivers/soc/qcom/apr.c | 381 +++++++++++++++++++++++++++++++++++++ >> include/dt-bindings/soc/qcom,apr.h | 27 +++ > This belongs in the binding patch. > I agree, will fix it in next version. >> include/linux/mod_devicetable.h | 11 ++ >> include/linux/soc/qcom/apr.h | 131 +++++++++++++ >> 6 files changed, 560 insertions(+) >> create mode 100644 drivers/soc/qcom/apr.c >> create mode 100644 include/dt-bindings/soc/qcom,apr.h >> create mode 100644 include/linux/soc/qcom/apr.h > >> diff --git a/include/dt-bindings/soc/qcom,apr.h b/include/dt-bindings/soc/qcom,apr.h >> new file mode 100644 >> index 000000000000..fb162ac4ca0e >> --- /dev/null >> +++ b/include/dt-bindings/soc/qcom,apr.h >> @@ -0,0 +1,27 @@ > SPDX tag Thanks for reminding this.. Will fix it in next spin. >