From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB82CCA489 for ; Tue, 26 Jul 2022 11:34:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233262AbiGZLet (ORCPT ); Tue, 26 Jul 2022 07:34:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbiGZLes (ORCPT ); Tue, 26 Jul 2022 07:34:48 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF608326C7; Tue, 26 Jul 2022 04:34:45 -0700 (PDT) X-UUID: f75321209fb341f38ef5686417260ba4-20220726 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:4afb44b6-2896-49b9-bcc6-335e5c17f80a,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACT ION:release,TS:-5 X-CID-META: VersionHash:0f94e32,CLOUDID:6a7c8ab3-06d2-48ef-b2dd-540836705165,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: f75321209fb341f38ef5686417260ba4-20220726 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1296717435; Tue, 26 Jul 2022 19:34:39 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Tue, 26 Jul 2022 19:34:38 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 26 Jul 2022 19:34:37 +0800 Message-ID: <6be179889a53bd7f5c281cb4ab0c4dd2e7306143.camel@mediatek.com> Subject: Re: [PATCH 3/4] media: mediatek: vcodec: Add mt8188 decoder's chip name From: "yunfei.dong@mediatek.com" To: Chen-Yu Tsai CC: Nicolas Dufresne , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , George Sun , Xiaoyong Lu , Hsin-Yi Wang , "Fritz Koenig" , Daniel Vetter , Irui Wang , Steve Cho , , , , , , Date: Tue, 26 Jul 2022 19:34:37 +0800 In-Reply-To: References: <20220726040155.17206-1-yunfei.dong@mediatek.com> <20220726040155.17206-3-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen-Yu, Thanks for your suggestion. I will merge patch 3 and 2 into one patch in v2. Best Regards, Yunfei DOng On Tue, 2022-07-26 at 16:28 +0800, Chen-Yu Tsai wrote: > On Tue, Jul 26, 2022 at 12:02 PM Yunfei Dong < > yunfei.dong@mediatek.com> wrote: > > > > Getting mt8188's chip name according to decoder compatible name. > > > > Signed-off-by: Yunfei Dong > > This should be squashed with the previous patch adding the compatible > to the driver. > > > --- > > drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > > index 7d194a476713..641f533c417f 100644 > > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > > @@ -227,6 +227,8 @@ static int mtk_vcodec_dec_get_chip_name(void > > *priv) > > return 8195; > > else if (of_device_is_compatible(dev->of_node, > > "mediatek,mt8186-vcodec-dec")) > > return 8186; > > + else if (of_device_is_compatible(dev->of_node, > > "mediatek,mt8188-vcodec-dec")) > > + return 8188; > > else > > return 8173; > > } > > -- > > 2.25.1 > >