From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECF9C433F5 for ; Tue, 12 Apr 2022 09:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241818AbiDLJav (ORCPT ); Tue, 12 Apr 2022 05:30:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384691AbiDLImO (ORCPT ); Tue, 12 Apr 2022 04:42:14 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 84A8A517D7 for ; Tue, 12 Apr 2022 01:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649750875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c1YyOBaSlUAB1FecJdXpHWi3Q4lLTndl19zr2Spu2No=; b=eRdoo+y+hlBPwFuOePOY7KPDNS1muoytKvzxkWfK3R+LLM9GNbUhr/TaIqCa0/fjr91+s+ IZwFYrPEYnlT7XQ6H3y9Mdz5YXJG121ksTRaW9B/Jg4QxR0Zy0BRC286pCmzM4G8s7Iq+q fGzb76fKUWw4XEoCon+tcgy2e5QoKds= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-vaoLSJYSN02V-7011k6g5g-1; Tue, 12 Apr 2022 04:07:54 -0400 X-MC-Unique: vaoLSJYSN02V-7011k6g5g-1 Received: by mail-wm1-f69.google.com with SMTP id i184-20020a1c3bc1000000b0038e4c5968b5so964379wma.0 for ; Tue, 12 Apr 2022 01:07:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=c1YyOBaSlUAB1FecJdXpHWi3Q4lLTndl19zr2Spu2No=; b=SVUxcCBBfaewcQy3ThoU7N6xBKZTCkIVJj6PvI6cYRmYE3dkvSRck9Jrmh5Wt7p2Z7 56/W3mQNxFCDCBicGaLlJLiVm0fxR4G0o6kIl5nwBZ2c8wWU8vZMCUF9cQdgRqPt3l7n uxfSPcxSnMK39tVIg88j1Ev+wxKIpTW++0RUPRV94vGaPCpaXk6VPygqoT0AuYJFqHva /C6aBM5QzCGGsoYE2OUKBvT/lgFGkH6hVWm8VYudJb0IKV8R6Q17w8MxN6J2W+sqbM6+ O9m9PtR32bLu6cnhBqDFdOXiPf729DTV8PnZ0u3kMl7R22xFPjQlNSaws69gW0XVeMFt vM9A== X-Gm-Message-State: AOAM530KO+Q0rAS5zK34ZUaRw3xs4u5L4mcvgk2PcZVD+/nYi/bYLaLc 1iGcXgL6L5AApcXxQl3XGc2shHEUv9S/LBzXjm1Ez+6YXeiMFxc8eGg2KrOGtXWSSUAnbWGys1a itn4k5sdJoVkHE+5nAqj3+5Aj X-Received: by 2002:a05:600c:3487:b0:38c:9a42:4d49 with SMTP id a7-20020a05600c348700b0038c9a424d49mr2952294wmq.29.1649750872749; Tue, 12 Apr 2022 01:07:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDglW+gKXgj96dHt92B2SeHkQs0c4KFSOD9iFaRTxgb+0c2t9/xh8a8ox8ht2X97EXHVi9og== X-Received: by 2002:a05:600c:3487:b0:38c:9a42:4d49 with SMTP id a7-20020a05600c348700b0038c9a424d49mr2952269wmq.29.1649750872365; Tue, 12 Apr 2022 01:07:52 -0700 (PDT) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id z5-20020a05600c0a0500b0037fa93193a8sm1922805wmp.44.2022.04.12.01.07.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 01:07:51 -0700 (PDT) Message-ID: <6be74110-a65b-7b77-ceac-9da640964ba0@redhat.com> Date: Tue, 12 Apr 2022 10:07:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 5/5] drm/solomon: Add SSD130x OLED displays SPI support Content-Language: en-US To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , Rob Herring , DRI Development , Neil Armstrong , Mark Brown , Andy Shevchenko , Chen-Yu Tsai , Chen-Yu Tsai , Daniel Vetter , David Airlie , Maxime Ripard , YueHaibing References: <20220411211243.11121-1-javierm@redhat.com> <20220411211243.11121-6-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/12/22 09:31, Geert Uytterhoeven wrote: [snip] >> + >> + t->spi = spi; >> + >> + t->dc = ssd130x_spi_get_dc(&spi->dev); >> + if (IS_ERR(t->dc)) >> + return PTR_ERR(t->dc); > > This can be simplified (no need for the PTR_ERR(ERR_PTR(...) dance) > by open-coding ssd130x_spi_get_dc() here. > Right, that will be better indeed. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat