From: Jan Beulich <jbeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@xilinx.com>,
Stable@vger.kernel.org, jgross@suse.com
Subject: Re: [PATCH] xen: don't continue xenstore initialization in case of errors
Date: Mon, 15 Nov 2021 11:08:22 +0100 [thread overview]
Message-ID: <6be8285f-6cbe-c115-a826-585664c91022@suse.com> (raw)
In-Reply-To: <20211112214709.1763928-1-sstabellini@kernel.org>
On 12.11.2021 22:47, Stefano Stabellini wrote:
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -983,8 +983,10 @@ static int __init xenbus_init(void)
> */
> proc_create_mount_point("xen");
> #endif
> + return err;
Personally I think such cases would better be "return 0". With
that done here, err's initializer could (imo should) then also
be dropped.
Jan
> out_error:
> + xen_store_domain_type = XS_UNKNOWN;
> return err;
> }
>
>
next prev parent reply other threads:[~2021-11-15 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 21:47 Stefano Stabellini
2021-11-15 10:08 ` Jan Beulich [this message]
2021-11-15 22:25 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be8285f-6cbe-c115-a826-585664c91022@suse.com \
--to=jbeulich@suse.com \
--cc=Stable@vger.kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®