From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84E8C385D84 for ; Mon, 13 Jul 2026 22:12:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783980774; cv=none; b=Qx/x+C1u40tk3kLWxGO4JMWeZ1vu0ZGic++xXsvLG5xS3g+A9ppwWJVjCMxlSdJKzNEM9GnrxKNteXAtdwh/cCjug4I79wCEtXtFTzat8NCvzirgEMpHQ/pKbnYObe4KIq2tmpp0pvNcaguNIJBS298eoe9WVNx4JPKQLgRz5J8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783980774; c=relaxed/simple; bh=mYidOFErwe8XH9CnmqqlwhT4wTP0xLaCDcmZL7YtxAI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=WwNLLCW+2C8L3Sd3Kcpai2lBxacMFDSPA0hqZc4xQv9bfMEdiNOw/VtT6Gm0NcH1yCIpoIAsF1FdjTEY1q2sMXZ0ZcMcwSRs95p28cWRFOJA9ulQDdhvXp/GH/LRP5UaGjJpcnzLuxyw3aetVOX2NJsYY7a56yZz/rH15xdcCCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qB1dsdvt; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qB1dsdvt" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c999f162c9aso2124855a12.3 for ; Mon, 13 Jul 2026 15:12:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783980773; x=1784585573; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=lnK70i1C9aIl1cpxDVKHYtJijlCbjXSvhvYuGxcBSCc=; b=qB1dsdvt8SvMSlf16S7/dAZiXlEZaFrMbTQLy4Rba0EVTeV5egvli4wx8YdXiVZMoE Wlvc+m9zj1VcOXxiofcHKOh47Ev0y6zZ0RDDc4swRunWF+Z5jyZFKPyq3thX0hsqH+0R SYX3aoHUlBbC6ligKV0O1I1MWiEIUPViG2uTCG/Fd0llMrgdu+m5XL23F34RslOCWkDA KJsYp0V8M9BKAnyw7RD8HC31uTJlNyFzSpomPzroLyx+KdLweW11sZ7ZQE//Cb73w4Co GwT+zY6wpy2eWVRmCsCokKEQanhlEjS7uu9EOSZJn68ovCDqW9WFYPd9p8lEE5LESMYr +0WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783980773; x=1784585573; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lnK70i1C9aIl1cpxDVKHYtJijlCbjXSvhvYuGxcBSCc=; b=rmtp2DEo5ST+30DOccMaI/NS/HPJMrBdSfuPxrO2ms0c2/BVpgyQuB9mv+80GpIQHL A0JeZyzt04xluK7rWAqPqK/8qMk//JXbx+/3Tfo1vwbd5AmYft9E8eJB5DQQiIR7Best NL1QcAbE6KXIQtYpqo/tCQ6BD1Z2054fcAnuF2mRZIXVAkvwr3o9fZ1infUUNxkqwTo+ G2SY7ptlFIdY64xy80TpYHx3cj7AG2KBb0lSasmHnupC+Y4fjQkzIFrAb9+67n/5DD82 Brfbqp4u5LvFO8HDyeKN8mViiHwVxp2yAMle1gfww4Am5DZ7Uoaa6gSNpfdnTlV6TqnG TPYQ== X-Forwarded-Encrypted: i=1; AHgh+RpIQNUlpx0D6OiSid0/+xIFkb8gASGSLdbSAvzfpCeitjHusWeDsJ/Agv0cGD7KjutycttbpZDojJGV3Qw=@vger.kernel.org X-Gm-Message-State: AOJu0YyuOEqf0RbD+Y+9ITvXWvkEmscvMbrZS+6Qw3UBF9bL3SZe+pqz M2MmaO+AgTpyhblgjxlmIhjk4czqAwTE2DQ8O+IC5o1ovAL34/Uav386 X-Gm-Gg: AfdE7cmgcaXEGxXPASe8nGVJjGnOzpyXcvmOyMeblip2e4ECrLR74TRpOxMA9sAiQPV uZeoQqHiPiwnxI6rHNkps3JF+I9AHUVV29Q1vG/U3sbBvQj9OUcNgGrJa8Eg+qH5UwBIlxiAE42 CiFap+rQcWaXrOFyDW4ScueMOfX6t2ilyI217cdg0AijGYAiRbANdxOgYAxQuiegBQywqPTw4Oe 9xiOIFTfopFE/8w+JTsd/lvN34+JCJVjADG74s5syZALjVCvKJL3ctv6fcPTI/P7Yr7oWvxbE2a hCNpgwpIuEUN2uH6s/7ACzBJff3MiM1eQqkgFyzVLh73TKcF8Z2yyqTYHIl0gmyPnPUnQkut+WF Q+KN3l9pwUISLQlNtvr5rCPXOupZ0+Vvio4wR14A7Ramk1JMsKxpIfAqo9WtO4Mu+EMNzOIa/B+ VJBuA5gthbdA8IaqREp++tPdSmRHgA20QthuclgKF+fBQIqXf7xfY= X-Received: by 2002:a05:6a21:517:b0:3bf:a0e5:99a0 with SMTP id adf61e73a8af0-3c34d71bd31mr1203285637.47.1783980772756; Mon, 13 Jul 2026 15:12:52 -0700 (PDT) Received: from [192.168.0.13] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3a2bf6bsm9152559a12.27.2026.07.13.15.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 15:12:52 -0700 (PDT) Message-ID: <6befa724e4fdc197f4a603246b4f95b65748882f.camel@gmail.com> Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Add testcases for callback with tailcall From: Eduard Zingerman To: Pu Lehui , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= , Daniel Borkmann Cc: Alexei Starovoitov , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Yonghong Song , Martin KaFai Lau , John Fastabend , Song Liu , Jiri Olsa , Emil Tsalapatis , Pu Lehui Date: Mon, 13 Jul 2026 15:12:49 -0700 In-Reply-To: <20260711104727.4023420-3-pulehui@huaweicloud.com> References: <20260711104727.4023420-1-pulehui@huaweicloud.com> <20260711104727.4023420-3-pulehui@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-10 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-07-11 at 10:47 +0000, Pu Lehui wrote: [...] > diff --git a/tools/testing/selftests/bpf/prog_tests/tailcalls.c b/tools/t= esting/selftests/bpf/prog_tests/tailcalls.c > index a5a226d0104c..c66037162da5 100644 > --- a/tools/testing/selftests/bpf/prog_tests/tailcalls.c > +++ b/tools/testing/selftests/bpf/prog_tests/tailcalls.c [...] > =C2=A0void test_tailcalls(void) > =C2=A0{ > =C2=A0 if (test__start_subtest("tailcall_1")) > @@ -1967,4 +1973,5 @@ void test_tailcalls(void) > =C2=A0 test_tailcall_cgrp_storage_no_storage_leaf(); > =C2=A0 if (test__start_subtest("tailcall_cgrp_storage_no_storage_bridge")= ) > =C2=A0 test_tailcall_cgrp_storage_no_storage_bridge(); > + test_tailcall_callback(); Please use test__start_subtest(). > =C2=A0} > diff --git a/tools/testing/selftests/bpf/progs/tailcall_callback.c b/tool= s/testing/selftests/bpf/progs/tailcall_callback.c > new file mode 100644 > index 000000000000..504d8e7a6996 > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/tailcall_callback.c [...] > +/* callback involving 1 subprog with tail call is rejected */ > +SEC("tc") > +__failure __msg("cannot tail call within callback") > +int tailcall_bpf2bpf_callback_1(struct __sk_buff *skb) > +{ > + clobber_regs_stack(); > + > + bpf_loop(1, callback_loop_2, &skb, 0); > + return 0; > +} I think having all three is a bit redundant, let's settle on tailcall_bpf2bpf_callback_1?