From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: "Paul Barker" <paul.barker.ct@bp.renesas.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
<netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [net-next PATCH v4 2/7] net: ravb: Consider busypolling status when re-enabling interrupts
Date: Tue, 28 May 2024 19:47:20 +0300 [thread overview]
Message-ID: <6bf07bb1-76c5-db5b-423b-a4c94bdf1ee3@omp.ru> (raw)
In-Reply-To: <669d3b51-d068-8816-37d1-dab2ffadb250@omp.ru>
On 5/28/24 7:44 PM, Sergey Shtylyov wrote:
>> Make use of the busypolling status returned from NAPI complete to decide
>
> My spellchecker/translator trip over "busypolling" -- consider using
> "busy-polling"?
> And did you actually mean napi_complete_done()?
Ah, napi_complete() also returns a result... maybe this should be reworded
as "NAPI completion"?
>> if interrupts shall be re-enabled or not. This is useful to reduce the
>> interrupt overhead.
>>
>> While at it switch to using napi_complete_done() as it take into account
>
> Takes.
>
>> the work done when providing the busypolling status.
>
> Again, "busy-polling"?
>
>> Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
[...]
MBR, Sergey
next prev parent reply other threads:[~2024-05-28 16:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 15:03 [net-next PATCH v4 0/7] Improve GbEth performance on Renesas RZ/G2L and related SoCs Paul Barker
2024-05-28 15:03 ` [net-next PATCH v4 1/7] net: ravb: Simplify poll & receive functions Paul Barker
2024-05-28 16:21 ` Sergey Shtylyov
2024-05-28 15:03 ` [net-next PATCH v4 2/7] net: ravb: Consider busypolling status when re-enabling interrupts Paul Barker
2024-05-28 16:44 ` Sergey Shtylyov
2024-05-28 16:47 ` Sergey Shtylyov [this message]
2024-05-29 19:09 ` Paul Barker
2024-05-28 15:03 ` [net-next PATCH v4 3/7] net: ravb: Refactor RX ring refill Paul Barker
2024-05-28 20:50 ` Sergey Shtylyov
2024-05-28 15:03 ` [net-next PATCH v4 4/7] net: ravb: Refactor GbEth RX code path Paul Barker
2024-05-29 18:30 ` Sergey Shtylyov
2024-05-29 19:07 ` Paul Barker
2024-05-30 20:37 ` Sergey Shtylyov
2024-05-28 15:03 ` [net-next PATCH v4 5/7] net: ravb: Enable SW IRQ Coalescing for GbEth Paul Barker
2024-05-28 15:03 ` [net-next PATCH v4 6/7] net: ravb: Use NAPI threaded mode on 1-core CPUs with GbEth IP Paul Barker
2024-05-28 15:03 ` [net-next PATCH v4 7/7] net: ravb: Allocate RX buffers via page pool Paul Barker
2024-05-29 20:52 ` Sergey Shtylyov
2024-05-30 9:21 ` Paul Barker
2024-05-30 10:29 ` Paul Barker
2024-05-31 17:25 ` Sergey Shtylyov
2024-06-01 10:13 ` Simon Horman
2024-06-03 8:02 ` Paul Barker
2024-06-03 12:07 ` Simon Horman
2024-06-03 12:15 ` Paul Barker
2024-06-05 17:18 ` Sergey Shtylyov
2024-06-03 20:45 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf07bb1-76c5-db5b-423b-a4c94bdf1ee3@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul.barker.ct@bp.renesas.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®