From: Tom Lendacky <thomas.lendacky@amd.com>
To: Ard Biesheuvel <ardb+git@google.com>, linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org, x86@kernel.org,
Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
Ingo Molnar <mingo@kernel.org>,
Kevin Loughlin <kevinloughlin@google.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Nikunj A Dadhania <nikunj@amd.com>
Subject: Re: [PATCH v6 03/22] x86/sev: Use MSR protocol only for early SVSM PVALIDATE call
Date: Tue, 29 Jul 2025 08:48:29 -0500 [thread overview]
Message-ID: <6bf4402b-7a16-d111-a5a1-fbf15edfd7b9@amd.com> (raw)
In-Reply-To: <20250722072708.2079165-27-ardb+git@google.com>
On 7/22/25 02:27, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> The early page state change API performs an SVSM call to PVALIDATE each
> page when running under a SVSM, and this involves either a GHCB page
> based call or a call based on the MSR protocol.
>
> The GHCB page based variant involves VA to PA translation of the GHCB
> address, and this is best avoided in the startup code, where virtual
> addresses are ambiguous (1:1 or kernel virtual).
>
> As this is the last remaining occurrence of svsm_perform_call_protocol()
> in the startup code, switch to the MSR protocol exclusively in this
> particular case, so that the GHCB based plumbing can be moved out of the
> startup code entirely in a subsequent patch.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> arch/x86/boot/compressed/sev.c | 20 --------------------
> arch/x86/boot/startup/sev-shared.c | 9 ++++++---
> 2 files changed, 6 insertions(+), 23 deletions(-)
>
next prev parent reply other threads:[~2025-07-29 13:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 7:27 [PATCH v6 00/22] x86: strict separation of startup code Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 01/22] x86/sev: Separate MSR and GHCB based snp_cpuid() via a callback Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 02/22] x86/sev: Use MSR protocol for remapping SVSM calling area Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 03/22] x86/sev: Use MSR protocol only for early SVSM PVALIDATE call Ard Biesheuvel
2025-07-29 13:48 ` Tom Lendacky [this message]
2025-07-22 7:27 ` [PATCH v6 04/22] x86/sev: Run RMPADJUST on SVSM calling area page to test VMPL Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 05/22] x86/sev: Move GHCB page based HV communication out of startup code Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 06/22] x86/sev: Avoid global variable to store virtual address of SVSM area Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 07/22] x86/sev: Share implementation of MSR-based page state change Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 08/22] x86/sev: Pass SVSM calling area down to early page state change API Ard Biesheuvel
2025-08-10 20:36 ` Borislav Petkov
2025-07-22 7:27 ` [PATCH v6 09/22] x86/sev: Use boot SVSM CA for all startup and init code Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 10/22] x86/boot: Drop redundant RMPADJUST in SEV SVSM presence check Ard Biesheuvel
2025-08-11 6:30 ` Borislav Petkov
2025-08-28 7:36 ` Ard Biesheuvel
2025-08-28 14:47 ` Borislav Petkov
2025-07-22 7:27 ` [PATCH v6 11/22] x86/boot: Provide PIC aliases for 5-level paging related constants Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 12/22] x86/sev: Provide PIC aliases for SEV related data objects Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 13/22] x86/sev: Move __sev_[get|put]_ghcb() into separate noinstr object Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 14/22] x86/sev: Export startup routines for later use Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 15/22] objtool: Add action to check for absence of absolute relocations Ard Biesheuvel
2025-08-11 7:20 ` Borislav Petkov
2025-07-22 7:27 ` [PATCH v6 16/22] x86/boot: Check startup code " Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 17/22] x86/boot: Revert "Reject absolute references in .head.text" Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 18/22] x86/kbuild: Incorporate boot/startup/ via Kbuild makefile Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 19/22] x86/boot: Create a confined code area for startup code Ard Biesheuvel
2025-08-11 10:19 ` Borislav Petkov
2025-07-22 7:27 ` [PATCH v6 20/22] efistub/x86: Remap inittext read-execute when needed Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 21/22] x86/boot: Move startup code out of __head section Ard Biesheuvel
2025-08-11 17:40 ` Borislav Petkov
2025-08-11 18:05 ` Tom Lendacky
2025-08-11 19:03 ` Borislav Petkov
2025-08-14 17:17 ` Tom Lendacky
2025-08-28 6:50 ` Ard Biesheuvel
2025-08-28 6:55 ` Ard Biesheuvel
2025-07-22 7:27 ` [PATCH v6 22/22] x86/boot: Get rid of the .head.text section Ard Biesheuvel
2025-08-11 14:17 ` [PATCH v6 00/22] x86: strict separation of startup code Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf4402b-7a16-d111-a5a1-fbf15edfd7b9@amd.com \
--to=thomas.lendacky@amd.com \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=jpoimboe@kernel.org \
--cc=kevinloughlin@google.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nikunj@amd.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®