From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48F0A35AC17 for ; Sat, 13 Jun 2026 07:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781336474; cv=none; b=S9PYC0dMX9M6dyRmCfajowNTLmvEax8MM2jkMse6TeTdk0U4laK4wrgg4moXMQnlX7jzN0VB9TDSt3DeotcBUzb31MsT1PsUf4FyxXC4SdqKanIINIyl91XYmL9TaFnrI5ToZjJs27tFFOV2fobiZJs3AH9aalmQSy8cvDfepe0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781336474; c=relaxed/simple; bh=W/N+tw1LxpgvVpwvbWlWKp/WUMBhf8WS2wtHORfwQAQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hAchky6XXcLyBObtUUdNOfm6Ul8dvttGdbqkwGaUnhM6fRq2t4CzEBd9mmcQxaAmxAxF/Enpe5UKms50U3TGp5MJoG0ysh3XaEe/jIeECJtVHC2o7/2aQgk+PTQ9HDYkk77WsMUBgvLSmAyC5/PPUaM9F0K52tOctydxYSBpbE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X7mhG1qB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VU4DFyM6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X7mhG1qB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VU4DFyM6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781336472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u2c8kiVJHUhhKHp0g0/L8bPiJTp/p1OcNdLSuFPcX3k=; b=X7mhG1qBQcr+UnNkQihGCqBeXXygvFp4XZ/thiQy0IdO6+gseGfX7A6TqzIzLzK9cpXRFG SwMZ8miCREBW8Qft1YPhhznCS1pveTRuxsSDaqAGndB/ZKt7xWPpU4iKmG6fo8j0JuNXYP 7/pdIjy4dDC5XYaJrHAE/1vXe87PbBg= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-fz0TjZQXNpeAkKBV8Eh4uw-1; Sat, 13 Jun 2026 03:41:10 -0400 X-MC-Unique: fz0TjZQXNpeAkKBV8Eh4uw-1 X-Mimecast-MFC-AGG-ID: fz0TjZQXNpeAkKBV8Eh4uw_1781336470 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51787404d3eso33588371cf.1 for ; Sat, 13 Jun 2026 00:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781336470; x=1781941270; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u2c8kiVJHUhhKHp0g0/L8bPiJTp/p1OcNdLSuFPcX3k=; b=VU4DFyM6FqmEUvtnU4Sbq7016ZFM6NenOY1P+pUmXGzkAd+WmaFvu73HRij4086CL9 NvqnEXhJ31QOuWJCIZJWH7tZ0fgx9U5yBYxtM0rk28vCOkB2Dkrzxm+zhYW+QvKuy6ex 7n/zIwWJugsxeS74zhLS76+i3dPQx/lm34drde+MDUwXF9ytKPTxrN5qjkTvDutOAYAQ Th/b8l03D62VtJPbA5Qk45DlxInLBplUQ7cNIlCUe7NbF37Gsn1N8lK/IO5srbN+7jy/ jWbNz4WXezSt0CK6mvPO8RUSo96vFBhFp4Z0OENq4NvJigZtF8jzjQhcok7wZRQotgOK sfIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781336470; x=1781941270; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u2c8kiVJHUhhKHp0g0/L8bPiJTp/p1OcNdLSuFPcX3k=; b=HoVvJsg/IawF8teqCSKTfpzp5wSjHeBgvgsysMafulIQVzV+jlP8zYBcEwxHGTszH7 sRiPTeuKG34vJ+ASdKzO4M/IzseMayos4eWd7rGwZAAQEJQCZQ1JsFoGOydk0XVU0WQP EdpG6+wHyVe67IrNsbnBD5ugi3FyRHA6nUbHEh2NKMRcLbBg7piIjpXJ+1dQABkoqxtr ulf82d/3P1RDzoEHM1GldwcnuCoMfUG6V7wQaxpUMLXD7ccJqCZwI0Ve0TxUzYEoZE3e zO4j2XLpdgvZYwG1jSyMY4+UsoqS5YS3gbkLdjC3QOqOH5GTYluQgSwb9Nw+FD42jZT0 ayQA== X-Forwarded-Encrypted: i=1; AFNElJ8EGapFE+y5tYRnnvzSciLqsZslvwnBT1rpiHwsE88/bHiMP7RYePr/kr0m2dZDRfJ3WlFCKenHXWdJdwk=@vger.kernel.org X-Gm-Message-State: AOJu0YxobhIm6JB/SbMJvVX1G4p+lIjHiCTX9n46JtRa2RcZ0V20aGKl JFvXsY0HBpbdpCKE8LUa/C8EafO5xvdp7CN2fSvijh9VA7+JzMZtZUq+h1l/voRCNQp/69XJdwx g9hgL88vlR4K2bvnAhD6EheSrdTG+CP9eW+ZAKeP2yvqVp+ZueLplhi3mpgh5sDbpRg== X-Gm-Gg: Acq92OGEwOnoitCf3FbVrol4gypBvGPBZtoPXEok3t4dJFndm4HwhhIiTWKmRxtz4oy /Cf5b6SIVtm4yNaQzAY/2K26EcuIDehNEXNaDbVWpgPPKrjNFuTKJt1MdgNj5GtZy+YnKl0rJHT fU77CVwjtKVJrq29flG3fj8xIHI4WZm61vKN9o6DwHe/auUH1jt2itkFhmdfkrZVaajy1EfzChe QfSYY6TUzyYZhuCHOBKkfGcX95WzH31y9TZT77ojfX+Swhm+0Q6Io1gj/Sd15JM0eOyjToF2ktL QU+AofbEcVYwB9gQpbSO3EFn9o3uMts51u+ZO1wPavkajiQ5P6vvApcg6HdCuZcx0/BPGk0lC8A Si5Xiy1FTpWykvBVhZXAeGkiyJ5gowg2kxRquLGWqNy/VijoirQeIxXc= X-Received: by 2002:a05:620a:6cce:b0:915:efa6:d704 with SMTP id af79cd13be357-9161bd4eb21mr946492385a.49.1781336470215; Sat, 13 Jun 2026 00:41:10 -0700 (PDT) X-Received: by 2002:a05:620a:6cce:b0:915:efa6:d704 with SMTP id af79cd13be357-9161bd4eb21mr946491085a.49.1781336469810; Sat, 13 Jun 2026 00:41:09 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.72]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9161a00ad75sm441913885a.25.2026.06.13.00.41.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 00:41:09 -0700 (PDT) Message-ID: <6bf63337-9382-4dc3-8940-3cfea00c5193@redhat.com> Date: Sat, 13 Jun 2026 09:41:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: pch_gbe: handle TX skb allocation failure To: Ruoyu Wang , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260608163005.6-1-ruoyuw560@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260608163005.6-1-ruoyuw560@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/8/26 6:30 PM, Ruoyu Wang wrote: > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c > index 62f05f4569b10..a426243a5fa34 100644 > --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c > @@ -1420,13 +1420,23 @@ pch_gbe_alloc_rx_buffers_pool(struct pch_gbe_adapter *adapter, > return 0; > } > > +static void pch_gbe_free_rx_buffers_pool(struct pch_gbe_adapter *adapter, > + struct pch_gbe_rx_ring *rx_ring) > +{ > + dma_free_coherent(&adapter->pdev->dev, rx_ring->rx_buff_pool_size, > + rx_ring->rx_buff_pool, rx_ring->rx_buff_pool_logic); > + rx_ring->rx_buff_pool_logic = 0; > + rx_ring->rx_buff_pool_size = 0; > + rx_ring->rx_buff_pool = NULL; > +} > + > /** > * pch_gbe_alloc_tx_buffers - Allocate transmit buffers > * @adapter: Board private structure > * @tx_ring: Tx descriptor ring > */ > -static void pch_gbe_alloc_tx_buffers(struct pch_gbe_adapter *adapter, > - struct pch_gbe_tx_ring *tx_ring) > +static int pch_gbe_alloc_tx_buffers(struct pch_gbe_adapter *adapter, > + struct pch_gbe_tx_ring *tx_ring) With this change you should update accordingly the kdoc above documenting the return value, to avoid this warning: Warning: drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:1439 No description found for return value of 'pch_gbe_alloc_tx_buffers' /P