From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>, david.vrabel@citrix.com
Cc: roger.pau@citrix.com, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/8] xen/x86: Remove PVH support
Date: Tue, 18 Oct 2016 11:42:26 -0400 [thread overview]
Message-ID: <6bfab4fc-3576-3753-5660-861eda1153c1@oracle.com> (raw)
In-Reply-To: <8278b0a6-d114-9775-eb88-6292a9a2ab34@suse.com>
On 10/18/2016 11:33 AM, Juergen Gross wrote:
> On 18/10/16 16:45, Boris Ostrovsky wrote:
>> On 10/18/2016 09:46 AM, Juergen Gross wrote:
>>> On 14/10/16 20:05, Boris Ostrovsky wrote:
>>>> We are replacing existing PVH guests with new implementation.
>>>>
>>>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>> Reviewed-by: Juergen Gross <jgross@suse.com>
>>>
>>> with the following addressed:
>>>
>>>> diff --git a/include/xen/xen.h b/include/xen/xen.h
>>>> index f0f0252..d0f9684 100644
>>>> --- a/include/xen/xen.h
>>>> +++ b/include/xen/xen.h
>>>> @@ -29,17 +29,6 @@ enum xen_domain_type {
>>>> #define xen_initial_domain() (0)
>>>> #endif /* CONFIG_XEN_DOM0 */
>>>>
>>>> -#ifdef CONFIG_XEN_PVH
>>>> -/* This functionality exists only for x86. The XEN_PVHVM support exists
>>>> - * only in x86 world - hence on ARM it will be always disabled.
>>>> - * N.B. ARM guests are neither PV nor HVM nor PVHVM.
>>>> - * It's a bit like PVH but is different also (it's further towards the H
>>>> - * end of the spectrum than even PVH).
>>>> - */
>>>> -#include <xen/features.h>
>>>> -#define xen_pvh_domain() (xen_pv_domain() && \
>>>> - xen_feature(XENFEAT_auto_translated_physmap))
>>>> -#else
>>>> #define xen_pvh_domain() (0)
>>> Any reason you don't remove this, too (together with its last user in
>>> arch/x86/xen/grant-table.c) ?
>> grant-table.c is in fact one of the reasons: we will be using that code
>> for PVHv2 again so I kept it to avoid unnecessary code churn.
>>
>> Also, we want to have a nop definition of xen_pvh_domain() for
>> !CONFIG_XEN_PVH.
> Okay, could you mention this in the commit message, please?
Will do.
-boris
next prev parent reply other threads:[~2016-10-18 15:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 18:05 [PATCH 0/8] PVH v2 support Boris Ostrovsky
2016-10-14 18:05 ` [PATCH 1/8] xen/x86: Remove PVH support Boris Ostrovsky
2016-10-14 18:31 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-18 13:46 ` Juergen Gross
2016-10-18 14:45 ` Boris Ostrovsky
2016-10-18 15:33 ` Juergen Gross
2016-10-18 15:42 ` Boris Ostrovsky [this message]
2016-10-14 18:05 ` [PATCH 2/8] x86/head: Refactor 32-bit pgtable setup Boris Ostrovsky
2016-10-14 18:31 ` hpa
2016-10-14 18:44 ` Boris Ostrovsky
2016-10-14 19:04 ` hpa
2016-10-14 19:18 ` Boris Ostrovsky
2016-10-31 12:33 ` Boris Ostrovsky
2016-12-01 15:33 ` Boris Ostrovsky
2016-12-02 9:45 ` Ingo Molnar
2016-12-02 14:04 ` Boris Ostrovsky
2016-12-02 16:08 ` Ingo Molnar
2016-12-02 17:52 ` hpa
2016-12-02 19:49 ` Boris Ostrovsky
2016-12-03 5:49 ` Ingo Molnar
2016-12-03 6:36 ` hpa
2016-10-14 18:05 ` [PATCH 3/8] xen/pvh: Import PVH-related Xen public interfaces Boris Ostrovsky
2016-10-14 18:34 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-21 10:58 ` Juergen Gross
2016-10-14 18:05 ` [PATCH 4/8] xen/pvh: Bootstrap PVH guest Boris Ostrovsky
2016-10-14 18:38 ` [Xen-devel] " Andrew Cooper
2016-10-14 18:55 ` Boris Ostrovsky
2016-10-14 19:12 ` Andrew Cooper
2016-10-14 19:14 ` Konrad Rzeszutek Wilk
2016-10-14 19:34 ` Boris Ostrovsky
2016-10-14 18:05 ` [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC Boris Ostrovsky
2016-10-14 19:16 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-14 19:37 ` Boris Ostrovsky
2016-10-26 10:42 ` Roger Pau Monné
2016-10-26 14:50 ` Boris Ostrovsky
2016-10-26 15:18 ` Roger Pau Monné
2016-10-26 16:06 ` Boris Ostrovsky
2016-10-14 18:05 ` [PATCH 6/8] xen/pvh: Initialize grant table for PVH guests Boris Ostrovsky
2016-10-14 19:19 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-14 19:43 ` Boris Ostrovsky
2016-10-14 19:51 ` Konrad Rzeszutek Wilk
2016-10-14 20:02 ` Boris Ostrovsky
2016-10-18 16:08 ` Juergen Gross
2016-10-18 16:40 ` Boris Ostrovsky
2016-10-19 5:47 ` Juergen Gross
2016-10-14 18:05 ` [PATCH 7/8] xen/pvh: PVH guests always have PV devices Boris Ostrovsky
2016-10-14 19:17 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-18 15:54 ` Juergen Gross
2016-10-14 18:05 ` [PATCH 8/8] xen/pvh: Enable CPU hotplug Boris Ostrovsky
2016-10-14 18:41 ` [Xen-devel] " Andrew Cooper
2016-10-14 19:01 ` Boris Ostrovsky
2016-10-27 14:25 ` Boris Ostrovsky
2016-10-27 15:00 ` Andrew Cooper
2016-10-27 16:23 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bfab4fc-3576-3753-5660-861eda1153c1@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®