From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFC9C7EE29 for ; Thu, 8 Jun 2023 08:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234260AbjFHIxr (ORCPT ); Thu, 8 Jun 2023 04:53:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233887AbjFHIxp (ORCPT ); Thu, 8 Jun 2023 04:53:45 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 476CFE50 for ; Thu, 8 Jun 2023 01:53:43 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-514ab6cb529so3013905a12.1 for ; Thu, 08 Jun 2023 01:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686214422; x=1688806422; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AxDnfIeGDEgjasab2xKCt2UI0vyBkLC9/9iWa3HZ5tY=; b=R4G6uV1oPJlGhXrHkHDxx5b6w78932R2vqY4HcD9F6age09jph14lshZeGu7tcC23b 3hCfI/UwGcxwAaDmrAnlI3nK2SsqAv9+3WDRI7/AzhxMlm1uBNsseKl4zwfmBqXlLS2t 1Pe+T0jaFHR/1kHXwyGIy6xyRmHw5vFLmdM3fHI+Zgg2zfKFUS2QO5ZdqhguucjdLz7B VYi2GUBeHprA8enq8KtoGj0N5h4onepaxo4bIXTchaG8R55FPgDbo1KxRt1vffkcJRoY d3s8O4riIj/XjqSmvRTi+9mKH++AEORXbDwyNEogbr3ZL1y/U53kYVo5DIEuW/hleFUf 8J6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686214422; x=1688806422; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AxDnfIeGDEgjasab2xKCt2UI0vyBkLC9/9iWa3HZ5tY=; b=ReDuUEyVNxGEEieFrsR+C2mCHCrctxq32ZjW+a5mP9rxCREOz1rkmWg6DMFsO/G2XE mtb2EA9hn+BOPRApzBzZd+T/fx7uJ7J8WIMw+jiqo5RJSCG3PEN3kHOTNUENrm2sAt7P i5x6RWw8VZ9g8drBGecKSAzTl/f3JaVH+7FDjaQLuvM8I9TxzRSrggHB7a0OAAAXo8WH YGnzNOr9uYq7t38g34tQvsvMhZ+ZUkYcHgKj8UV9DGKCfZ4vKOP35LTdRUpF6RLoPLBt 03iOX8SE2F8CH/gjPbiHTLwOOtY8douPawn5GR6ySnaMrP+QcQnRS/F9O19GpdEahN+g v81w== X-Gm-Message-State: AC+VfDwvIY/l2P/yHz5ZqQZ0ruPQtIQ8VMNVx2sptXxgC/l4U1EYGxUf fZ91g1aLc3BefItgGovLRkr+NQ== X-Google-Smtp-Source: ACHHUZ6i1hcbV1Jj4VkqrWiOWrWz7QhzUl+9EviEgTci4V/Qbd9pvKDui7qf7SKn2NPoZaK5mkX1LA== X-Received: by 2002:a17:907:6d85:b0:978:9235:d450 with SMTP id sb5-20020a1709076d8500b009789235d450mr1601734ejc.9.1686214421801; Thu, 08 Jun 2023 01:53:41 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id cf20-20020a170906b2d400b00977d14d89fesm411822ejb.34.2023.06.08.01.53.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 01:53:41 -0700 (PDT) Message-ID: <6bfc2a22-6901-0858-7b90-bc4c52c66810@linaro.org> Date: Thu, 8 Jun 2023 10:53:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v12 1/2] spi: add loongson spi bindings Content-Language: en-US To: zhuyinbo , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn References: <20230608072819.25930-1-zhuyinbo@loongson.cn> <20230608072819.25930-2-zhuyinbo@loongson.cn> <6ebed84c-2b42-c981-7b3f-e71cc88e4c2c@linaro.org> <4bf747c4-b767-b20c-e00f-724b50f44edb@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <4bf747c4-b767-b20c-e00f-724b50f44edb@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/06/2023 10:39, zhuyinbo wrote: >>> >>> Signed-off-by: Yinbo Zhu >>> Reviewed-by: Krzysztof Kozlowski >>> --- >>> .../bindings/spi/loongson,ls2k-spi.yaml | 41 +++++++++++++++++++ >>> MAINTAINERS | 6 +++ >>> 2 files changed, 47 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>> new file mode 100644 >>> index 000000000000..423ee851edd5 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >> >> Filename based on compatible. > > > There will be more ls2k series SoC spi device in the future thus I still > use "loongson,ls2k-spi.yaml" for cover it. Add them now. > >> >>> @@ -0,0 +1,41 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/spi/loongson,ls2k-spi.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Loongson SPI controller >>> + >>> +maintainers: >>> + - Yinbo Zhu >>> + >>> +allOf: >>> + - $ref: /schemas/spi/spi-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - loongson,ls2k1000-spi >> >> No compatibles for other devices? Didn't we have big discussion about this? >> >> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 > > > There are other ls2k SPI devices compatible, such as, > "loongson,ls2k0500-spi", "loongson,ls2k2000-spi" but currently I plan to > add ls2k1000 spi device first, Other ls2k SoC spi device adaptation may > require some additional work and I will add it later. Previously you claimed this serves entire family, so I don't understand why you need to fix something. Why previously it was working for entire family but now it does not? Best regards, Krzysztof