From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751983AbdCPIQI (ORCPT ); Thu, 16 Mar 2017 04:16:08 -0400 Received: from mail.hostpark.net ([212.243.197.30]:53380 "EHLO mail.hostpark.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbdCPIQE (ORCPT ); Thu, 16 Mar 2017 04:16:04 -0400 X-Greylist: delayed 576 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Mar 2017 04:16:03 EDT Subject: Re: [PATCH linux v4 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver To: Jaghathiswari Rankappagounder Natarajan , joel@jms.id.au, jdelvare@suse.com, linux@roeck-us.net, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org References: <20170311015351.23092-1-jaghu@google.com> <20170311015351.23092-2-jaghu@google.com> From: =?UTF-8?Q?David_M=c3=bcller_=28ELSOFT_AG=29?= Organization: ELSOFT AG Message-ID: <6c028b76-ccc3-46ba-7a41-fa1b7b4a5b77@elsoft.ch> Date: Thu, 16 Mar 2017 09:05:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 MIME-Version: 1.0 In-Reply-To: <20170311015351.23092-2-jaghu@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jaghathiswari Rankappagounder Natarajan wrote: > +- compatible : should be "aspeed,aspeed2400-pwm-tacho" for AST2400 > or + "aspeed,aspeed2500-pwm-tacho" for AST2500. Shouldn't this be "aspeed,ast2400-pwm-tacho" and "aspeed,ast2500-pwm-tacho", as this is the naming scheme used for all the other AST2x00 devices currently present in "aspeed-g[45].dtsi"? Dave