From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DC15291C3F for ; Wed, 28 Jan 2026 07:50:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769586645; cv=none; b=jovT5RnrmDVr5obdbkeqa72lNE14O+fSg9XKsorvyGwtf7wFJAwwiVHlTz3GNCOxlxqIDAdkEjTo4SPDQjd3GrTi4T0GOiU8Dzhq3n/s6L/K93VcBJ0l3Q19zeAvrFV3EYYnVYwOITRm6ZortXO7bIolxXvEO5QPhLSXyKlvRkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769586645; c=relaxed/simple; bh=RmhF5WhACuwdd13kcqw2cYWQ4aB5aUlJ3NtINYUTAC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DgK4zxp1dKa5t6RnqIxezKqFHwUT/81coyEcQef6pe1dRizFfac0QZ2FAGktLRwl4ED1uAQGciCRLadO31ksDdB1DmW7/6p0YwxCE6kmUB/lwJLhM4WBlkIMYYvVMasOq9MPOLZH+skd82FCKVvbrFxE+pFAJV+bZoZbKR8NAYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=DtDnefQJ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=s/Ki7tDO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=DtDnefQJ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=s/Ki7tDO; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DtDnefQJ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="s/Ki7tDO"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DtDnefQJ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="s/Ki7tDO" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5687F33A81; Wed, 28 Jan 2026 07:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769586641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Aa1gMe/mq9inWqiC7tTfzhj550KM1ThH2HM5vZVIxzY=; b=DtDnefQJMkDWCKpWgRGa1AWF70af8MVO2vSRsePVQvDPmU7MRFTigsLtO14DD8EidgMMip pXbcgpijwj/xD2oJbl2QZMoQAVTGaX6KFB6iuJbzRa9EUEahxPHVZxtQPPN0pdhNORdc0n G+xPL/9RbwJMLAwi78VO6QzluruBDLU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769586641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Aa1gMe/mq9inWqiC7tTfzhj550KM1ThH2HM5vZVIxzY=; b=s/Ki7tDOtT+GM0o2CO3oxKCJmMo8NxCui5jFNFp56r+SCKX5YruNJFkKuAmm14iFHwAT+d d7HpuyZldGSlywAQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DtDnefQJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="s/Ki7tDO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769586641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Aa1gMe/mq9inWqiC7tTfzhj550KM1ThH2HM5vZVIxzY=; b=DtDnefQJMkDWCKpWgRGa1AWF70af8MVO2vSRsePVQvDPmU7MRFTigsLtO14DD8EidgMMip pXbcgpijwj/xD2oJbl2QZMoQAVTGaX6KFB6iuJbzRa9EUEahxPHVZxtQPPN0pdhNORdc0n G+xPL/9RbwJMLAwi78VO6QzluruBDLU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769586641; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Aa1gMe/mq9inWqiC7tTfzhj550KM1ThH2HM5vZVIxzY=; b=s/Ki7tDOtT+GM0o2CO3oxKCJmMo8NxCui5jFNFp56r+SCKX5YruNJFkKuAmm14iFHwAT+d d7HpuyZldGSlywAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 957CC3EA61; Wed, 28 Jan 2026 07:50:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yyMLI9C/eWnYegAAD6G6ig (envelope-from ); Wed, 28 Jan 2026 07:50:40 +0000 Message-ID: <6c037a3d-8061-422b-827b-c3795dd89477@suse.de> Date: Wed, 28 Jan 2026 08:50:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon display controllers To: Icenowy Zheng , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Drew Fustini , Guo Ren , Fu Wei Cc: Philipp Zabel , Dmitry Baryshkov , Michal Wilczynski , Luca Ceresoli , Han Gao , Yao Zi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Han Gao References: <20260116043746.336328-1-zhengxingda@iscas.ac.cn> <20260116043746.336328-4-zhengxingda@iscas.ac.cn> <56e1974c-0fe6-4bdb-918d-fcf6a8b866c1@suse.de> <7bffdc45628fec9dd8175f696d3a68aa1e12f0a2.camel@icenowy.me> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <7bffdc45628fec9dd8175f696d3a68aa1e12f0a2.camel@icenowy.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[icenowy.me,intel.com,linaro.org,kernel.org,ideasonboard.com,kwiboo.se,gmail.com,linux.intel.com,ffwll.ch,redhat.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[28]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[pengutronix.de,kernel.org,samsung.com,bootlin.com,gmail.com,disroot.org,vger.kernel.org,lists.freedesktop.org,lists.infradead.org,iscas.ac.cn]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; R_RATELIMIT(0.00)[to_ip_from(RLhco1tq9et14njsu3qecxcejq)]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[dt]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.com:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Spam-Flag: NO X-Spam-Score: -3.01 X-Rspamd-Queue-Id: 5687F33A81 X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: Hi Am 22.01.26 um 10:47 schrieb Icenowy Zheng: > 在 2026-01-21星期三的 13:56 +0100,Thomas Zimmermann写道: > > =================== 8< ==================== >>> +void drm_format_to_vs_format(u32 drm_format, struct vs_format >>> *vs_format) >>> +{ >>> +       switch (drm_format) { >>> +       case DRM_FORMAT_XRGB4444: >>> +       case DRM_FORMAT_RGBX4444: >>> +       case DRM_FORMAT_XBGR4444: >>> +       case DRM_FORMAT_BGRX4444: >>> +               vs_format->color = VSDC_COLOR_FORMAT_X4R4G4B4; >>> +               break; >>> +       case DRM_FORMAT_ARGB4444: >>> +       case DRM_FORMAT_RGBA4444: >>> +       case DRM_FORMAT_ABGR4444: >>> +       case DRM_FORMAT_BGRA4444: >>> +               vs_format->color = VSDC_COLOR_FORMAT_A4R4G4B4; >>> +               break; >>> +       case DRM_FORMAT_XRGB1555: >>> +       case DRM_FORMAT_RGBX5551: >>> +       case DRM_FORMAT_XBGR1555: >>> +       case DRM_FORMAT_BGRX5551: >>> +               vs_format->color = VSDC_COLOR_FORMAT_X1R5G5B5; >>> +               break; >>> +       case DRM_FORMAT_ARGB1555: >>> +       case DRM_FORMAT_RGBA5551: >>> +       case DRM_FORMAT_ABGR1555: >>> +       case DRM_FORMAT_BGRA5551: >>> +               vs_format->color = VSDC_COLOR_FORMAT_A1R5G5B5; >>> +               break; >>> +       case DRM_FORMAT_RGB565: >>> +       case DRM_FORMAT_BGR565: >>> +               vs_format->color = VSDC_COLOR_FORMAT_R5G6B5; >>> +               break; >>> +       case DRM_FORMAT_XRGB8888: >>> +       case DRM_FORMAT_RGBX8888: >>> +       case DRM_FORMAT_XBGR8888: >>> +       case DRM_FORMAT_BGRX8888: >>> +               vs_format->color = VSDC_COLOR_FORMAT_X8R8G8B8; >>> +               break; >>> +       case DRM_FORMAT_ARGB8888: >>> +       case DRM_FORMAT_RGBA8888: >>> +       case DRM_FORMAT_ABGR8888: >>> +       case DRM_FORMAT_BGRA8888: >>> +               vs_format->color = VSDC_COLOR_FORMAT_A8R8G8B8; >>> +               break; >>> +       case DRM_FORMAT_ARGB2101010: >>> +       case DRM_FORMAT_RGBA1010102: >>> +       case DRM_FORMAT_ABGR2101010: >>> +       case DRM_FORMAT_BGRA1010102: >>> +               vs_format->color = VSDC_COLOR_FORMAT_A2R10G10B10; >>> +               break; >>> +       default: >>> +               DRM_WARN("Unexpected drm format!\n"); >> drm_warn(). If this can be invoked from user space,easily, better use >> drm_dbg() > This function is called during atomic_update of planes, and I think in > this case the unknown formats should already be rejected because > they're not advertised for any planes. > > Did I get it right on this? Yes. In principle you should never reach the default case. This message is only for testing internally. What I usually do is to compute such internal values in the atomic_check helper and then store them in the respective state. Here, you'd need a custom struct vs_plane_state to hold them. If the format conversion fails in atomic_check, it can still return an errno code to user space. Doing this throughout the driver pushes all/most fail states before the 'magic barrier.' [1] [1] https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/gpu/drm/drm_atomic_helper.c#L2278 > >>> +       } >>> + >>> +       switch (drm_format) { >>> +       case DRM_FORMAT_RGBX4444: >>> +       case DRM_FORMAT_RGBA4444: >>> +       case DRM_FORMAT_RGBX5551: >>> +       case DRM_FORMAT_RGBA5551: >>> +       case DRM_FORMAT_RGBX8888: >>> +       case DRM_FORMAT_RGBA8888: >>> +       case DRM_FORMAT_RGBA1010102: >>> +               vs_format->swizzle = VSDC_SWIZZLE_RGBA; >>> +               break; >>> +       case DRM_FORMAT_XBGR4444: >>> +       case DRM_FORMAT_ABGR4444: >>> +       case DRM_FORMAT_XBGR1555: >>> +       case DRM_FORMAT_ABGR1555: >>> +       case DRM_FORMAT_BGR565: >>> +       case DRM_FORMAT_XBGR8888: >>> +       case DRM_FORMAT_ABGR8888: >>> +       case DRM_FORMAT_ABGR2101010: >>> +               vs_format->swizzle = VSDC_SWIZZLE_ABGR; >>> +               break; >>> +       case DRM_FORMAT_BGRX4444: >>> +       case DRM_FORMAT_BGRA4444: >>> +       case DRM_FORMAT_BGRX5551: >>> +       case DRM_FORMAT_BGRA5551: >>> +       case DRM_FORMAT_BGRX8888: >>> +       case DRM_FORMAT_BGRA8888: >>> +       case DRM_FORMAT_BGRA1010102: >>> +               vs_format->swizzle = VSDC_SWIZZLE_BGRA; >>> +               break; >>> +       default: >>> +               /* N/A for YUV formats */ >>> +               vs_format->swizzle = VSDC_SWIZZLE_ARGB; >>> +       } >>> + >>> +       /* N/A for non-YUV formats */ >>> +       vs_format->uv_swizzle = false; >>> +} These values could also go into vs_plane_state. Best regard Thomas -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)