From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5179033F8AD for ; Thu, 18 Dec 2025 15:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766073140; cv=none; b=qh+QTLBq+wzIQ/6IgdU5SeT5vki1o651gwg2AMPsqQ2sGh4b2krxepXXXCRiS9xc4UsBrtx9l4LHhu6C+dX864NrnhdjgM4RydmzzpNZjP4qfX90xBYhFw2iZfEsRYzx3imoK6tHGCQakAhK/w7mxsYzWCkyfK1k+h2Vj4HtTcA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766073140; c=relaxed/simple; bh=Xh1E3qsm/qasJNMVvvqXFxuDKwQq6V1HA7yNPOSOlCU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OttqcGuBLEI10gXwA7G/GoGPVEbB3C3eRRG/7yfex15TxO30vSt+Oe69Qq0x5Mc89oB/jjTy2s98HvhrlRbpgoM7LcHN9fMtz/vBF/umi3yBFDdeL0EMHmDa93gaa4NyeutABlCQ778lg+zKxA1+L54Ynd0NVrepg+5weaO2lnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=J0z0AW9h; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="J0z0AW9h" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-88a346c284fso8976296d6.3 for ; Thu, 18 Dec 2025 07:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1766073137; x=1766677937; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cW1M7fqhwlN10fdEj0fPal9hwmmZjLYjufee+fkgnhM=; b=J0z0AW9hKzi615k9wVeEjklkDNiUsuVhMB73ArCAzXQFZEy98P6rsaOIlgu5bUa/Ve wA/h7ENiu+pb4HXbQN8Vgu1fZ9UXar6Cb72lIMmQpTgHbXJx4YB6iRe1VSa446LR+A6o o8HXVGmPS0yei3Bb94GpwY4aCgLGcou1BPnDHJL/SINWaJ3+6HrVfgsuRhkfdjcM6UcU HK3JiURUtsNRY46F/xMvb4LRh83y64W9qi1kaOXq8W6fE0dHah5C5SK2d/RGOL+bndRD fHzgKBCN31aT82S8FdM+AlZGIfG7ORh+yzGNk6b+iLowBGGOnUSKfFOjNmdgToJ/v/wV G5HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766073137; x=1766677937; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cW1M7fqhwlN10fdEj0fPal9hwmmZjLYjufee+fkgnhM=; b=TxyS+K649WVVDx9LdgMDnuMcj3vC+Qf6KKGMztBTKdukDNSs0QF2+3mCtkHs3TpnyQ u3P2UsjJdL/W9Xj3TVTjBrsVQ0W169q6KZBHbTqCWYI/E8N5JfOLBdxN8PTmFkWcK+dm cew5ua/aN+/OChavn6rFkDG9np21BdxD9uCQU8WRXnwFA+bVHMfZzqD9itizTjeAD6Jo Jgtv+S5l+qoBFkFDZxX4bdSwFAWLWp7uFCRhNEjHR8wzMqcUdp3tOtOyw1y2WFyFfH/I 9/6nfjC+fF/dl/cNshU8yhIP9eb9Lkvvlba0grHBZGZ11CDOca/UevIg2/Mm8hu1uxaY vRfw== X-Forwarded-Encrypted: i=1; AJvYcCVkd+VNrip5AbpcE3qY6tv88DLyX90i7CyjvDASVyoD7JLJ61eeRhcdFJ4IrX3geNMAnwSnp7yNyWnRwtY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx3weXXOJRs+zgO9l+Fa6rxLBpOHNiPIeDUEmrM9bVdjRMuXJ0 j9bCDqm9e/61P3e5S5ee0/qQbjiGpDLXlVD56ZXF2vDQRU+J2mCw+N4Dx/hEcDHdEQ== X-Gm-Gg: AY/fxX6Q5jimRaiyIGSksBaokwmsuCLSVoRJ9CKPubzhVB8ObDQi9U5Kdgyv2mBuUK3 ji4lGPVT96ArneRHGITs+YW71ddccBj4YIMx/IzuNjBTwBnL6UwkrQZ0CNntcREo7YOYI2pTSz3 JiS3wo5BQuud72yWvB6n47weweSnZZbnsaVwgYjdEBY550XaQya3V5tYK0irkhZkzP6qb5QqAds G7wd1+YmCrnrJFeOS9FXHduRidlkBom51wi5HlFYTSLgt2uGM/WrFABTu9BYMVSzvXeM6A8WtFV U/3oUad37kJlThR4QO+X14JFMJfLAntWCeGzg8MAPTxBanKjKB/Tnm3nyot4RgoSPjVRtCrsqyV O7df5viQH9p7nuI442tLZ742MuNP6KU7M3gTDmqiL3gL0na5TpPNHgi8NCECEL556XXrK31yTFa trsXnuaXA9wsAIPzjmq0UmjflnrtGmRA== X-Google-Smtp-Source: AGHT+IEVS0EMW5+YUzuROLbK1pP+erdv1sbXdrakeuxuQx1ssbC7QlrMadTMdJ49F/XbA4Ay1I+Whg== X-Received: by 2002:a05:6214:4015:b0:880:5a06:3a64 with SMTP id 6a1803df08f44-88d855df020mr637876d6.66.1766073137178; Thu, 18 Dec 2025 07:52:17 -0800 (PST) Received: from rowland.harvard.edu ([140.247.181.15]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88c616751b1sm20448046d6.54.2025.12.18.07.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 07:52:15 -0800 (PST) Date: Thu, 18 Dec 2025 10:52:12 -0500 From: Alan Stern To: Johan Hovold Cc: Greg Kroah-Hartman , Vladimir Zapolskiy , Piotr Wojtaszczyk , Ma Ke , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 3/5] usb: ohci-nxp: fix device leak on probe failure Message-ID: <6c056004-666f-467f-bbbe-a67aec4d5dac@rowland.harvard.edu> References: <20251218153519.19453-1-johan@kernel.org> <20251218153519.19453-4-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251218153519.19453-4-johan@kernel.org> On Thu, Dec 18, 2025 at 04:35:17PM +0100, Johan Hovold wrote: > Make sure to drop the reference taken when looking up the PHY I2C device > during probe on probe failure (e.g. probe deferral) and on driver > unbind. > > Fixes: 73108aa90cbf ("USB: ohci-nxp: Use isp1301 driver") > Cc: stable@vger.kernel.org # 3.5 > Reported-by: Ma Ke > Link: https://lore.kernel.org/lkml/20251117013428.21840-1-make24@iscas.ac.cn/ > Signed-off-by: Johan Hovold > --- For this patch and the 5/5 patch: Acked-by: Alan Stern Alan Stern > drivers/usb/host/ohci-nxp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c > index 24d5a1dc5056..509ca7d8d513 100644 > --- a/drivers/usb/host/ohci-nxp.c > +++ b/drivers/usb/host/ohci-nxp.c > @@ -223,6 +223,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev) > fail_resource: > usb_put_hcd(hcd); > fail_disable: > + put_device(&isp1301_i2c_client->dev); > isp1301_i2c_client = NULL; > return ret; > } > @@ -234,6 +235,7 @@ static void ohci_hcd_nxp_remove(struct platform_device *pdev) > usb_remove_hcd(hcd); > ohci_nxp_stop_hc(); > usb_put_hcd(hcd); > + put_device(&isp1301_i2c_client->dev); > isp1301_i2c_client = NULL; > } > > -- > 2.51.2 >