From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012013.outbound.protection.outlook.com [52.101.43.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE3D535898 for ; Tue, 7 Jul 2026 05:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783400566; cv=fail; b=XG5ubrexlcVTizP/svkjUS7ruI7TdGM/oTn77OH+YMjqM6JWQlv2MfLPVguBPcP/0wbJxQAucHWhDRoHUiAkvXmx+opIuDHGjp1EeZZutDXD2BB1v8qItHo+N8JHRuPCQh1pkRaGJEf7RGdLOTAOdX/GXIEEnJUqtoaaNZkSmeo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783400566; c=relaxed/simple; bh=/BsQuCkSTJ19ieH0iQRr/i3WJhtdpmPRww+cL/DlDQQ=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=E5cf6Ffc/9NGd0STqJSNUCAwTsT8VmoDtvLDOgNslESQxj/wurQlMdyTBbuhMDnMSBGYBliSASTCYaGSBlmRpLYIiqLzqYmNJdGVounNeguaVnhYl45nAh5wDvur99CFGc/BTFsVcMVZcSZgRkjKXtzExXGXr6KSDL1cKV060UQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=srEO0XTU; arc=fail smtp.client-ip=52.101.43.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="srEO0XTU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y4kq3ddea+8fmsN+PSAtve0eS7RJzEnj2Ty/il64C/I/3US1WGKLOXOQ+D490QCzwkvGvQkRBqZ2F3HpoWe0CzcrfY4HtBJxhKtqMoZ+pGkm7vMM0cZa6B6m/9HqH8P4+jmLxxmwhDmWiErHc47/+IqxUSKmM6BLw5ZU2oqMzWzObZqHtWtfxr18ilQgbntkSCBrAs8d7F1A4OShifauD1fof1YpMA5G4x9NNYxrYWcROyunX0oojm5XTpVjGrC3TtkJhNdDtGampKx1Zcjp9W4LuVe1AGXypFRnx05Cl2PPWpUIR6uMGMNKNquZzu5t63dRPzy4BWZp0KGHfTzwVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h1e7j/7+j6Ci7cRzuSY9CEiEtikgy0ceO1knUn5yiww=; b=rzkAiYzLiL+ImLZdBnR1e78sNSiGLZaVdKeaYz2yGsZTsYVx1v24P42YvN9MOL9Slbqu9X0oKoFGNLNYlxs0YebLe/8624+pRWlaqoNZmnvyQDWIkdzE0wg9UFJY04AdyYvJOY/S42fcQtsDhCtXx9751QJ/mcF7h8owuxwxWI5cJcxXUibCoBPL7JYP7Lk4E5+LTUawp+yUFloU2fpGpAt6X61iBHkkGUZ5Xf9F5iO9xNjq/0VqPEXqU0yImT6jqHCB3WWgLHacMS+lgNCzQmsd71Jt9Ki2S0kcDKW59hD4Z3uzvSUDGoG1pOs6v0yqhLOAaMSlJ6DYQaDzxg7VPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h1e7j/7+j6Ci7cRzuSY9CEiEtikgy0ceO1knUn5yiww=; b=srEO0XTU4/jHMxxsBY4hCGBgiERf26F+jRjimQhIBmoDGhB2fZuy4LJuWKwhschg8SQk/xOp5JPqfztGzQzR0s9dAaHPmLZ3sT1ErVIiPvxZ4bMnWuYazCJfNCpKSCe+GaihvsCVzgUUMYbcuW1MsFE21GdVVknMXtyuNUS+2YPAKyntWwdK0Arttlxsf//lk7OGIIh0JPAG+Q+JPNL6q8ytGyFQQ/G2jGwOCKYmJaAJI7G4U+80puKGshy+HEQimGmTwNZWH4vZNxQElTHED6zP0Z+BdOlpcajYlG7ne0IwkIKczbovMir2TWicAFXQETIUgoLvg+jWcV4eI2/mqA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from LV8PR03MB7398.namprd03.prod.outlook.com (2603:10b6:408:18f::13) by IA1PR03MB8100.namprd03.prod.outlook.com (2603:10b6:208:594::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.12; Tue, 7 Jul 2026 05:02:42 +0000 Received: from LV8PR03MB7398.namprd03.prod.outlook.com ([fe80::9d6:b5c1:7f72:e982]) by LV8PR03MB7398.namprd03.prod.outlook.com ([fe80::9d6:b5c1:7f72:e982%4]) with mapi id 15.21.0181.008; Tue, 7 Jul 2026 05:02:41 +0000 Message-ID: <6c061c83-4e71-49ff-be70-9051d0f624b5@altera.com> Date: Tue, 7 Jul 2026 13:02:34 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc To: Dinh Nguyen , Greg Kroah-Hartman , Ang Tien Sung , linux-kernel@vger.kernel.org Cc: Tze Yee Ng , Adrian Ng Ho Yin , Nazim Amirul , Hang Suan Wang References: <20260706055541.74783-1-genevieve.chan@altera.com> Content-Language: en-US From: "Chan, Genevieve" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR04CA0214.apcprd04.prod.outlook.com (2603:1096:4:187::17) To LV8PR03MB7398.namprd03.prod.outlook.com (2603:10b6:408:18f::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR03MB7398:EE_|IA1PR03MB8100:EE_ X-MS-Office365-Filtering-Correlation-Id: d7168fb1-d48e-436e-960a-08dedbe4f93f X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|56012099006|22082099003|11063799006|4143699003|55112099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: Z+QCNcoYY5qPvyukKqRllQRRUkeA4Qp8d833MMAQGZEjReG4Iiql/TQNh8QyFKy6VshuB6hMDW/NLasykARAYLR29ds2ujN691nA/91G8BxEUq0yBXbEG9PYU557NEh7TGWtF2N0LYAJK9kwWKVzxDuC4p5Hnvir8+IbES5AQzAzdY6LCHrdJqPx6Ltr14VOMEii0oXCqFfGIFW1JEbMmh6bUeIYUWVFUbI+sT3dnbC9I6cayR08KTqL5G/hGjlgrfOY3kTy8kodLG9w/REqZQukf7e2dHqjqg+jyf6SqrOZbVcV9Snmi6Lb5ZibnZKhq2CchEOzP5UWQfU2CVASHK/8jqEhYyLOM1jRI1Wkd1cXmoDVBZEWGPGudr0Y3PVaSv+QRS2FIjkzYAHZpVGwtirV2j15QN8iyJVOcXbxRhHJBZI9CzFTZW2Z3LJJbwQNAOVbF21DFfNpL/Hg0S2beMM2ujNIw7x29hf4jxJX8RFf2q50j6I7BS2E/wI6VUCm5HrUXt/MKAajo6i2NEA9ZDfk2pgFdEoVl+22Z21UyhycqKn51gz1gojiVfDWJQZ8QLWJZI2WMeaCW5rq8KdDTfUAwujlVhPK6omouPxvMyLXANm0HtPd6f69fs89wJ1GaBJZEFQWlczb6/TVo9lqwKtLgXL0RCxM4JJfMnd5LQ4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR03MB7398.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(56012099006)(22082099003)(11063799006)(4143699003)(55112099003)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG5nMTk2bUdlV29zYllFZmxRZ2Y1eFQxRjliby93MHlkWnhUVTRsRmphR1dh?= =?utf-8?B?d0d0UCtQV2piOFFPNzMreHRXajlaVGJMelplT1NrSmhUdCs3L2lvdDRySlZG?= =?utf-8?B?RWNUNHhWYVRpZ0xzZTlsZUMrazQvRlR0OVhPMkdkQjlhWks5QWJMcVhMMTY3?= =?utf-8?B?UkRSUDZpc2FtTWVEMjZGbWNFOCtxNjJXb1FKOFdVeFNRbTBPREwySGo2S0J4?= =?utf-8?B?QkR0eDZ6dGM5Wmh1KzJxb1JqUExNb01ac1MzVGYrYjZtekV1LzhENG5jQjRq?= =?utf-8?B?QlM1bnN5RDN6ZUtwTmM3K1ZSQXFqQW9EcWpmNWoybE5RbmlCdG9qVkhDSWhl?= =?utf-8?B?QlhXV1dFRkdYN1BDRUR3b090M21GM1RYZFVRZ0kwWGx3QXVqOGVpcUwwdzZG?= =?utf-8?B?bUdhVnQyZXQydm56ajhyTjVzNG5kR09FVEFnRG80MG54L1JHMWFhS3djcnNM?= =?utf-8?B?V3ZBOUMyTnhsclc1OC9TKzcyNUZ4aUU0bTdDcTFLeFUwbWxVSUZXbFZJZzA1?= =?utf-8?B?aG5Gek1sdXROWHZJUDNpYkd3WjBBbk9PTzJUalFDdFRIM0JscHdqR0x6YzZh?= =?utf-8?B?dkJQZHFjTGRoM1o2ZXhHRGt6RDNacTRHTnhONlJodURuVFdNb0FoQ1ZodEdh?= =?utf-8?B?TlRXQTdhZW5FNFVGeVdlMFNwZ1N2VTgvS1hDMy9XcVRCUmtMT1F6T2JtWmpj?= =?utf-8?B?S0ljay9WKzVUMUlsSlRxQlZ2UG4yeVBzdGJYYk8vWTJlNHRlNlhCOW9pL25B?= =?utf-8?B?L0pEelM2aGo3SWM2VGZibGkzZ05mRGJWaUxHOEJzTU9pMDhvbVVxUXVYTXdN?= =?utf-8?B?U3p4USt3dDhQZ01ZZFFoTS9CL1VJZG1FdDdqdHQvb3JEZjdPNEVCQ21qelJG?= =?utf-8?B?UzYvYUlMRFFpMDZRdkoxcHBnQ3ZJV0dqNlRSU25iTjZXa1l0T3RSanZvbzhE?= =?utf-8?B?a3MyQlJoQXdIY1A4eFZWYnZwRWpIRTJvZG80Z2sxZ0NHWnRyYklhU3FHRXVZ?= =?utf-8?B?ajFTZ0lFYnFybi94dm9wUzlpbUFwREZ5MDBURllhWGpHVktHMHc0d1J4TW0z?= =?utf-8?B?WmRkVllaN0RuMWhCSC9xTVYyZzJ4ZlEwd0g2MWhmaWZkSVBGdmtLZlFWekND?= =?utf-8?B?Q2xJOFpReE5jbUxFKzEzTTkycW1RSCtZZE5qd1NDMlVUMFcwckx5dS9mN09J?= =?utf-8?B?UEUybmFZQ2Z0UExSYS9oTFRUaFFoWWtRTDIrY1o1bGgzVmd0YmUySDNxVjhv?= =?utf-8?B?SFlVQUZVQlpUelg1ZmtjVFpLaFBTeFErQ092WWpDVGs2N0o4T0gyN2ZwN0pi?= =?utf-8?B?U0xMdWtLVEc2T01rVkpPK1p2dHF4RzJKSGJweE1EUWQrMlRzTll1cXFhSFpa?= =?utf-8?B?M012UFdTMndTSkllRldoQkdZSjVqaWlNZi9LbGV3U0Nqd1FKM2s0ZTkyYVky?= =?utf-8?B?c043bWJUSS8zR3NXc1dTekZDU3RRbTAyczRRZFROSm0xdXJKWTJzN04rQnM0?= =?utf-8?B?QWhtQVJycUJCMGp0a1RyNFZVMVpyZHBlY2luWTBqUDgwS3lmSEUveFdOWGht?= =?utf-8?B?VnBNdG5SK3hlbk9YMi9zWlZ5anpOYUhidzZZcGg1QlJRZENrZ2pUU2cwUXJt?= =?utf-8?B?dW83YVVvZElJc2ZFeUhjQUpObGMvbXZmWEdXTDQxTzJGeDhIMUxUV3BFeFFO?= =?utf-8?B?ZnBURGRRZVlSQ2NFRXg2cjdXVHQ0WXV4VitaWHFvaER2N2RybUcxNm90bCts?= =?utf-8?B?bmRrWDR5TnhUSUFQZDhvZkZNbmo0UitQRlFjanArSm0xL250eVo1MzNIYWQ5?= =?utf-8?B?R0tuc2czQWZBQjdHUURQdFpOb1dDMEhHOVQwdlhhZVNCNHpWeFdrZStoMVdE?= =?utf-8?B?aGU0NGkzdG5BRkRhSmcvWDhCcUNMbzNBSUFxVHZiMVgwam5hUERkN0dlSHBO?= =?utf-8?B?UGhnbnFMVVJ0WTZSLzJUK0pTM2FDa1M4Smt6cFM2QUw2UG1Dc1lhMWUrYWpL?= =?utf-8?B?TVlLRHd0R3ZrZG83ZWdTYm5RamFBd2FVUTdRa2NJSVh1UkREaGR5MENuNE1L?= =?utf-8?B?TGZqWmRlcHdYYVRxRFFmWG5YQkhUZXFLTlVCY0pPKzBhRWJaZlB2ak1kZG1B?= =?utf-8?B?SHlJdjFzU2pGV3Z0cnJJZXg2MUpEWnlRY1hDWWJUNEdYVFAyZnVoWVk5VWh2?= =?utf-8?B?LzIrdWtZVndLVXJZTS9ZY1lvVlo3K2FKa1dSck95bENYbE8xZEpldW95UkR2?= =?utf-8?B?WHdjSHdoK1hXN0MrSXRJdVdvYjRtbHRGRUdFQmxDV1EweEJqN0lWTlhqeWR2?= =?utf-8?B?aWUxOUZ4QWNveTJ6VXJ6cmJvaHJ1d1RoMGFpdjZST2ZBZmswSWMyaGlLRVpn?= =?utf-8?Q?Vrlv3YWeYVCFfQ3A=3D?= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7168fb1-d48e-436e-960a-08dedbe4f93f X-MS-Exchange-CrossTenant-AuthSource: LV8PR03MB7398.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 05:02:41.8355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k1+Hir5CCW+hiJRTR2kRowXq1oR36Cl/jBFqybbz6RFaaWOUBBVNTAXMY7Od9xmmT8Giw3HOUfu3EVZDrI/NSSZpTjeRY9nO8wr7D0+Jdlg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR03MB8100 On 6/7/2026 9:56 pm, Dinh Nguyen wrote: > > > On 7/6/26 00:55, genevieve.chan@altera.com wrote: >> From: Genevieve Chan >> >> Correct kernel-doc errors for two FCS SMC calls: >> >> INTEL_SIP_SMC_FCS_SEND_CERTIFICATE: >> - Describe as async to match STD_CALL_VAL usage >> - Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED >> >> INTEL_SIP_SMC_FCS_GET_PROVISION_DATA: >> - Replace FCS-specific status macros with standard status macros >>    (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED) >> - Restore return register documentation for a1 (mailbox error), >>    a2 (physical address), and a3 (structure size) >> >> Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands") >> Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision data to async SMC call") > > I see how this patch fixes 4a4709d470e6 but I don't see how this patch fixes 4b0a32016347. Can you justify how it fixes the second commit? Hi Dinh, The fixes for 4b0a32016347 includes modifying the original macro definition description section for register a1-a3 as well as the return status description of the INTEL_SIP_SMC_FCS_GET_PROVISION_DATA cmd. Thanks, Genevieve Chan > > Thanks, > Dinh