From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF044C43463 for ; Sat, 19 Sep 2020 16:17:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB717208DB for ; Sat, 19 Sep 2020 16:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726594AbgISQPQ (ORCPT ); Sat, 19 Sep 2020 12:15:16 -0400 Received: from smtprelay0016.hostedemail.com ([216.40.44.16]:40612 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726463AbgISQPP (ORCPT ); Sat, 19 Sep 2020 12:15:15 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id B7670180A7FF9; Sat, 19 Sep 2020 16:15:10 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: trip10_4805ed327135 X-Filterd-Recvd-Size: 1523 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Sat, 19 Sep 2020 16:15:09 +0000 (UTC) Message-ID: <6c07f1238d48cef82668defcd9cba0e4ccdf4177.camel@perches.com> Subject: Re: [PATCH 1/3] staging: rtl8192u: clean up blank line style issues From: Joe Perches To: Michael Straube , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 19 Sep 2020 09:15:08 -0700 In-Reply-To: <20200919150823.16923-1-straube.linux@gmail.com> References: <20200919150823.16923-1-straube.linux@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-09-19 at 17:08 +0200, Michael Straube wrote: > Add missing and remove unnecessary blank lines to clear checkpatch > issues. unrelated trivia: > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c [] > @@ -26,6 +26,7 @@ Major Change History: > static u32 edca_setting_DL[HT_IOT_PEER_MAX] = { > 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f > }; > + > static u32 edca_setting_UL[HT_IOT_PEER_MAX] = { > 0x5e4322, 0x00a44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f > }; These could be static const Here and in drivers/staging/rtl8192e/rtl8192e/rtl_dm.c and drivers/staging/rtl8723bs/hal/odm_EdcaTurboCheck.c