From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E3F3126B9 for ; Thu, 19 Mar 2026 07:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773906098; cv=none; b=WU2vQsqFXsTRuGOcrvpSBCU/S7MTUbRSnGPLa4K976AWI3NT9+MOpzU4sKcrQ1YtEnm8pnn+YKwZbvN94J3RD9BNQuGptnldhFiXyA1vBew+CQM3Po9F1CTffCerEwoXT4VlxJ8NqvatQEiU+/o8euBeWu8O/8qySThFU2MwL4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773906098; c=relaxed/simple; bh=4XY4jhDNLOeV30flJno2DJ0Bwr/A5l+U4+9fRcDaERc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=feXHrvuon1T/3PmehwBwzTfhSU/FFK04zKWK099PjDDrFvL77iyDw4QbztGG2pW2GszVHbfElaQ+keiXDBikd5fOPXJ48sUJFIXYocbbozSB1vgaSWhISEe+/yzrBiX9WjarvErEtPUpON0Fi5oki+f7FHJ5U9/ukgiZQ/YJuwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bJhSKKrD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dzwGCzXC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bJhSKKrD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dzwGCzXC" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J7402d1027121 for ; Thu, 19 Mar 2026 07:41:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DOdtLeifiZXyGLwU/u9IRGKQWOfb3XrDub6omvdNpvU=; b=bJhSKKrDKeY8h6R4 poHFwovSXWwe2AfU2HGk/EgQSojQdNP/Rb8fPnNK8VhmrbpZtkZQ1wByyX1oLLpE aGAB3SarfIp2jVy4TmpDUwHyvt8Cpj4YD/Gx6SHOgXQASUjT+65hbOUdnu5KJFZh +FwnKXYMqYsFTrwM3EquIvgzZszLtUBMnY9Bk6LHrz2mlS1JFZ6rAJXYoVWb6d1E ycwGwRCOLtfOKvr1ULuKLf/v1c8S3BkMGvwaLxanNdj7q/5zqigCV0AnVW6pbU+X xnihnfv5MECrnrU8EsEDcVhpHpGblysxCh6WjZI4tnRw2devAzOQPK7dLHj28BlR fxICZg== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0032jd59-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 07:41:35 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2bead0a9123so19950215eec.1 for ; Thu, 19 Mar 2026 00:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773906095; x=1774510895; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DOdtLeifiZXyGLwU/u9IRGKQWOfb3XrDub6omvdNpvU=; b=dzwGCzXCrBN5oQEE3R77W16QPEb68oO5xgcpxKX4K7yHvqtaWhmjq4UQL2G6Juw4zr YV0usRiVLnB7MhBK45lyTHeWXiDq1vXZfj1Rnx9JGsl7RF5P+cPc2tfAHaMU0eTp5kVB /61ZmFdKEazCAXsFaYS9tWZBNj30Cu0CuxqCd2rVyiLlTPjp5sPFfWIC4oAfovfRxOvz Ahw3Uj0xV1mWgFfBgjKWbqKK+XLbs18Q5JeJpVLM6oCNm8n5rxsbjU5vB+F2mMqm6iRp x14B2HGpCwolz+ePngptLI2TYY3zIPwFYGmRmGQmsG7mGDnTkg92CtEIC1fQqvUKA/jk rOdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773906095; x=1774510895; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DOdtLeifiZXyGLwU/u9IRGKQWOfb3XrDub6omvdNpvU=; b=Y63J0M3XgOowC5As79KaGckSWcHw2xdW6KJubjunnqNhYiJ5crfo3ZGPpE7FiuoEe7 oIk7OjM04oyZM8Ni8n7xAAAMuWTKFXlLSKPpJAbUQjJLd89way7/K8D6USCgJseb79LS +8GvHjxmVIliNZsiWRYm2TpFERgjVOJOfUv1pYsC68mRsfasYM7PXOzWwBnvKblSDmGp n5v8WctD4eaQRSC+fgxwduJ7a4zLhLZ2+eRi5BnOWZZ+fpFc4Aj6FiWEoc36S4QayCol q9utskHaxQEvrEwbKKH9C9oL+6SA0Q42IXpCF4Ru0kFM9WRZ54rXCdIdxl//FmxERZof AYdg== X-Forwarded-Encrypted: i=1; AJvYcCUvAIpCdE3IRu8MhFY31GfI4scn3x1WrqWSMfF1uk/8JSzsO6AYu8ebcJX7xHjNLrSchw9DAQk5tsF8RIE=@vger.kernel.org X-Gm-Message-State: AOJu0YzT0yccMsmp6EKwBMdsDa4XIyV3fE1lHVI6aEu7mOyIUW+bFpO9 ZWXj4jeK7YgKxkYLxyimgNVOlmu2Y3sk2eeleEGB4pX/pApnU8ZXffbM/E9Lj+WWslVr5Vz29kb aDCt7SI6u+XOhUwTnQLEx7DC4zn5WzabBV1RlhNz+MbhXibJyt5YsdfkGz5IJqpF+M9s= X-Gm-Gg: ATEYQzyfvCVOMajgsx5ykKoOKAmIOjQDXxQxaI9kfdmQYCsw08Kt0G5pf7uW8Qvq6r+ 6QUGgfMgpokDbu7MtuTE9LoQrsQB1zU3gnZNbI74yyFpT9m+W7MNO2v2Od8f99qTRh+AegQQQu6 P88B3nft8lYsE57Jwvy4FBMgftBVwTjJbmZqt+hx9k36A+JKFJw9vWXyVDy408p5r2PRIb4d6qq x2iHK+MdFEofae6UoeUly4GL3cnEhCDfZtJJkS+MFzqztna+sEiVhQRTrZmDOAGfo3J8NGaoidw wos2fmmfbG4URa6JYuGgQ4HXoj7wVMVPcFejdPREVj7Ckdo3VKNteSWwONf5V0ZPi3ebBQP/fPx yZeH7hb1W5DzEzblX+izHGPm93gi7Ryd5ObPPADrw+Mr+DmdhJxKw0Ne4AmF/TVPdbSl16wl+2d M= X-Received: by 2002:a05:7301:168b:b0:2be:1544:5c40 with SMTP id 5a478bee46e88-2c0e508312amr3097561eec.31.1773906094955; Thu, 19 Mar 2026 00:41:34 -0700 (PDT) X-Received: by 2002:a05:7301:168b:b0:2be:1544:5c40 with SMTP id 5a478bee46e88-2c0e508312amr3097552eec.31.1773906094396; Thu, 19 Mar 2026 00:41:34 -0700 (PDT) Received: from [10.110.94.9] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55a0d4asm7167389eec.20.2026.03.19.00.41.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 00:41:33 -0700 (PDT) Message-ID: <6c0fef1c-9c81-4586-81b2-54702a5b0bd7@oss.qualcomm.com> Date: Thu, 19 Mar 2026 15:41:29 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Bluetooth: hci_qca: disable power control for WCN7850 when bt_en is not defined To: Dmitry Baryshkov Cc: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, cheng.jiang@oss.qualcomm.com, quic_chezhou@quicinc.com, wei.deng@oss.qualcomm.com, jinwang.li@oss.qualcomm.com, mengshi.wu@oss.qualcomm.com References: <20260319031040.4096297-1-shuai.zhang@oss.qualcomm.com> <1603a5b0-8edd-4c31-b2d1-344ee7df10ac@oss.qualcomm.com> <4d6d2597-df3f-4421-8760-ea59a46a3b39@oss.qualcomm.com> Content-Language: en-US From: Shuai Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: CWF-F9vNFFFGJcwLLZL9ewiSAF-pdjP_ X-Proofpoint-GUID: CWF-F9vNFFFGJcwLLZL9ewiSAF-pdjP_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA1OSBTYWx0ZWRfXzFa4BYE66aSX fHuie5tTqw/Vu+6mNyznAwrr3nRZLTVhpAsI7OKx8ktyDQI4cMo5RekAqYAjGhPM5YyCIbaLLS0 slmtqaK2mWDeEo1lowXwOveIwjrRrddMekvoGHfHT61vF1xAulXxhAo5PABRWsnWrCkqVjLsg2r xB5hS5oOL2DW2YoXrzatqMHmIwICkTuuekm5/ssFHu3vmRfQ7Ihm4R6IrpweP/vrAwTHOIanoaK cNQvqPppO6wgRnTxSZWRUkq2sNWvRtPzRSd3Bvl0yFaQGKgZ8Ily6ZKBRywCg2bB86lU/OR7ni9 N0KfAmJm5fRRPKhUSZL/TtARLLOTaJOX00mjjgHftQakROYPP1kZc7LDuECjzHIAGGmi/pABwrx mk1QmxMRy4u0Q8fk3maK75xwd0D8S7UgzFsYYUV2nApyfo7fIf2JHpx9WCxvdUMuBgzoP/WVDod 85Ec88njFEuqQlM7MOA== X-Authority-Analysis: v=2.4 cv=WO9yn3sR c=1 sm=1 tr=0 ts=69bba8b0 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=AjXXxhxKq0fdEwWQdOQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190059 On 3/19/2026 2:44 PM, Dmitry Baryshkov wrote: > On Thu, Mar 19, 2026 at 02:06:49PM +0800, Shuai Zhang wrote: >> On 3/19/2026 1:42 PM, Dmitry Baryshkov wrote: >>> On Thu, Mar 19, 2026 at 01:21:58PM +0800, Shuai Zhang wrote: >>>> Hi  Dmitry >>>> >>>> On 3/19/2026 11:51 AM, Dmitry Baryshkov wrote: >>>>> On Thu, Mar 19, 2026 at 11:10:40AM +0800, Shuai Zhang wrote: >>>>>> For platforms where the bt_en GPIO is not defined, software-based power >>>>>> control should be disabled when power is managed by hardware. >>>>> What does it mean for this chip, managing the power in hardware? >>>> bt_en is pulled high by hardware, >>> In which cases is it applicable? >> >> On platforms using an M.2 slot with both UART and USB support, bt_en is >> pulled high >> >> by hardware. The current platforms are Lemans‑EVK and Monaco‑EVK. > This needs to be a part of the commit message. I will update. > >> >>>> or described in the device tree as a >>>> regular always-on GPIO. >>> Why? >> >> This is equivalent to bt_en being pulled high by hardware, >> >> and it applies to the same scenarios and platforms mentioned above. > No, DT would not describe the GPIO as always-on in this case. Yes, understood. In this case, bt_en is pulled high by hardware and is not described as an always-on GPIO in the device tree. > >> >>>>>> Add QCA_WCN7850 to the existing condition so that power_ctrl_enabled is >>>>>> cleared when bt_en is absent, aligning its behavior with WCN6750 and >>>>>> WCN6855. >>>>>> >>>>>> Signed-off-by: Shuai Zhang >>>>>> --- >>>>>> drivers/bluetooth/hci_qca.c | 3 ++- >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c >>>>>> index c17a462aef55..4512ff7cd0c0 100644 >>>>>> --- a/drivers/bluetooth/hci_qca.c >>>>>> +++ b/drivers/bluetooth/hci_qca.c >>>>>> @@ -2484,7 +2484,8 @@ static int qca_serdev_probe(struct serdev_device *serdev) >>>>>> if (!qcadev->bt_en && >>>>>> (data->soc_type == QCA_WCN6750 || >>>>>> - data->soc_type == QCA_WCN6855)) >>>>>> + data->soc_type == QCA_WCN6855 || >>>>>> + data->soc_type == QCA_WCN7850)) >>>>>> power_ctrl_enabled = false; >>>>>> qcadev->sw_ctrl = devm_gpiod_get_optional(&serdev->dev, "swctrl", >>>>>> -- >>>>>> 2.34.1 >>>>>>