From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792752192; b=X7fur/d8kUnqTVdhhw+siUvCUMGq5Ajfu1WgOrhkm+y57N0zDt37yb2EPeQONfdQIs6p ZUnpPq5dFwQMg0ZMpse8AbZJaRCp/HMvGVc9rGHv9i1NkxVOTAUp8nZnmZSKxHQww9ih5 y9PjT6PiN/QpUzVloNt1d0Iuq1jGytpToYvIQpMK+vDRSSLHssKk+Fe90NPEFO+6vkovq wUhV2iW4GX9exWOl/rh/vYa1KMEMXNG/0oWwybsdpqbBl8yia2VCawFvjX91mvHF1nf/v lqC2RWYOtxIFpaIUNY5B+SzVa8a8Z1715tp9wWvA/AtyJ2Xvtwp/XgUmH00okx8rUPA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792752192; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=5KEIK/6JjGIvmGz3msnqhTqFTFw0tv2iGW6sK39lX3E=; b=Fj9XIarKN0CgV3myjU7qFrgpi3dnzSO4SJDExwKF1b+7cXJ7G4tOEPx2GCDrDrkRcuXW NLGsIHyI3Mj7HV/GaxXxLggi2GWcDxO84BpQZw7ka5VKMO/ifPWBBNSHnWowXF22u49ht ++y09Pc6m4IOBmXDOefunIWceD9tgrKmk56gVuY1uq4HQyd4msdnBfPmEg1eQPnWUbQc0 rOna4Wyqdpm5t4El0FrZ1wp1UkVrZ6JrzpFWXpTNC75ktLQChoPIrEbY0SeaQ/uvNYspK 7TI9oQBGTb6nowzhX1q28DdxU+59phqRV5PfZ3hMCXb8olSAH1jGTz22v9ezJlY3daw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=V7YBSMr5; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=kjWwvwTr; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96AD0606A31B for ; Fri, 23 Oct 2026 10:43:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 96AD0606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=V7YBSMr5; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=kjWwvwTr Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69NAATon3560859 for ; Fri, 23 Oct 2026 10:43:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5KEIK/6JjGIvmGz3msnqhTqFTFw0tv2iGW6sK39lX3E=; b=V7YBSMr5RwHO2ffw 5kNW5LiFWviUrW81/B/9Hs8MCoSZlwH9debSqBAfN0rNAM+7TuVDfSXtBxhsKn5e a6fnhrL6k590+7ZqBeYoje8UfnhaUYQJ+R17cWDFTva5qrHlzdAucHJ/QbDLs5px WCuTaw7sLOgQKAECbMDmmMEo5+ixiuxmvcBvKpyag9lwaKckM635kapymmFYAco8 lO9bPP8HcjOwdheCwv+8fEmgxze2fAhoJhEO18fhkMI5aktkA2IB/Y5GQgTWhTlN mmaaoU05zq2cPJ70eM1Va3GGbALkNxy/3tgYxeZZws7vTK4NPO91mXx0auHBKxya 6dAblg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hfqmpb8sp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 23 Oct 2026 10:43:10 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93f26dd2165so256715785a.3 for ; Fri, 23 Oct 2026 03:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792752190; x=1793356990; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5KEIK/6JjGIvmGz3msnqhTqFTFw0tv2iGW6sK39lX3E=; b=kjWwvwTr57o/Uk5WEHOLYPejQZ+O23CZkaVXfQ/FsDUIrJwfkleGThOH0hzr4QdUxX x97JTSmyh3t0NPWVGKZYHjRcWentPzL0uZPE9Gh+c7c8j1Uj/WzVKfiYXxt0Sd7bXYtf N1vrnOxhzUphjgjANgPjQ2FpSejgZPODZGxJkut2OPrjSHtk4yRz35Qh02pmvGzeMVZ6 wLsTeFNC6K3S3k8WYnPXqXQj8ekhmg7rqvIccrnyTwT6LFRElJQ3qRJZ7vw2TzlQ2PqT sPv2drdE1vMCPKFibtfDuSHpv5N3Cq0W1hIYlJk+z95vqwiCG+GeSxLz5YmlcQ5SmDxI Eeqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792752190; x=1793356990; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5KEIK/6JjGIvmGz3msnqhTqFTFw0tv2iGW6sK39lX3E=; b=Jq8fWupGxw1SGVQt+oTcV/kEfXmQW36XJaG8PkuQsTlckVDqPExXqabdfhXtdhV9Id 51VV5St93PPHszDFDYRanIZcugezOQvtqxixw0nvwgCKym9SYOvOEPTd8OsgzDfEpJ5E y17ADqmT/9lw4NV+d8ORWhFOUKHFsppf4iV/twBbL1xMoZKoPpAOt0Qp7Xwadb1i4UDA 3CI2Mx4t1YY2YPAD5UqBUeIqJA6pa+EAUlBPg0NtxPq0LlMZQlvq8/Vc2Lh3/NvPUS4H Dux/x9p9/+v+lDxisJmCxChRuw/u9CsjG+K+6PV59VP4cvt78uutn00lXFf/U5a9UuqO 7aYw== X-Forwarded-Encrypted: i=1; AKwUvBz3xhUG9cOd3ZmR2S2eRDmCGg+4ida4vUxjvVDugKv3tT40fU1pSe/+7eN8Is3HX4Vfkj5Y0Ob2CgwF3Wk=@vger.kernel.org X-Gm-Message-State: AFq9FYLX3bR7+on19hFPXn7/YBRYv3D+mxhqvC5tTmJ6tVvnYYzCcloO Vq3agiwNwuDz7G8+we+jY7ntt3iVZgCaO+rKGJsKs8WsmaDYnW9jlnkinUFQVZ4+Cm0BB01feaV z57Xc9hcHJTUWsfD1fF021UuaXjn1bbdF6PsGLLcrYrVrwSQrExRCQU48X4SSIbmCQd4= X-Gm-Gg: AYBFou04RkBphix1tNNAs/8mLXRO6yItCD5rKEh8efVYdntgXg8lFufgrTj3+fVCIIJ JD9To4N7Clzn1qkXKQGR03SzRwxb90qmf/56tcv4A5+ooLp4jKR0HRDuukRUW1jf+8RI9J5t69e s4ZdSRag4yW0nRMVK1hYbfqW7oBV9oe+c/sjPXrej5sMuyXOWmQT+aNoPwKh6k/C6yR/dLhrKPM 8zew6ZC2HoWgmFCOswSvrNhK1ptqtUIMfgZ5iBhC5TWHXHw8a9VxCelhBWjggJ8+vD5CZ1vlPAE sIipFcG2Ji+sKTLmk6qZ/Kxi40tYdAxcr+Ba0s8pbk658Pj+9SnzQ2Y8SOiw9ILT6YmlhL789xd N4ih3Ju9po115qmst1taVbNFVZ5MV3rzzFjR1AyFLDDA3VZq8oNdFZTmkcz+WxQ== X-Received: by 2002:a05:620a:4449:b0:93f:34c9:924d with SMTP id af79cd13be357-93f6f9549d2mr262707185a.35.1792752189814; Fri, 23 Oct 2026 03:43:09 -0700 (PDT) X-Received: by 2002:a05:620a:4449:b0:93f:34c9:924d with SMTP id af79cd13be357-93f6f9549d2mr262705085a.35.1792752189333; Fri, 23 Oct 2026 03:43:09 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:7d20:e20f:a77f:4ef7? ([2a05:6e02:1041:c10:7d20:e20f:a77f:4ef7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a21034d740sm72635615e9.4.2026.10.23.03.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Oct 2026 03:43:08 -0700 (PDT) Message-ID: <6c186b10-1247-4f82-86e8-3c42cbb925c9@oss.qualcomm.com> Date: Fri, 23 Oct 2026 12:43:07 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] arm64: dts: qcom: x1e78100-thinkpad-t14s: Add thermal zones for PMICs To: Stephan Gerhold Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, johannes.goede@oss.qualcomm.com, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Pearson References: <20261023083827.7648-1-daniel.lezcano@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIzMDA0MSBTYWx0ZWRfXyalPPJllPOfQ TDRpN2b3USAqsfMOCN6DNg9uSbZqPRMTE6F1ne+896bb+P5atEximB6PMkYwki8mtdshqVQOpL8 cnld8huCCpKqk+Y2W/j2W1n+Jhkr22U= X-Proofpoint-GUID: JaSefJvba_heoXAhL4zkbIs6SiWth-Xi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIzMDA0MSBTYWx0ZWRfX7EwtQlVk/XPU JNRtAs8fHVRRqm2JJfuZwDbH6kA6P2/T002GL2Bk3exkI+XdeMC5+96CYjzMSIpysIdi7WUn3mS Sqmb6Fpq6wkGICSiNxYxUmgq7ynR9WA3FWkSDSjN7AcVXgh3PvdkfP4cRkn4hboJJ7RHHjXlG1W WPcVT338JSuf1qT6sp7A7RB61svGa8LErDVFyfmxocNbcqhquLowD51G2dhZg5LydR0cBo1aPWm 1rT9fBjTMDL+Ca7sA/azA6+KpaP7PoWrp2BUfHgg1l9B/qq994/jw36yAx/jxDzQK09csXkNhQ/ 5s8cyihLtrWUDQ7mulX+E6W1JegPCADZbRgvNzstBNyah2ZXoRODCxXT6Xm+JAxbnIcFUUwSHXu y1UwJsVAKehmau5yt9vVSSXGADbqmjvGxDxGTbTMfIn2UhjXsoPp7I7IYbULG8Of+u5RdTsMd3N hU14fy4xIby/WMlfK7Q== X-Proofpoint-ORIG-GUID: JaSefJvba_heoXAhL4zkbIs6SiWth-Xi X-Authority-Analysis: v=2.4 cv=BdBNQbt2 c=1 sm=1 tr=0 ts=6adb3a3e cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=6LTyHckwlz_E6bxlvKMA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=FO4_E8m0qiDe52t0p3_H:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-23_03,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610230041 On 10/23/26 11:17, Stephan Gerhold wrote: > On Fri, Oct 23, 2026 at 10:38:27AM +0200, Daniel Lezcano wrote: >> The ThinkPad T14s needs thermal mitigation under sustained workloads to >> limit temperature rise before thermal shutdown. EC interrupt-driven thermal >> monitoring is not yet supported, so use the board temperature sensors >> exposed through the PMK8550 VADC to provide mitigation now. >> >> Describe the sensors near DRAM, the fan/heatpipe, the GPU and CPU PMICs, >> the charger, the WWAN area and the USB-C ports. The DRAM-area sensor faces >> the keyboard, while the fan/heatpipe-area sensor faces the back cover. >> These are internal board measurements rather than direct measurements of >> the user-contact surfaces. >> >> Use the heatpipe-area sensor for passive mitigation at 57.85 degrees >> Celsius, derived from observed platform behaviour with the Windows >> balanced power profile. Map the passive trip to all CPUs and the GPU, >> with 1 degree Celsius hysteresis and a 500 ms passive polling interval. >> Name the trip "backcover-ec-alert" so that the planned EC support can >> locate and adjust it. >> >> An earlier approach using staged CPU-cluster throttling did not show a >> significant improvement and introduced a latency imbalance between CPU >> clusters. Keep a single passive trip to provide timely mitigation. >> >> Add 73 degree Celsius critical shutdown trips for the DRAM-area and >> heatpipe-area sensors. Retain these baseline thresholds pending >> sensor-specific hardware validation. The reported Windows DRAM threshold >> of 115 degrees Celsius has not been established to apply to these VADC >> measurements and does not justify changing the shutdown thresholds. >> >> Thermal camera measurements indicate that the readings primarily reflect >> internal temperatures rather than chassis surface temperatures. No unsafe >> external surface temperature was observed during those tests, but they do >> not establish qualified critical limits for the internal sensors. >> >> Expose the remaining sensors as monitoring-only zones and enable ADC >> threshold monitoring on the corresponding PMK8550 VADC channels. >> >> Reviewed-by: Hans de Goede >> Link: https://patch.msgid.link/20261014193524.5590-1-daniel.lezcano@oss.qualcomm.com >> Signed-off-by: Daniel Lezcano >> --- >> .../qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 112 ++++++++++++++++++ >> 1 file changed, 112 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >> index 75ad74bcb042..21f4569068e1 100644 >> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >> @@ -502,6 +502,88 @@ platform { >> }; >> }; >> }; >> + >> + thermal-zones { >> + /* Sensor near DRAM, facing the keyboard. */ >> + dram-thermal { >> + critical-action = "shutdown"; >> + thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_THM_100K_PU(1)>; >> + >> + trips { >> + dram-critical { >> + temperature = <73000>; >> + hysteresis = <1000>; >> + type = "critical"; >> + }; >> + }; >> + }; >> + >> + /* Sensor near the GPU PMICs. */ >> + gpu-pmic-thermal { >> + thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX4_THM_100K_PU(1)>; >> + }; >> + >> + /* Sensor near the fan/heatpipe, facing the back cover. */ >> + heatpipe-thermal { >> + critical-action = "shutdown"; >> + polling-delay-passive = <500>; >> + >> + thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX2_GPIO_100K_PU(1)>; >> + >> + trips { >> + backcover_ec_alert: backcover-ec-alert { >> + temperature = <57850>; >> + hysteresis = <1000>; >> + type = "passive"; >> + }; >> + >> + heatpipe-critical { >> + temperature = <73000>; >> + hysteresis = <1000>; >> + type = "critical"; >> + }; >> + }; >> + >> + cooling-maps { >> + map0 { >> + trip = <&backcover_ec_alert>; >> + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu8 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu9 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu10 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&cpu11 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >> + <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; >> + }; >> + }; >> + }; >> + >> + /* Sensor in the WWAN area. */ >> + wwan-thermal { >> + thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX3_THM_100K_PU(1)>; >> + }; >> + >> + /* Sensor in the charger area. */ >> + charger-thermal { >> + thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX2_THM_100K_PU(1)>; >> + }; >> + >> + /* Sensor near the CPU PMICs. */ >> + cpu-pmic-thermal { > > I'm a bit confused by the node order here. It's not ordered by the > thermal sensor (SYS_THERMx) like in x1e80100-crd.dts, but it's not > ordered alphabetically either. Or is it still the old order from the > previous revision? > > I think I'd personally prefer ordering by SYS_THERMx, but alphabetical > order would be our typical rule. Oh, yes I changed the name but forgot to reorder alphabetically :( > > Anyway, for the changes itself: > > Reviewed-by: Stephan Gerhold > > Thanks for fixing the names! > Stephan