From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20393C388F7 for ; Sun, 25 Oct 2020 18:19:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D04A421707 for ; Sun, 25 Oct 2020 18:19:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1418005AbgJYSTS (ORCPT ); Sun, 25 Oct 2020 14:19:18 -0400 Received: from smtprelay0141.hostedemail.com ([216.40.44.141]:38384 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1417979AbgJYSTS (ORCPT ); Sun, 25 Oct 2020 14:19:18 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 1EE5C837F24D; Sun, 25 Oct 2020 18:19:17 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: aunt05_1d1847e2726c X-Filterd-Recvd-Size: 1516 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Sun, 25 Oct 2020 18:19:16 +0000 (UTC) Message-ID: <6c1c62cd8ac119a6d8a84f262f11eb509ba0e7cc.camel@perches.com> Subject: Re: [PATCH v5] checkpatch: extend attributes check to handle more patterns From: Joe Perches To: Dwaipayan Ray Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel , Lukas Bulwahn Date: Sun, 25 Oct 2020 11:19:14 -0700 In-Reply-To: References: <20201025101537.59133-1-dwaipayanray1@gmail.com> <52f88d0bb938c5063ede693a05bf64961af5a496.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-10-25 at 23:40 +0530, Dwaipayan Ray wrote: > On Sun, Oct 25, 2020 at 11:29 PM Joe Perches wrote: [] > > Using $rawline would also change comments and that seems wrong. > > Any reason to use $rawline instead of $line? > Yes I used $line initially but changed it because quoted > strings were being replaced. > > Like: > __attribute__((__section__("_ftrace_events"))) Right thanks, that's a very sensible tradeoff to reduce code complexity.