From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 798F42E3701 for ; Tue, 22 Jul 2025 03:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753154686; cv=none; b=ujDUyKlETh0+NQHSp13TzBN1VDAIspE1J3tP8jVlEYCPJTLl0h+IG2j8X6X8NBFVZdAq+VJ/sD1hqMDPUcpvyFqiV+KS58TfSi33EZI5n5K/UdA891WQb/M8Vo+F0xVQ9AepFMM4YCZgR3bE0WG0rNgiqVnjAelGM0g1JlC3gJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753154686; c=relaxed/simple; bh=5Rzof64fbH46b5Fd+gNbyuLMkJ3pMKbLw+hfXRsX4cA=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=iBk70hJr0RydsMwssabEkvV227hnPM6ajx4CEnpVhM+zh3qlIvjFVPTdPjVuZxz/+JYBPdTyDP98yEZJ4Cjnl0vUkE1RGNqHdCbTL/GG4/rcOq4d/XPC/fyiB8ENCEJdFZBZeKdI2X17Oq2XGcTE/1ZBz0IgFaw00BcsF8ZQERQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P0GnCNbj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P0GnCNbj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0FCEC4CEEB; Tue, 22 Jul 2025 03:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753154685; bh=5Rzof64fbH46b5Fd+gNbyuLMkJ3pMKbLw+hfXRsX4cA=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=P0GnCNbjOg9KTNNwMCEcpDJHy3RTpbjeJJiWKW5XZ4Q1/2lkC7btnAzESoG35AoUw meLA0fvlvlkpMnqoBLn4R3QHkLk/nxf9s8+3j0SwGOdW0BGccLX62ela1psk2G8SpG SQPnGZkTdImqiayEX6dmwTbSXnqftBHjwKC3ijaBll3BJPqQP6a9d8NWBl7QiNyrPx GQAjQvMc/IWwsLxQUFFCLgienXW/dsx6tJj9PZG5wFfrNYl4wlNOX+bQG5wnzjiaIj Iuq/toP211c+fqtgwVVusg2oh/h/BLqphyNx1Nl6O6uNLcWl29xlnOSrqWy9RWFT0c zPiB6q9RpBqjA== Message-ID: <6c26bcaa-7a9d-4b30-b326-90395f55e155@kernel.org> Date: Tue, 22 Jul 2025 11:24:41 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Daeho Jeong Subject: Re: [f2fs-dev] [PATCH v2] f2fs: add gc_boost_gc_greedy sysfs node To: Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com References: <20250718215003.2283009-1-daeho43@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20250718215003.2283009-1-daeho43@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/19/25 05:50, Daeho Jeong wrote: > From: Daeho Jeong > > Add this to control GC algorithm for boost GC. > > Signed-off-by: Daeho Jeong > --- > v2: use GC_GREEDY instead of 1 > --- > Documentation/ABI/testing/sysfs-fs-f2fs | 8 +++++++- > fs/f2fs/gc.c | 3 ++- > fs/f2fs/gc.h | 1 + > fs/f2fs/sysfs.c | 16 ++++++++++++++++ > 4 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > index 931c1f63aa2e..2158055cd9d1 100644 > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > @@ -866,6 +866,12 @@ What: /sys/fs/f2fs//gc_boost_gc_multiple > Date: June 2025 > Contact: "Daeho Jeong" > Description: Set a multiplier for the background GC migration window when F2FS GC is > - boosted. > + boosted. the range should be from 1 to the segment count in a section. > Default: 5 > > +What: /sys/fs/f2fs//gc_boost_gc_greedy > +Date: June 2025 > +Contact: "Daeho Jeong" > +Description: Control GC algorithm for boost GC. 0: cost benefit, 1: greedy > + Default: 1 > + > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index de7e59bc0906..0d7703e7f9e0 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -141,7 +141,7 @@ static int gc_thread_func(void *data) > FOREGROUND : BACKGROUND); > > sync_mode = (F2FS_OPTION(sbi).bggc_mode == BGGC_MODE_SYNC) || > - gc_control.one_time; > + (gc_control.one_time && gc_th->boost_gc_greedy); > > /* foreground GC was been triggered via f2fs_balance_fs() */ > if (foreground) > @@ -198,6 +198,7 @@ int f2fs_start_gc_thread(struct f2fs_sb_info *sbi) > gc_th->urgent_sleep_time = DEF_GC_THREAD_URGENT_SLEEP_TIME; > gc_th->valid_thresh_ratio = DEF_GC_THREAD_VALID_THRESH_RATIO; > gc_th->boost_gc_multiple = BOOST_GC_MULTIPLE; > + gc_th->boost_gc_greedy = GC_GREEDY; > > if (f2fs_sb_has_blkzoned(sbi)) { > gc_th->min_sleep_time = DEF_GC_THREAD_MIN_SLEEP_TIME_ZONED; > diff --git a/fs/f2fs/gc.h b/fs/f2fs/gc.h > index efa1968810a0..1a2e7a84b59f 100644 > --- a/fs/f2fs/gc.h > +++ b/fs/f2fs/gc.h > @@ -69,6 +69,7 @@ struct f2fs_gc_kthread { > unsigned int boost_zoned_gc_percent; > unsigned int valid_thresh_ratio; > unsigned int boost_gc_multiple; > + unsigned int boost_gc_greedy; > }; > > struct gc_inode_list { > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index b0270b1c939c..3a52f51ee3c6 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -824,6 +824,20 @@ static ssize_t __sbi_store(struct f2fs_attr *a, > return count; > } > > + if (!strcmp(a->attr.name, "gc_boost_gc_multiple")) { > + if (t < 1 || t > SEGS_PER_SEC(sbi)) > + return -EINVAL; > + sbi->gc_thread->boost_gc_multiple = (unsigned int)t; > + return count; > + } This check should be in ("f2fs: add gc_boost_gc_multiple sysfs node"), right? Thanks, > + > + if (!strcmp(a->attr.name, "gc_boost_gc_greedy")) { > + if (t > GC_GREEDY) > + return -EINVAL; > + sbi->gc_thread->boost_gc_greedy = (unsigned int)t; > + return count; > + } > + > *ui = (unsigned int)t; > > return count; > @@ -1051,6 +1065,7 @@ GC_THREAD_RW_ATTR(gc_no_zoned_gc_percent, no_zoned_gc_percent); > GC_THREAD_RW_ATTR(gc_boost_zoned_gc_percent, boost_zoned_gc_percent); > GC_THREAD_RW_ATTR(gc_valid_thresh_ratio, valid_thresh_ratio); > GC_THREAD_RW_ATTR(gc_boost_gc_multiple, boost_gc_multiple); > +GC_THREAD_RW_ATTR(gc_boost_gc_greedy, boost_gc_greedy); > > /* SM_INFO ATTR */ > SM_INFO_RW_ATTR(reclaim_segments, rec_prefree_segments); > @@ -1222,6 +1237,7 @@ static struct attribute *f2fs_attrs[] = { > ATTR_LIST(gc_boost_zoned_gc_percent), > ATTR_LIST(gc_valid_thresh_ratio), > ATTR_LIST(gc_boost_gc_multiple), > + ATTR_LIST(gc_boost_gc_greedy), > ATTR_LIST(gc_idle), > ATTR_LIST(gc_urgent), > ATTR_LIST(reclaim_segments),