From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABB6C2D0A3 for ; Tue, 3 Nov 2020 19:32:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3843216C4 for ; Tue, 3 Nov 2020 19:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729248AbgKCTcP (ORCPT ); Tue, 3 Nov 2020 14:32:15 -0500 Received: from smtprelay0188.hostedemail.com ([216.40.44.188]:52518 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725957AbgKCTcO (ORCPT ); Tue, 3 Nov 2020 14:32:14 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 7092218225AE2; Tue, 3 Nov 2020 19:32:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: iron68_570fe6d272bb X-Filterd-Recvd-Size: 3437 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Tue, 3 Nov 2020 19:32:12 +0000 (UTC) Message-ID: <6c275d95c3033422addfc256a30e6ae3dd37941d.camel@perches.com> Subject: Re: [PATCH v2] checkpatch: improve email parsing From: Joe Perches To: Lukas Bulwahn Cc: Dwaipayan Ray , linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel , Aditya Srivastava Date: Tue, 03 Nov 2020 11:32:10 -0800 In-Reply-To: References: <20201103054810.21978-1-dwaipayanray1@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-11-03 at 09:10 +0100, Lukas Bulwahn wrote: > Maybe you can coordinate among each other who would want to create > suitable fix rules here? Yes please. > Also, start with the class of the most frequent mistakes for > unexpected content after email addresses. > > I imagine that a maintainer can simply run a tag sanitizing script > which just cleans up those stupid mistakes before creating their git > trees or sending git pulls to Linus. Does anyone really do that? It generally requires rebasing or post processing each commit after being committed before another commit occurs. > Let us try to add these > sanitizing rules to checkpatch.pl with fix options for now; if that > sanitizing feature becomes a monster script of its own within > checkpatch.pl, we can refactor that into an independent script for > cleaning up. I rather doubt an independent script is going to be worthwhile as these rules shouldn't be all that complex. The only prefixes acceptable for a stable address should be CC:|Cc:|cc:. There are 2 uses in the last 100k commits for Signed-off-by: and Acked-by: with stable addresses, those should have a message/warning emitted in the future. The forms used with those cc: stable addresses: 2777 stable without comment 1381 stable # comment 74 stable [ comment ] So I suggest standardizing on no comment and # comment with any other style getting a warning. For non-stable -by: and cc: addresses and other signatures: Likely any content after a email address other than a parenthesized block should have some checkpatch message emitted. This should be OK: Signed-off-by: Full Name (comment) (maintainer:...) But perhaps this should not be OK: Signed-off-by: Full Name (comment) # comment There are 316 uses of this # comment style in the last 100k commits and 103 with (comment) after the address. Maybe the # use should be ok, maybe not. And anyone that uses a multiple comments in a name or a even a single comment in the email address should also get warned. The below should not be OK even if actually valid address forms: Signed-off-by: Full (comment1) Name (comment2) Signed-off-by: Full Name