mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 2/2] arm64: dts: qcom: ipq9574: Complete USB DWC3 wrapper interrupts
Date: Fri, 9 Jan 2026 09:41:00 +0530	[thread overview]
Message-ID: <6c299100-122a-436d-8b90-28c9a7d48677@oss.qualcomm.com> (raw)
In-Reply-To: <32f4a425-e181-41ab-913f-55e3dd3b4fd5@oss.qualcomm.com>


On 1/8/2026 11:13 AM, Kathiravan Thirumoorthy wrote:
>
> On 1/7/2026 12:21 AM, Krzysztof Kozlowski wrote:
>> Complete interrupts for DWC3 node to match what is required by
>> Devicetree bindings, as reported by dtbs_check:
>>
>>    ipq9574-rdp433.dtb: usb@8af8800 (qcom,ipq9574-dwc3): 
>> interrupt-names: ['pwr_event'] is too short
>>
>> The actual interrupt numbers are taken from reference manual of similar
>> chip, but not IPQ9574, due to lack of access to it.
>>
>> Signed-off-by: Krzysztof Kozlowski 
>> <krzysztof.kozlowski@oss.qualcomm.com>
>>
>> ---
>>
>> Not tested on hardware.
>>
>> "lack of access" = no IPQ9574 at all.
>
> Initially the SoC was named as IPQ9048 and after sometime it is 
> renamed as IPQ9574. But unfortunately, the reference manual is not 
> updated with the new naming.
>
> I can confirm the below interrupts are correct. So,
>
> Reviewed-by: Kathiravan Thirumoorthy 
> <kathiravan.thirumoorthy@oss.qualcomm.com>
>
> Thanks, Kathiravan T.

Also, confirmed that USB is working well, without any issues.

Tested-by: Kathiravan Thirumoorthy 
<kathiravan.thirumoorthy@oss.qualcomm.com>

>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq9574.dtsi | 10 ++++++++--
>>   1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi 
>> b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> index 86c9cb9fffc9..d7278f2137ac 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> @@ -765,8 +765,14 @@ usb3: usb@8af8800 {
>>               assigned-clock-rates = <200000000>,
>>                              <24000000>;
>>   -            interrupts-extended = <&intc GIC_SPI 134 
>> IRQ_TYPE_LEVEL_HIGH>;
>> -            interrupt-names = "pwr_event";
>> +            interrupts-extended = <&intc GIC_SPI 134 
>> IRQ_TYPE_LEVEL_HIGH>,
>> +                          <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>,
>> +                          <&intc GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>,
>> +                          <&intc GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
>> +            interrupt-names = "pwr_event",
>> +                      "qusb2_phy",
>> +                      "dm_hs_phy_irq",
>> +                      "dp_hs_phy_irq";
>>                 resets = <&gcc GCC_USB_BCR>;
>>               status = "disabled";

  reply	other threads:[~2026-01-09  4:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 18:51 [RFT PATCH 1/2] arm64: dts: qcom: ipq5018: Correct " Krzysztof Kozlowski
2026-01-06 18:51 ` [RFT PATCH 2/2] arm64: dts: qcom: ipq9574: Complete " Krzysztof Kozlowski
2026-01-08  5:43   ` Kathiravan Thirumoorthy
2026-01-09  4:11     ` Kathiravan Thirumoorthy [this message]
2026-01-08  9:42 ` [RFT PATCH 1/2] arm64: dts: qcom: ipq5018: Correct " George Moussalem
2026-01-10 19:11 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c299100-122a-436d-8b90-28c9a7d48677@oss.qualcomm.com \
    --to=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®