From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/6] staging: rtl8192e: Remove enum RF_1T2R and RF_Type
Date: Sun, 2 Apr 2023 11:51:47 +0200 [thread overview]
Message-ID: <6c29e709f5c328703870ca8e7d61ee6338886fa7.1680427945.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1680427945.git.philipp.g.hortmann@gmail.com>
enum RF_1T2R is used to initialize a local variable RF_Type that is then
shifted. The result of the shift is zero. Remove code that has always
the same result to increase readability.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
V1->V2: Removed declaration of local variable
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 5 ++---
drivers/staging/rtl8192e/rtllib.h | 4 ----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index 258ea66ab2fd..a21b3798db48 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -518,7 +518,7 @@ static void _rtl92e_dm_tx_power_tracking_callback_tssi(struct net_device *dev)
struct dcmd_txcmd tx_cmd;
u8 powerlevelOFDM24G;
int i = 0, j = 0, k = 0;
- u8 RF_Type, tmp_report[5] = {0, 0, 0, 0, 0};
+ u8 tmp_report[5] = {0, 0, 0, 0, 0};
u32 Value;
u8 Pwr_Flag;
u16 Avg_TSSI_Meas, tssi_13dBm, Avg_TSSI_Meas_from_driver = 0;
@@ -529,8 +529,7 @@ static void _rtl92e_dm_tx_power_tracking_callback_tssi(struct net_device *dev)
priv->rtllib->bdynamic_txpower_enable = false;
powerlevelOFDM24G = priv->pwr_track >> 24;
- RF_Type = RF_1T2R;
- Value = (RF_Type<<8) | powerlevelOFDM24G;
+ Value = powerlevelOFDM24G;
for (j = 0; j <= 30; j++) {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 197c0a44ebd6..7d83a4c322cf 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -433,10 +433,6 @@ enum led_ctl_mode {
LED_CTL_START_TO_LINK = 8,
};
-enum rt_rf_type_def {
- RF_1T2R = 0,
-};
-
enum wireless_mode {
WIRELESS_MODE_UNKNOWN = 0x00,
WIRELESS_MODE_A = 0x01,
--
2.40.0
next prev parent reply other threads:[~2023-04-02 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 9:51 [PATCH v2 0/6] staging: rtl8192e: Remove enum RF_1T2R and useless cases for customer_id Philipp Hortmann
2023-04-02 9:51 ` [PATCH v2 1/6] staging: rtl8192e: Remove RF_Type from .._dm_tx_update_tssi_weak_signal Philipp Hortmann
2023-04-02 9:51 ` Philipp Hortmann [this message]
2023-04-02 9:51 ` [PATCH v2 3/6] staging: rtl8192e: Remove local variable Value and powerlevelOFDM24G Philipp Hortmann
2023-04-02 9:51 ` [PATCH v2 4/6] staging: rtl8192e: Remove case customer_id = RT_CID_DLINK Philipp Hortmann
2023-04-02 9:52 ` [PATCH v2 5/6] staging: rtl8192e: Remove case customer_id = RT_CID_819x_CAMEO, Philipp Hortmann
2023-04-02 9:52 ` [PATCH v2 6/6] staging: rtl8192e: Remove case customer_id = RT_CID_DEFAULT, Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c29e709f5c328703870ca8e7d61ee6338886fa7.1680427945.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®