From: Johannes Thumshirn <jthumshirn@suse.de>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Christoph Hellwig <hch@lst.de>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvmet: disable direct I/O when unavailable
Date: Fri, 22 Feb 2019 06:55:00 +0100 [thread overview]
Message-ID: <6c3fa30a-d516-a453-a001-1014202ff9ce@suse.de> (raw)
In-Reply-To: <SN6PR04MB4527A810D247541AA7C4A512867F0@SN6PR04MB4527.namprd04.prod.outlook.com>
On 22/02/2019 01:41, Chaitanya Kulkarni wrote:
[...]
>
> As per specified in the patch, this is only useful for testing, then we
> should modify the test scripts so that on creation of the ctrl we switch
> to the buffered I/O before running fio.
Or on any other file-system that does not support DIO..
>
> OR
>
> Similar result can be achieved by setting buffered I/O flag
> buffered_io=1 before enabling the name-space in the test script.
Frankly, we have a ton of testing related special cases in the kernel.
This one is a) simple and small, only 10 LoC, b) far away from the fast
path or any other place where it could have any impact on legitimate
users and c) it prints an informal message showing you what happened.
Sorry but this is a https://xkcd.com/386/ moment.
Byte,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-02-22 5:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 18:22 Johannes Thumshirn
2019-02-22 0:41 ` Chaitanya Kulkarni
2019-02-22 5:55 ` Johannes Thumshirn [this message]
2019-02-24 10:54 ` Max Gurtovoy
2019-02-25 9:37 ` Johannes Thumshirn
2019-02-25 14:49 ` Bart Van Assche
2019-02-25 15:38 ` Johannes Thumshirn
2019-02-25 16:10 ` Bart Van Assche
2019-02-25 21:18 ` Sagi Grimberg
2019-03-08 13:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c3fa30a-d516-a453-a001-1014202ff9ce@suse.de \
--to=jthumshirn@suse.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®