From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A79C433FE for ; Wed, 30 Nov 2022 00:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232016AbiK3Arj (ORCPT ); Tue, 29 Nov 2022 19:47:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbiK3Arg (ORCPT ); Tue, 29 Nov 2022 19:47:36 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3A1E0CCA; Tue, 29 Nov 2022 16:47:33 -0800 (PST) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 30 Nov 2022 09:47:32 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 9D8162058B4F; Wed, 30 Nov 2022 09:47:32 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Wed, 30 Nov 2022 09:47:32 +0900 Received: from [10.212.156.209] (unknown [10.212.156.209]) by kinkan2.css.socionext.com (Postfix) with ESMTP id D118AA8559; Wed, 30 Nov 2022 09:47:31 +0900 (JST) Message-ID: <6c423f87-1187-b2d6-8b70-c8cd709f3ea0@socionext.com> Date: Wed, 30 Nov 2022 09:47:31 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/2] spi: Add Socionext F_OSPI SPI flash controller driver To: Geert Uytterhoeven Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221124003351.7792-1-hayashi.kunihiko@socionext.com> <20221124003351.7792-3-hayashi.kunihiko@socionext.com> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 2022/11/30 1:49, Geert Uytterhoeven wrote: > Hi Hayashi-san, > > On Thu, Nov 24, 2022 at 1:36 AM Kunihiko Hayashi > wrote: >> Introduce Socionext F_OSPI controller driver. This controller is used to >> communicate with slave devices such as SPI Flash memories. It supports >> 4 slave devices and up to 8-bit wide bus, but supports master mode only. >> >> This driver uses spi-mem framework for SPI flash memory access, and >> can only operate indirect access mode and single data rate mode. >> >> Signed-off-by: Kunihiko Hayashi > > Thanks for your patch, which is now commit 1b74dd64c8612619 > ("spi: Add Socionext F_OSPI SPI flash controller driver") in > spi/for-next. Thank you for your work. >> --- a/drivers/spi/Kconfig >> +++ b/drivers/spi/Kconfig >> @@ -906,6 +906,15 @@ config SPI_SLAVE_MT27XX >> say Y or M here.If you are not sure, say N. >> SPI slave drivers for Mediatek MT27XX series ARM SoCs. >> >> +config SPI_SN_F_OSPI >> + tristate "Socionext F_OSPI SPI flash controller" >> + depends on OF && HAS_IOMEM >> + depends on SPI_MEM > > On which systems is this hardware block found? > Perhaps this should depend on ARCH_UNIPHIER || COMPILE_TEST? This IP doesn't depend on ARCH_UNIPHIER, so I expect that it can be widely applied not only to ARCH_UNIPHIER. If COMPILE_TEST is required, the dependency is like SPI_CADENCE_XSPI: depends on (OF || COMPILE_TEST) && HAS_IOMEM Thank you, --- Best Regards Kunihiko Hayashi