From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD2DB3EB0F3 for ; Wed, 26 Aug 2026 10:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787741519; cv=none; b=hSu448x+dSgVmscSXfQ3ECSeezVzI+waTEPjh7tVp4bQ1Kg0Ddzc3Cj2Thrs29FXTZh8ledmQD7y4Tz6w8FZn8gQLx2hXZYjmcxCJ1q81Jub8OF6gBcMXRPKd7OKpV+ClIrPA3rklxGRVwD0hIiAqfTLK8tJ73VUtaOHRdmFIaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787741519; c=relaxed/simple; bh=kwTNrGRg5ARL/HG/paaqB4/ggQic9TbvOvkpIos1B+A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P8KWz1I4LVd3CnHjyH4/iB9vzG2V9mfQ+GzWbJ8zJnpHo5d4ApzkH7HPiGZBR643fa14E8vAwDLi0leDqvEoYrh/FDuPAluM+bBgme9fRq1L6rmeOkKK/OI44ag6/Um2vR+LRGRsxzLzZZ4E61TXxp63hfaq9Qy9eziWF7rsISg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jOHTTUmN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XdlrvMOc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jOHTTUmN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XdlrvMOc" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67QAGbSd121391 for ; Wed, 26 Aug 2026 10:51:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KPvoAKERNDW97gH/3Yh3ivbUuQB15b1Uk4xuEhWUvBA=; b=jOHTTUmNHaD8lR9e 2RfEbvuL1df+9JZgCfFUnEb+1eO2YDoiTq4rXlZnSIj7U65ZHROwyHybuag344ju opHmr9xUwhi2i/YmTRnFP7nXuMcPN3lC2zfif9j2qFimZaBgn7VSbl2cNbxKPVeZ 7hwvur0ua5lQXmmNfKhyyakYpMqhj7r2TK1A9aNe4pnBOUUpBRcOYeVgjNUKrghn oRV5cMMa6SpSPVS83U6w1kbPFLOk0nnsdbL9wWFuq2/gQHmmQiBDVJzWNL9AVu9Y +dRnB5BMWwshRlY2IXMvjrzXiOwVCSu29oshz/xtYJY2WmdTcSQZmlxWaJZMe2rj UIiS9Q== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9smx9dm1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 10:51:42 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2d6fb956002so12177595ad.1 for ; Wed, 26 Aug 2026 03:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787741502; x=1788346302; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KPvoAKERNDW97gH/3Yh3ivbUuQB15b1Uk4xuEhWUvBA=; b=XdlrvMOcTwvcHnFdUQV4XGgj5WrrJqTXiuyfGsXgi37Tgu/eFCwEjcgHqVvsjo/cXO ObcVlquJ2m7p9SdD6xZEaTtdyidW+qBI7v4obh5IS/KcuoGB4qZmVJPNFQVpm/801+DY snerHelwckdscCE0FiRZMwqRiogjp2po5Ip/faOsrN2HGmER+d0bo2CXT7KEKmf9XUdk oLn5IV7GzlceRSOUXMAIKGmfJWQoQ0RXfH5/BQPs0C/KwhhQi9KQgDKKr8+wMOsdHDYV kCReRHzP/XHKCjt5PnSnR2bmB3OHwaJ7v6kWakxi2HuztcoWQ6kpJe/nEIQtOzJrBrOJ fbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787741502; x=1788346302; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KPvoAKERNDW97gH/3Yh3ivbUuQB15b1Uk4xuEhWUvBA=; b=Ct6s3xCB0qdwyVzm0T+JNMvso8cZVX7jfjuAqiHFIJRzQXQ+bDqIrCIJu23IguxLIK 5qT+bnUUe17aAoDQ458PvEBxcv8linZqm/T7+Xf8z2FAj/h4noguDdkbxG/8648bgkqs hnv5KFRbIW7pX5z/7wi+6YTPBwzZgoRU7MRABUVbHp6WP+eFa/kwwH+bzKgBlSQlKZP/ RiEUA/66JIp5hER/P4aiXxbYy5XLVEH7q7TreMJR5pBUjb2rOhSoduZ8Sjhn46uL5uYB UQ7FPsE2GnxxgSvfBvjWlbNRY1u/6JMtwcctlxtr3ZCB3JDv9qoAgR5/7UX0aoff0Om+ vqiQ== X-Forwarded-Encrypted: i=1; AHgh+Rp1WBE5GjTDJPZtVo4eUJEkFehzn+YvCaQhIHD12/oQxIasMZY6q9GJ90s8v1RS0kC1SjJfv2F4zBYI/UA=@vger.kernel.org X-Gm-Message-State: AFuF++n0q8MqArj2/nYTfvLPSzNxsVEkXPWbZUz+rgRkorGxN7DhQL64 jU8dmfaPd/qtvgh8JcL6ydvjYv1B+WiU29tBmfKzcnWAuGy/iPnM8eLJodXBMp0TqYVOjnL2aRF lRhzdOox4J3dDqpd6J5tYlrF2U2z2cOjytM94mMcjOW31gb3z/0JAHL5fGrqvVCaoGTo= X-Gm-Gg: AR+sD10g+gfaSNe2zZUkwQvu4ZZxf92saBGVg7CHpUYpHRGxYgc+JooqDEsLGC3NRZz dCN73d81/CSWB+LWuIwbD2oJ9kxn1C0Hq6M9By9FnZPQDtQsYZkHjNQ7e35vgDce6tsNSHGu89B f3Yz5lvrpPu63WSLe5WosAzYphWHsOSiqHwaEMOL8FH9uxPydWsV7m4nPqZ+BqLcBzvXQMUAzdQ q6hkVzwNjfO02jHu3alOZwUp2aY3vTPoe2niHfgGP9C4v+fR65nDb/sSIchE1Lnvsi66D0JPv1E ywKvyS+DvWVLXgzivPnzjR4KQe8uS9z+zHdH3s6hn9+T7/b6KVUiZemP8ewglVIOhabZq1XBdWr G5fQUP9/qm/22ej85mwWxjtyz4ka8EhF6zQ== X-Received: by 2002:a17:903:1b08:b0:2d0:cc92:f7af with SMTP id d9443c01a7336-2d707b7f5bemr106786385ad.9.1787741502149; Wed, 26 Aug 2026 03:51:42 -0700 (PDT) X-Received: by 2002:a17:903:1b08:b0:2d0:cc92:f7af with SMTP id d9443c01a7336-2d707b7f5bemr106785255ad.9.1787741501609; Wed, 26 Aug 2026 03:51:41 -0700 (PDT) Received: from [10.217.218.252] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3283d60c2b4sm12054504eec.5.2026.08.26.03.51.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 03:51:41 -0700 (PDT) Message-ID: <6c4c2350-5af8-444d-8ca9-838ab4220d35@oss.qualcomm.com> Date: Wed, 26 Aug 2026 16:21:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/2] i2c: core: Add i2c_update_timeout() helper for dynamic transfer timeouts To: Mukesh Savaliya , Wolfram Sang , Andi Shyti , Dmitry Guzman Cc: Viken Dadhaniya , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260813-master-v7-0-3f9010cf9229@oss.qualcomm.com> <20260813-master-v7-1-3f9010cf9229@oss.qualcomm.com> <29719c5f-757d-426e-94ca-c221f45c00cf@oss.qualcomm.com> <92e89073-69d1-41ff-8545-d872b6b0c147@oss.qualcomm.com> Content-Language: en-US From: Aniket RANDIVE In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=O/oJeh9W c=1 sm=1 tr=0 ts=6a8ec53e cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=rSDCmGRdB9MByfBwi4kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: R6f3Za9u3d5Qv2wxBmXuyutPWjs74n7m X-Proofpoint-ORIG-GUID: R6f3Za9u3d5Qv2wxBmXuyutPWjs74n7m X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDA5MCBTYWx0ZWRfXzNSAr9f2JnpL CeEfOTh78a9OzkgV9QOCmHtKTDY/dCJir8+/qPUMGtp7xjhkDROMyXmUhCKHgSeZ00fDNXuqVOk 38TlN9XoOS7ZUqFNhuMaJKh6O5VNJzgcxPOeZjS+U43kQ5Mc4mH9+banhxS+FqYr01XouEP1UaL /le41E7z3DoVKTZP7wtNx20C3ygjr0vO1xZ2P5kzccMhMtG1PFHyHugYku1wFQMw1cf5lILfzsr Kxk/48TMxBrZSKw4Y+aV79t8OiHVGMGToCTJwjMvVLAwL9N/bcnRC63/oDnQuUzqIkWVS8mvxEx WT5nrDQWGvuka2/WHQgnYRn2dNGx1umXeCI64Fy4YcaF/C4hiNRKf442K9yhSQfhPV9qO/wMWCs Szc9a6TDodnrbmCGJxEOgHfwD4JwdrGhwSyUSy9CyHB7WMAPmiuAisB/J+sxs8MyeeIDfABeGyG QXUCznCPN43RLLFORJQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDA5MCBTYWx0ZWRfX1ACw4AahdE/B Tb90mk8pWyVMuxb4Th8CKbGpPIJrJSUdjvyP2l5cc+HFcSVSZYnWcXnGbIdfn1c6PQHC+Z1ztt8 h97eFwahjdBCKbcqqOagnQ4B+oQLaZE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_03,2026-08-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260090 On 8/24/2026 7:14 PM, Mukesh Savaliya wrote: > > > On 8/24/2026 3:36 PM, Aniket RANDIVE wrote: >> >> >> On 8/24/2026 11:49 AM, Mukesh Savaliya wrote: >>> >>> >>> On 8/13/2026 11:15 AM, Aniket Randive wrote: >>> [...] >>> >>>> +void i2c_update_timeout(struct i2c_adapter *adap, u32 bus_freq_hz, >>>> +            size_t len, unsigned int safety_coeff, >>>> +            unsigned int min_usec) >>>> +{ >>>> +    u64 bit_usec = mul_u64_u32_div(len * 9, USEC_PER_SEC, >>>> bus_freq_hz); >>> let's validate bus_freq_hz to prevent from 0 value in case of any >>> abnormal caller. >> >> This scenario is highly unlikely. Most drivers operate with a default >> bus frequency, typically 400 kHz, and therefore the condition being >> checked is not expected to occur in practice. As a result, I do not >> believe this validation is necessary in this case. >> > > Unlikely but also possible, it's framework change. So can't guarantee > about all other soc drivers. Sure. I will provide a warning and return early if frequency is 0. > >> Thanks, >> Aniket > > Please remove this sign from in between. > >> >>> >>>> +    u64 total_usec = bit_usec * safety_coeff + min_usec; >>>> +    unsigned long jiffies_val; >>>> + >>>> +    /* Userspace-configured timeout always takes precedence. */ >>>> +    if (adap->user_timeout > 0) { >>>> +        adap->timeout = adap->user_timeout; >>>> +        return; >>>> +    } >>>> + >>>> +    jiffies_val = usecs_to_jiffies((unsigned int)min_t(u64, >>>> total_usec, UINT_MAX)); >>>> +    /* adap->timeout is int; guard against signed overflow. */ >>>> +    adap->timeout = (int)min_t(unsigned long, jiffies_val, INT_MAX); >>>> +} >>>> +EXPORT_SYMBOL_GPL(i2c_update_timeout); >>>> +#endif /* CONFIG_I2C_DYNAMIC_TIMEOUT */ >>>> + >>> >>> [...] >>> >> >