From: Krzysztof Kozlowski <krzk@kernel.org>
To: Le Qi <le.qi@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com
Subject: Re: [PATCH v1] arm64: dts: qcom: hamoa-evk: Add DP0/DP1 audio DAI links
Date: Mon, 9 Feb 2026 10:16:36 +0100 [thread overview]
Message-ID: <6c55c690-6b1e-4f92-9f9e-e6f1a6ce61d3@kernel.org> (raw)
In-Reply-To: <20260209091139.622756-1-le.qi@oss.qualcomm.com>
On 09/02/2026 10:11, Le Qi wrote:
> Add DAI links for DP0 and DP1 playback and set sound-name-prefix
> for both DisplayPort endpoints in the hamoa-evk DTS.
Why? We see this from the diff. Why do we want this change?
Please finally learn this feedback that you should not describe the
"WHAT" in your commit.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-09 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 9:11 Le Qi
2026-02-09 9:16 ` Krzysztof Kozlowski [this message]
2026-02-09 9:18 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c55c690-6b1e-4f92-9f9e-e6f1a6ce61d3@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=le.qi@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®