From: Iuliana Prodan <iuliana.prodan@nxp.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Corentin Labbe" <clabbe.montjoie@gmail.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Aymen Sghaier" <aymen.sghaier@nxp.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Chen Zhou" <chenzhou10@huawei.com>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 2/4] crypto: caam - Simplify with dev_err_probe()
Date: Thu, 3 Sep 2020 15:04:26 +0300 [thread overview]
Message-ID: <6c56dcc0-e8f7-744f-5a0e-3834c4b14c8a@nxp.com> (raw)
In-Reply-To: <20200902150530.14640-2-krzk@kernel.org>
On 9/2/2020 6:05 PM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> ---
> drivers/crypto/caam/caamalg_qi2.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c
> index 0441e4ff2df2..076c6b04bea9 100644
> --- a/drivers/crypto/caam/caamalg_qi2.c
> +++ b/drivers/crypto/caam/caamalg_qi2.c
> @@ -5115,8 +5115,7 @@ static int dpaa2_caam_probe(struct fsl_mc_device *dpseci_dev)
> /* DPIO */
> err = dpaa2_dpseci_dpio_setup(priv);
> if (err) {
> - if (err != -EPROBE_DEFER)
> - dev_err(dev, "dpaa2_dpseci_dpio_setup() failed\n");
> + dev_err_probe(dev, err, "dpaa2_dpseci_dpio_setup() failed\n");
> goto err_dpio_setup;
> }
>
>
next prev parent reply other threads:[~2020-09-03 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:05 [PATCH 1/4] crypto: caam - Fix kerneldoc Krzysztof Kozlowski
2020-09-02 15:05 ` [PATCH 2/4] crypto: caam - Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-03 12:04 ` Iuliana Prodan [this message]
2020-09-02 15:05 ` [PATCH 3/4] crypto: stm32-hash " Krzysztof Kozlowski
2020-09-02 15:05 ` [PATCH 4/4] crypto: allwinner/sun8i " Krzysztof Kozlowski
2020-09-03 12:08 ` [PATCH 1/4] crypto: caam - Fix kerneldoc Iuliana Prodan
2020-09-03 12:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c56dcc0-e8f7-744f-5a0e-3834c4b14c8a@nxp.com \
--to=iuliana.prodan@nxp.com \
--cc=alexandre.torgue@st.com \
--cc=aymen.sghaier@nxp.com \
--cc=chenzhou10@huawei.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome