From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E96F288C2C for ; Fri, 31 Jul 2026 01:05:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785459903; cv=none; b=kLvh6OQTBvYT0HfFz+42KZ6dk6FjTNSvEgeSsbyRlCz2owgq877dEccGlFvq5cOiQ2h/wjJPeNY0Eyg8zdnbJcI6Tw9FSKlvGtEz+CN4HUCpsMpKox88/2h3yhsRhOa147iOumrpPhRn7EoajJRutlfTumfSd3g06Lh6MqvW6y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785459903; c=relaxed/simple; bh=Ub/ljo2qBnXw+rZPga8aeDvObXqkLbLSa952ZHCWtBg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HPdoKzWI1s+tSR8iS39kIYnUvyn1s++oSb8a8r/iTSWCxc8zZcjL07FPUZGEdRmmcyBrM8qJGpjU3/ZvEhRU96h9FjAgPgSC8sQlneVDsCWFdkvC3oXSGKTtseePI3DBySiPkipUiDm07y5+ErsLIdMjGotHo9pGRlIv9XAdqSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HirRTdO4; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HirRTdO4" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-ca00f126b7eso218561a12.2 for ; Thu, 30 Jul 2026 18:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785459901; x=1786064701; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lFttCK6+IiI9LAnY0cBt5R9XII1QMStajnONswWnhUU=; b=HirRTdO4IW/41/VRSAYdIDEvqGRwp1lzui+lUfrMfJLiH0ADLRhI8iPzdQAbngrhA/ PGmv+vOgP5D1qfErSXKQJRvAgl0+x0Lr1YfVX+X5fQ9zoXGo18KURSdlK1K9gJPiBKF1 wZ2hS6b6sbvGZabh8gPemhvS0/FbuUDTdKaxGtLnAJNO7ojQ5VM9+a7JUyvzhv9vXaT+ 855jqrUbbzmqX4BOV8OjTZZzjF/cSYbgoF+mKIGaVtmScvqcxN6uSb0xBKNIt91unY9v fjxBikHQIxPpDSvLYi6N9ibdp+feA2V4ZDdLtX/xzfIuusuBPICT16N4izAEeRi53yOx nz+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785459901; x=1786064701; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lFttCK6+IiI9LAnY0cBt5R9XII1QMStajnONswWnhUU=; b=VGmggN3wbHbkCHyzBWat1MQLUSLIwvNd8F4pVjN90GDWdf8cvLj+P1fV+9wR0R9aMu AqMiP3gDAQiZIc5AtmC8wBMg/znTIcZfYIBvpbYAWDmxbXDGEqd1NKFSU1OAH0foO8gh LZnEfhLrN+/wWlUR+DHSNH4aywSTTDXHszdkaMMrGmojZZqfjKHlyUb/QGyxOmvntmY5 leC85nWV11+FerbRRHkD5vG8BgttnDIifAriGIm1OaF99JI0C67iw9jdKpEBahKGBMEq s9Z3vlhT26oH9Ye1n22677kJQlNeWeijUxBZHhH9R9U1HBr2mUguRzsU6vabN0X9RoNo rlUQ== X-Forwarded-Encrypted: i=1; AHgh+RqLVtq7Oaf60/wEMcvTg30s+IAjZ4Wm0ELbV7Dngk1W87pKNUewuDUs6RrG15HH3qX0yZWjE/gEva0IqNg=@vger.kernel.org X-Gm-Message-State: AOJu0YwemramyOFCbUknEHN+3Vt98fnPLaUjxqGxJ6ow+kpNbI2SMJaz VPp0XIEYVqD5PCSZf1Nx3DX9RMUOjz4YpbB1PiJZiLVq99uG8rOfHYLc X-Gm-Gg: AR+sD12weJiJVUJVjR6B/dmCxLh9tSJ1AfWrJyc6vxgt2FYZph0insoLnndg/J3cqVI hQjCjO7fqAVn8TSgo3ybfFRSc3fow7STjeEOg/GVeUzRrce8X4gkfhQo9+Et7T+xZckFwRrxqVq JhZfLgTtXYAEZSDHf4q2HhSI6Mfnu9icZSgJhO93DLZ8VI16vutqFOwtk+GWf1M2qUZntRRZ2fU kbuN1JPJYr6kS4UxybR2oWDUJGac603dFJZlTTZcCGMsDdkh999YjStzi/GCzH6J/8gw0zQmt60 r3Ma5KBZ1qWbwcYxYxpy2sWkRAC23qsLTJXOzBhnOsk+sDYJGr5GyfzUMrOJ2czvovgdDhJ2bRr TWnqt1da4q7VtacNMrukpOE6Vc3LiJDqginOAlWS/twoPCJWnauQYt+eDRdjN9W+xlF0hRj3LF/ nifzqyIZ2q3kJLxCPaekrj/NNSMlnb9RjqPHNd+vm43d1iHcasJBT1iMPIqZwpT1xGRTlF3aI/2 Ek0GpKK1HndyapBQmOwVfUeCHq+29SIWnPPEyQI X-Received: by 2002:a05:6a00:12c7:b0:84c:5349:daa1 with SMTP id d2e1a72fcca58-84ebc425d21mr3954345b3a.76.1785459901336; Thu, 30 Jul 2026 18:05:01 -0700 (PDT) Received: from [172.19.1.42] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84ed5e30a41sm17865b3a.58.2026.07.30.18.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 18:05:00 -0700 (PDT) Message-ID: <6c5b44c6-f06d-4f4c-b014-5a06601454ab@gmail.com> Date: Fri, 31 Jul 2026 09:04:57 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] spi: ma35d1-qspi: Add Nuvoton MA35D1 QSPI controller support To: Mark Brown Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cwweng@nuvoton.com References: <20260727091833.750051-1-cwweng.linux@gmail.com> <20260727091833.750051-3-cwweng.linux@gmail.com> Content-Language: en-US From: Chi-Wen Weng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Mark Brown 於 2026/7/30 下午 11:11 寫道: > On Mon, Jul 27, 2026 at 05:18:33PM +0800, Chi-Wen Weng wrote: > >> Add SPI controller driver support for the Quad SPI controller found in >> Nuvoton MA35D1 SoCs. >> +static int nuvoton_qspi_mem_exec_op(struct spi_mem *mem, >> + const struct spi_mem_op *op) >> +{ >> + if (op->dummy.nbytes) { >> + nuvoton_qspi_set_bus_width(qspi, op->dummy.buswidth, >> + SPI_MEM_DATA_IN); >> + ret = nuvoton_qspi_txrx(qspi, NULL, NULL, op->dummy.nbytes); >> + if (ret) >> + goto out_deassert_cs; >> + } > I would expect dummy data to be an output rather than an input, we don't > want the lines left floating? There's a similar thing below when > setting up the dummy xfer. Hi Mark, Thanks for pointing this out. You are right. The dummy phase should be driven as an output rather than leaving the data lines in input mode. I will update the direct spi-mem path to use SPI_MEM_DATA_OUT for the dummy phase. I will also fix the generic transfer path so that spi-mem dummy transfers remain output transfers instead of switching the lines to input. Best regards, Chi-Wen