mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Werner Sembach <wse@tuxedocomputers.com>
To: Richard Hughes <richard@hughsie.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Richard Hughes <hughsient@gmail.com>,
	ggo@tuxedocomputers.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: Avoid putting some root ports into D3 on some Ryzen chips
Date: Tue, 17 Dec 2024 12:58:18 +0100	[thread overview]
Message-ID: <6c5eb555-4642-42ef-8e4d-9c0c61292ba8@tuxedocomputers.com> (raw)
In-Reply-To: <C9ewaxwQKbro-b58prMr4pYnBsbGXBokgIk3OMYfT2OTCUPqSKeabS2ED02pN44ukBu88wjq1JCzyc4Rb9KHK5qce8L1WufgA27O3NKmTvA=@hughsie.com>


Am 17.12.24 um 11:10 schrieb Richard Hughes:
> On Monday, 16 December 2024 at 23:37, Werner Sembach <wse@tuxedocomputers.com> wrote:
>> - AfuEfix64.efi <bios>.bin /p /r /capsule -> overwrites nothing
>> I tried to explain fwupd and the requirements to our contact at the ODM, but
>> just got the unhelpful reply to use the command above.
> Can you name the ODM? I think essentially all the ODMs are uploading [valid] capsules to the LVFS now. If it helps, it's the same capsule needed for the LVFS as for the Microsoft WU (Windows Update) process and all ODMs should be intimately familiar with those requirements.

In this case it was a Tonfang/Uniwill barebone and I talked to a Tongfang 
representative.

Want to point out again that I could determine that /k did do nothing in the 
/capsule mode while /p and /r did effect the flash (iirc /p was required for 
/capsule or the flash didn't start). I could not determine if /b /n and /l did 
something (and probably can't without proper documentation, which I don't have 
access to). I guess /x is irrelevant as long as the flash works.

Do you have a Microsoft help page for OEMs about BIOS and EC upgrades via 
Windows Update? Having some Windows requirements to point to often helps when 
talking with ODMs in my experience.

>   
>> Do you know how these AfuEfix64.efi flags are passed over to the capsule flash
>> process? Then it might be possible to implement them in fwupd too.
> The capsule, as expected by LVFS and WU, is actually a single *signed* binary that contains the flasher binary and the payload all wrapped up into one. The only time I've seen AfuEfix64.efi in use is for the system preload, as done in the factory.
Yeah but since at least the /r flag influences the flash process there must be 
some way the efi shell can pass on options to the flasher included in the 
capsule ... EFI variables? Some bits appended to the capsule?
>
> Richard.
>

  reply	other threads:[~2024-12-17 11:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 19:36 Werner Sembach
2024-12-09 19:45 ` Mario Limonciello
2024-12-10 15:24   ` Werner Sembach
2024-12-10 16:00     ` Mario Limonciello
2024-12-11 12:47       ` Werner Sembach
2024-12-11 21:24         ` Mario Limonciello
2024-12-12 18:47           ` Werner Sembach
2024-12-12 19:01             ` Mario Limonciello
2024-12-13 10:05               ` Richard Hughes
2024-12-16 23:37                 ` Werner Sembach
2024-12-17 10:10                   ` Richard Hughes
2024-12-17 11:58                     ` Werner Sembach [this message]
2024-12-17 14:12                       ` Mario Limonciello
2024-12-17 14:07           ` Werner Sembach
2024-12-17 14:11             ` Mario Limonciello
2024-12-17 15:58               ` Werner Sembach
2024-12-17 16:08                 ` Werner Sembach
2024-12-17 16:18                   ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c5eb555-4642-42ef-8e4d-9c0c61292ba8@tuxedocomputers.com \
    --to=wse@tuxedocomputers.com \
    --cc=bhelgaas@google.com \
    --cc=ggo@tuxedocomputers.com \
    --cc=hughsient@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=richard@hughsie.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®