From: Markus Elfring <Markus.Elfring@web.de>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: cx25821: Fix a resource leak in cx25821_dev_setup()
Date: Sat, 3 Jan 2026 16:22:40 +0100 [thread overview]
Message-ID: <6c6228d3-eb7c-4347-befd-f1de10e2ec2a@web.de> (raw)
In-Reply-To: <20260103074647.1941895-1-lihaoxiang@isrc.iscas.ac.cn>
> Add release_mem_region() if ioremap() fails to release the memory
> region obtained by cx25821_get_resources().
Do you try to synchronise resource release actions with information
from the implementation of the function “cx25821_dev_unregister”?
https://elixir.bootlin.com/linux/v6.19-rc3/source/drivers/media/pci/cx25821/cx25821-core.c#L939-L963
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n145
Regards,
Markus
prev parent reply other threads:[~2026-01-03 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 7:46 Haoxiang Li
2026-01-03 15:22 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6228d3-eb7c-4347-befd-f1de10e2ec2a@web.de \
--to=markus.elfring@web.de \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®