From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC59EB64D8 for ; Tue, 20 Jun 2023 14:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233259AbjFTOYg (ORCPT ); Tue, 20 Jun 2023 10:24:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232063AbjFTOYe (ORCPT ); Tue, 20 Jun 2023 10:24:34 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73566B3; Tue, 20 Jun 2023 07:24:33 -0700 (PDT) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1qBcHX-0000Ju-Nf; Tue, 20 Jun 2023 16:24:31 +0200 Message-ID: <6c622fd7-d79b-b7f2-50ee-00a0ec95a11b@leemhuis.info> Date: Tue, 20 Jun 2023 16:24:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: PWM regression causing failures with the pwm-atmel driver Content-Language: en-US, de-DE To: Peter Rosin , LKML , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-pwm@vger.kernel.org Cc: Thierry Reding , Conor Dooley , Claudiu Beznea References: <7e2cfb55-e39f-2e5c-7f43-e1d275428bb5@axentia.se> From: Thorsten Leemhuis In-Reply-To: <7e2cfb55-e39f-2e5c-7f43-e1d275428bb5@axentia.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1687271073;37ae78e9; X-HE-SMSGID: 1qBcHX-0000Ju-Nf Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.05.23 17:19, Peter Rosin wrote: > > I have a device with a "sound card" that has an amplifier that needs > an extra boost when high amplification is requested. This extra > boost is controlled with a pwm-regulator. > > As of commit c73a3107624d ("pwm: Handle .get_state() failures") this > device no longer works. I have tracked the problem to an unfortunate > interaction between the underlying PWM driver and the PWM core. > [...]> > Approach 1. will maybe clobber the saved pwm->state such that > it no longer works to get the period/duty_cycle if/when the > PWM is disabled? Maybe only for some corner case? But that might > be a significant corner case? > > Approach 2. will maybe mess up some unrelated functionality? > > Approach 3. is ugly, intrusive and is in all likelihood > incomplete. It also needs a rebase from the culprit commit. > > #regzbot introduced c73a3107624d What happened to this? There was quite a bit of discussion, but then nothing happened anymore. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page. #regzbot poke