mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Claudiu.Beznea@microchip.com>
To: <Eugen.Hristev@microchip.com>, <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama7g5ek: align power rails for sdmmc0/1
Date: Fri, 25 Nov 2022 11:35:01 +0000	[thread overview]
Message-ID: <6c638ac2-3855-04ec-1f83-43b81b5aeb22@microchip.com> (raw)
In-Reply-To: <20221124154610.246790-1-eugen.hristev@microchip.com>

On 24.11.2022 17:46, Eugen Hristev wrote:
> On this board SDMMC0 has a 1.8 signaled eMMC device powered at
> 3.3 V .
> Hence, correctly describe the connected rails from the PMIC.
> 
> SDMMC1 is connected to a voltage switch that can change from
> 3.3V to 1.8V by a hardware controlled pin.
> However SDMMC1 at the moment works only 3.3V mode (default speed,
> no UHS-I modes), thus connect the signaling to the 3.3V rail.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Applied to at91-dt (after reshaped a bit the commit message), thanks!

> ---
>  arch/arm/boot/dts/at91-sama7g5ek.dts | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
> index 3b25c67795dd..aa5cc0e98bba 100644
> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts
> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
> @@ -764,8 +764,9 @@ &rtt {
>  &sdmmc0 {
>  	bus-width = <8>;
>  	non-removable;
> -	no-1-8-v;
>  	sdhci-caps-mask = <0x0 0x00200000>;
> +	vmmc-supply = <&vdd_3v3>;
> +	vqmmc-supply = <&vldo1>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sdmmc0_default>;
>  	status = "okay";
> @@ -775,6 +776,8 @@ &sdmmc1 {
>  	bus-width = <4>;
>  	no-1-8-v;
>  	sdhci-caps-mask = <0x0 0x00200000>;
> +	vmmc-supply = <&vdd_3v3>;
> +	vqmmc-supply = <&vdd_3v3>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sdmmc1_default>;
>  	status = "okay";


      reply	other threads:[~2022-11-25 11:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 15:46 Eugen Hristev
2022-11-25 11:35 ` Claudiu.Beznea [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c638ac2-3855-04ec-1f83-43b81b5aeb22@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®