From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04D9C433E0 for ; Thu, 4 Jun 2020 14:03:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CADAC207D0 for ; Thu, 4 Jun 2020 14:03:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728886AbgFDODk (ORCPT ); Thu, 4 Jun 2020 10:03:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:36468 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728496AbgFDODk (ORCPT ); Thu, 4 Jun 2020 10:03:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CE82BAC6C; Thu, 4 Jun 2020 14:03:42 +0000 (UTC) Subject: Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format To: Chaitanya Kulkarni , Dongli Zhang , "linux-nvme@lists.infradead.org" , "james.smart@broadcom.com" Cc: "linux-kernel@vger.kernel.org" , "hch@lst.de" , "sagi@grimberg.me" References: <20200526042118.17836-1-dongli.zhang@oracle.com> <38a2cfb9-df2a-c5cb-6797-2b96ef049c7c@oracle.com> From: Hannes Reinecke Message-ID: <6c646a1e-ab40-63a1-01cb-6cc2548a3853@suse.de> Date: Thu, 4 Jun 2020 16:03:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/20 8:54 AM, Chaitanya Kulkarni wrote: > On 6/3/20 11:46 PM, Dongli Zhang wrote: >> May I get feedback for this? >> >> For the first time I use fcloop, I set: >> >> # echo "wwnn=0x3,wwpn=0x1" > /sys/class/fcloop/ctl/add_target_port >> >> However, I would not be able to move forward if I use "0x3" or "0x1" for nvme-fc >> target or host further. Instead, the address and port should be >> 0x0000000000000003 and 0x0000000000000001. >> >> This patch would sync the requirements of input format for nvme-fc and >> nvme-fcloop, unless this would break existing test suite (e.g., blktest). > If I remember correctly I don't think we have fc-loop testcases (correct > me if I'm wrong). > Well, I sent some testcases a while back (cf 'fcloop and ANA fixes'). Should I resend them? > Not an fc expert, but having uniform format for the input make sense to > me (unless there is an explicit reason). I'll let James have a final say. > I would stick to use the full 64bit number for both wwpn and wwnn; one gets into too many arguments otherwise (big-endian? little-endian?). And one could argue that '0x0000000000000001' is invalid anyway as per FC-FS3 a '0' in word 0 byte 0 means 'Name not present' :-) Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer