From: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
linux-media@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] media: s5p-jpeg: rename JPEG marker constants to prevent build warnings
Date: Tue, 7 Sep 2021 09:27:04 +0200 [thread overview]
Message-ID: <6c69dd69-9ace-114a-f887-3fe0fdd5d500@gmail.com> (raw)
In-Reply-To: <20210907081125.21c311f1@coco.lan>
Hi Mauro,
W dniu 07.09.2021 o 08:11, Mauro Carvalho Chehab pisze:
> Em Mon, 6 Sep 2021 21:40:22 -0700
> Randy Dunlap <rdunlap@infradead.org> escreveu:
>
>> The use of a macro named 'RST' conflicts with one of the same name
>> in arch/mips/include/asm/mach-rc32434/rb.h. This causes build
>> warnings on some MIPS builds.
>>
>> Change the names of the JPEG marker constants to be in their own
>> namespace to fix these build warnings and to prevent other similar
>> problems in the future.
>>
>> Fixes these build warnings:
>>
>> In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c:14:
>> ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined
>> 43 | #define RST 0xd0
>> |
>> ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition
>> 13 | #define RST (1 << 15)
>>
>> In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c:13:
>> ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined
>> 43 | #define RST 0xd0
>> ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition
>> 13 | #define RST (1 << 15)
>>
>> In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c:12:
>> ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined
>> 43 | #define RST 0xd0
>> ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition
>> 13 | #define RST (1 << 15)
>>
>> In file included from ../drivers/media/platform/s5p-jpeg/jpeg-core.c:31:
>> ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined
>> 43 | #define RST 0xd0
>> ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition
>> 13 | #define RST (1 << 15)
>>
>> Also update the kernel-doc so that the word "marker" is not
>> repeated.
>>
>> Fixes: bb677f3ac434 ("[media] Exynos4 JPEG codec v4l2 driver")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
>> Cc: linux-media@vger.kernel.org
>> Cc: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
>> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Cc: linux-arm-kernel@lists.infradead.org
>> ---
>> v2: change all JPEG marker macros to be in their own namespace (as
>> suggested by Mauro)
>
> Applied, thanks!
You can add
Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
>
> Regards,
> Mauro
>
> Thanks,
> Mauro
>
prev parent reply other threads:[~2021-09-07 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 4:40 Randy Dunlap
2021-09-07 6:11 ` Mauro Carvalho Chehab
2021-09-07 7:27 ` Andrzej Pietrasiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c69dd69-9ace-114a-f887-3fe0fdd5d500@gmail.com \
--to=andrzejtp2010@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mchehab+huawei@kernel.org \
--cc=rdunlap@infradead.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®