From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E77DC433EF for ; Thu, 17 Feb 2022 17:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243874AbiBQRtW (ORCPT ); Thu, 17 Feb 2022 12:49:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243867AbiBQRtV (ORCPT ); Thu, 17 Feb 2022 12:49:21 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EA555291FBA for ; Thu, 17 Feb 2022 09:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645120145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rRIMKHhamSqp8VeNfr4XcAxWjxGDpns0iibC3SSvphI=; b=aMfXjzXNtryBJSom2IKdCB4Kx0nQJScJ+SgtzSE2BwAFIoVs+3Dfx45SgNwd6BSZFWVu+/ Qfq4vVbRrMA0ubr43GkU8aRlDg6X6csJo2d8T4ohl1iWnGwXofZIOUwW64F5/L/D9F4a7B vpUi6BnDj8t7IHVsrhycbx5XoXnQDlY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-QRbYLFWMOgehMRZjXjyuZw-1; Thu, 17 Feb 2022 12:49:04 -0500 X-MC-Unique: QRbYLFWMOgehMRZjXjyuZw-1 Received: by mail-wr1-f70.google.com with SMTP id h24-20020adfaa98000000b001e33eb81e71so2609735wrc.9 for ; Thu, 17 Feb 2022 09:49:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rRIMKHhamSqp8VeNfr4XcAxWjxGDpns0iibC3SSvphI=; b=Ic404wZItxX1UyX2DIhTR9fJgUsYIvgN7XaRxlufDeje16Dvpe+TGlhLyUtrpUofWK QpUDgpK4M2FHGyf1S/0YPjMfs/piRjeGqm21XIV1VWxiY6sl4Trp8D1Se7PKiPZijCb1 OkkG+Q5MxyBwfSWhRDbVhFXDeFtLv68EXNv+Lo45+mKdBOXZv0GNNyUimqYuTL3JObfn IOR1ZCOxDywuuozfF4KX9gKfETJ+B+M/OT3D77pmidX+GeiknKkSe42mUyz1Zh4JpSL7 2+JhtpxD/wMdbp13iWpuaUMr6wHkmcnGORFSMkU79e3JbtdYGzkTB0nwM/S/aTdVvAcL sRag== X-Gm-Message-State: AOAM533QGAYu6ZDSFWZovU7+XXwnnQBqL2/ri1/wrIvjNrfjQMYuReJ8 taeIehlBlxbtWdi9xQVNlvLv+gJWoDS+Imb68zXDT9Bf7lHfJMgdPuLqH9yFOpm15LbUWsWneUx aoZbNqKZ6h30GVftV3/cq1aYe X-Received: by 2002:a05:600c:35d1:b0:37c:d45c:af57 with SMTP id r17-20020a05600c35d100b0037cd45caf57mr7156012wmq.149.1645120143299; Thu, 17 Feb 2022 09:49:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZ9zXHZ9F/mtgzKSHmwW5LPeJBNm3yMLCV+v3cbCHhyApAmjEFStihyj3q0BuKaMTUhMKzIw== X-Received: by 2002:a05:600c:35d1:b0:37c:d45c:af57 with SMTP id r17-20020a05600c35d100b0037cd45caf57mr7155996wmq.149.1645120143067; Thu, 17 Feb 2022 09:49:03 -0800 (PST) Received: from ?IPV6:2001:b07:646c:22c6:db53:7a2b:ef3c:adb0? ([2001:b07:646c:22c6:db53:7a2b:ef3c:adb0]) by smtp.gmail.com with ESMTPSA id 14sm8654293wrb.34.2022.02.17.09.49.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Feb 2022 09:49:02 -0800 (PST) Message-ID: <6c6fc4fa-6464-2dbf-40da-e3c61f322d95@redhat.com> Date: Thu, 17 Feb 2022 18:49:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC V2 17/21] watchdog/dev: Add tracepoints Content-Language: en-US To: Guenter Roeck , Daniel Bristot de Oliveira , "Peter.Enderborg@sony.com" , Wim Van Sebroeck Cc: Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Will Deacon , Catalin Marinas , Marco Elver , Dmitry Vyukov , "Paul E. McKenney" , Shuah Khan , Juri Lelli , Clark Williams , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-trace-devel@vger.kernel.org" , Steven Rostedt References: <96f418b4-0ba8-01fe-ead0-2028bfc42560@sony.com> From: Gabriele Paoloni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/2022 18:27, Guenter Roeck wrote: > On 2/17/22 08:27, Daniel Bristot de Oliveira wrote: >> Hi Peter >> >> On 2/16/22 17:01, Peter.Enderborg@sony.com wrote: >>> On 2/14/22 11:45, Daniel Bristot de Oliveira wrote: >>>> Add a set of tracepoints, enabling the observability of the watchdog >>>> device interactions with user-space. >>>> >>>> The events are: >>>>     watchdog:watchdog_open >>>>     watchdog:watchdog_close >>>>     watchdog:watchdog_start >>>>     watchdog:watchdog_stop >>>>     watchdog:watchdog_set_timeout >>>>     watchdog:watchdog_ping >>>>     watchdog:watchdog_nowayout >>>>     watchdog:watchdog_set_keep_alive >>>>     watchdog:watchdog_keep_alive >>> >>> Some watchdogs have a bark functionality, I think it should be event >>> for that too. >>> >> >> I understand. The problems is that I do not see the bark abstraction >> in the >> watchdog_dev layer. >> > > I don't even know what "bark functionality" means. A new term for > pretimeout ? > Something else ? >From my understanding the bark timeout is actually the pretimeout whereas the bite timeout is the actual timeout. I think in the Kernel ftwdt010_wdt and qcom-wdt are bark/bite WTDs Gab > > Guenter > >> In the case I am investigating (the safety_monitor/safety_app) the >> bark is >> outside of the "OS" view, it is an hardware action - like. shutdown. >> >> Am I missing something? Thoughts? >> >> -- Daniel >