From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751609AbdKFD3g (ORCPT ); Sun, 5 Nov 2017 22:29:36 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42210 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751461AbdKFD3d (ORCPT ); Sun, 5 Nov 2017 22:29:33 -0500 Subject: Re: [PATCH] powerpc: eeh: stop using do_gettimeofday() To: Arnd Bergmann , Russell Currey , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org References: <20171104212727.3228606-1-arnd@arndb.de> From: Andrew Donnellan Date: Mon, 6 Nov 2017 14:29:23 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171104212727.3228606-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17110603-0040-0000-0000-0000040AD4F8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17110603-0041-0000-0000-000020AD6936 Message-Id: <6c73bf01-d16e-da63-d464-45d0494a3ee7@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-05_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711060045 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/17 08:26, Arnd Bergmann wrote: > This interface is inefficient and deprecated because of the y2038 > overflow. > > ktime_get_seconds() is an appropriate replacement here, since it > has sufficient granularity but is more efficient and uses monotonic > time. > > Signed-off-by: Arnd Bergmann Reviewed-by: Andrew Donnellan > --- > arch/powerpc/include/asm/eeh.h | 2 +- > arch/powerpc/kernel/eeh_driver.c | 2 +- > arch/powerpc/kernel/eeh_pe.c | 8 ++++---- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h > index cd1df96335e5..5161c37dd039 100644 > --- a/arch/powerpc/include/asm/eeh.h > +++ b/arch/powerpc/include/asm/eeh.h > @@ -93,7 +93,7 @@ struct eeh_pe { > struct pci_bus *bus; /* Top PCI bus for bus PE */ > int check_count; /* Times of ignored error */ > int freeze_count; /* Times of froze up */ > - struct timeval tstamp; /* Time on first-time freeze */ > + time64_t tstamp; /* Time on first-time freeze */ > int false_positives; /* Times of reported #ff's */ > atomic_t pass_dev_cnt; /* Count of passed through devs */ > struct eeh_pe *parent; /* Parent PE */ > diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c > index 4e1b433f6cb5..4f71e4c9beb7 100644 > --- a/arch/powerpc/kernel/eeh_driver.c > +++ b/arch/powerpc/kernel/eeh_driver.c > @@ -623,7 +623,7 @@ static int eeh_reset_device(struct eeh_pe *pe, struct pci_bus *bus, > struct eeh_rmv_data *rmv_data) > { > struct pci_bus *frozen_bus = eeh_pe_bus_get(pe); > - struct timeval tstamp; > + time64_t tstamp; > int cnt, rc; > struct eeh_dev *edev; > > diff --git a/arch/powerpc/kernel/eeh_pe.c b/arch/powerpc/kernel/eeh_pe.c > index 2e8d1b2b5af4..2d4956e97aa9 100644 > --- a/arch/powerpc/kernel/eeh_pe.c > +++ b/arch/powerpc/kernel/eeh_pe.c > @@ -526,16 +526,16 @@ int eeh_rmv_from_parent_pe(struct eeh_dev *edev) > */ > void eeh_pe_update_time_stamp(struct eeh_pe *pe) > { > - struct timeval tstamp; > + time64_t tstamp; > > if (!pe) return; > > if (pe->freeze_count <= 0) { > pe->freeze_count = 0; > - do_gettimeofday(&pe->tstamp); > + pe->tstamp = ktime_get_seconds(); > } else { > - do_gettimeofday(&tstamp); > - if (tstamp.tv_sec - pe->tstamp.tv_sec > 3600) { > + tstamp = ktime_get_seconds(); > + if (tstamp - pe->tstamp > 3600) { > pe->tstamp = tstamp; > pe->freeze_count = 0; > } > -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited