From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751186AbdKTGoF (ORCPT ); Mon, 20 Nov 2017 01:44:05 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:35633 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbdKTGoE (ORCPT ); Mon, 20 Nov 2017 01:44:04 -0500 X-Google-Smtp-Source: AGs4zMYZHGN+xdpq37flMjtT8vBx5qCl/i5CoxDScE97C6C2bxPSgVtvVJK602A09RluuP5W+r64Ig== Subject: Re: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq To: Viresh Kumar References: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> <1510950502-22565-5-git-send-email-arvind.yadav.cs@gmail.com> <20171120054340.GB6125@vireshk-i7> Cc: ulf.hansson@linaro.org, carlo@caione.org, khilman@baylibre.com, ben-linux@fluff.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org From: Arvind Yadav Message-ID: <6c854ee4-c0c9-be2f-cfdc-8feeb6e5ab20@gmail.com> Date: Mon, 20 Nov 2017 12:13:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20171120054340.GB6125@vireshk-i7> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi viresh, Could you please acknowledge a latest version of this patch. Thanks, On Monday 20 November 2017 11:13 AM, Viresh Kumar wrote: > On 18-11-17, 01:58, Arvind Yadav wrote: >> platform_get_irq() can fail here and we must check its return value. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/mmc/host/sdhci-spear.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c >> index 8c0f884..900838b 100644 >> --- a/drivers/mmc/host/sdhci-spear.c >> +++ b/drivers/mmc/host/sdhci-spear.c >> @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev) >> host->hw_name = "sdhci"; >> host->ops = &sdhci_pltfm_ops; >> host->irq = platform_get_irq(pdev, 0); >> + if (host->irq < 0) { >> + ret = host->irq; >> + goto err_host; >> + } >> host->quirks = SDHCI_QUIRK_BROKEN_ADMA; >> >> sdhci = sdhci_priv(host); > Acked-by: Viresh Kumar >