From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D03040D57E for ; Mon, 20 Jul 2026 12:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784549259; cv=none; b=QOgqZ4BCevwHKArlMfB+JhAvIVxN4oIwqduCfeJrsUaR/1tTyXhVfd53acsa93gYkL5jySOP1KAy4n57EVMZmmzFNIjcxcaBV65ervqPJ61kVVRfosu3UYyD/qSSTj0gOhaaNOiT3XTsvb7zFYTekjLgO4KAIHwA1kjuyhTihIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784549259; c=relaxed/simple; bh=3LskwaJt3gSEnF5JMMS9r1mC+PR+I4B+DXgOi0/4Wio=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mNxbhLGIEPWSZlAPJ7Ho8jpPJLI/Lx1R0ebBkdqhjURKBVHQMaaUi6+GBd2eZJ1svT5Jf5DwQBZHK5eZHzqpJHimDWzR48gVly54LNWNLsM2F7EPbBf/zasI6DGQ4IKsI6jLE5D7CinNI6gaOnKVT3XCo0y8oXtURZjoj/fJQA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jhzf6LBq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=faNA8YJI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jhzf6LBq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="faNA8YJI" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KAvbte2078427 for ; Mon, 20 Jul 2026 12:07:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /kl2WXycavBl/r+S0QQtS641iykNoKyZyvG2zsIuek4=; b=jhzf6LBqrfs64pby Ud9I7njR4JN5gwJxTSRBmmXhxHgap+h/VRvnW9yK79HYJ0V08jJQI7p/jiRsZqo5 YTCYbYlJaRDzheEuBwpxfmUmDiy5/fh1bXwGeqnZ2y6lrRxxutAOWgkQOtfplQn0 IQytk7JS3xhKs6dGcVi71BGt4HRG1+bgiPQ/YR11ny7rsLxri9Hm5Y9T2xWWBBta gvT5vnLrfD+gNtDu26OeNFyUOjEItq3g38XyIM4v6zR54WNNCGBAhMx+LBYkVwpn jGumCEyhA3JRjX16IT5pa6HD3HclC41D8pve2x42ZC6PxAB+hr67pPWGdDUf7GgX 88FukA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhh5y0mph-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 12:07:31 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-847a00bcbd0so12762050b3a.0 for ; Mon, 20 Jul 2026 05:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784549251; x=1785154051; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/kl2WXycavBl/r+S0QQtS641iykNoKyZyvG2zsIuek4=; b=faNA8YJIq35JDYbaW6Xl6PKPs3s2jZk4PVVRcZI1gG+mkLrpfySznl3LRnZuHF+8QR Uumkov2Rh4+c9DogJjvHQy7NyRvjkIHbJkI6KGk+aByjL6eD3fXpdFp9SkXlZvCrA4C7 gDxF64qQW/ey2Yr06dULCoEsADUdpFk+RR1rpLW9ejhGRURELS4woQDDruzoZBPvUZaD DQys/KA9Zm6XzTKhb0xZ2eImvM+xcgDrW81Kr+hTi4oiQ8ZfPM5h+eTJoaZQ4bU94VyH DQ4aXx5aVMemCJn63in+aY+aQ377Xvk3HNVnbwtaMDjSGzLbXUM9yIWZIODW7POMj7PM ISSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784549251; x=1785154051; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/kl2WXycavBl/r+S0QQtS641iykNoKyZyvG2zsIuek4=; b=HxROJk8MRLVfRK9v0dhG1Kw5egThWi2iWKIR2uWPAuz192YDHqnaNvpTcxx4ZS2MAn Feu5e1p7okTk9s87zzjKt/pWg3BwatMe+bky1xjmhLUTrM65njHzyYhfEQG/X291gp5n xm/d/NJzR9G25sMmMA+bkL24EGz8V+pgQWfDHjO+U1KbXObnno7ZzkMI9vFeX5GNMHhC Z/IYPvP+ik6XsAb8Etpst3O+eezqP98c+BVaglP0nnfmCksqG+YIgWxib4SREiTcTHs8 8alaIyq+c/SZPRmgnZcJb3j0PdaunWTe6xVDEGHkKvrpDIdk0LqAPWnOohD1y55Il8Fw 0INA== X-Forwarded-Encrypted: i=1; AHgh+RpkZeIvTeGvvmYPmPi9sR+KVNmr8/8wO4Q5exfwWAriAFtwcR/ZLEQfoCIjd5+VzgqJuWLxJCMnsc6l02I=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5+tCYXv/oqRTeCw52AG2elaMCu+Za22zbZsiM9eLsI1llxRrw ke8ib0dcnlXhKEYk5n1IHEBc6rrIw7rF/lw3jDsnzYfZbk75wwbwnfSRm+f2QKaTpd6B+EK3sUc oTBpqZerOAV24BeDFFcSB24It9bJdhEs0Hf8/nbodWzqls9Y5ExK2xIOsD/9DtPkfKgU= X-Gm-Gg: AfdE7cmDbuNI18HO/nQFxlwnFh31tMY6iYXURo73MxNjN2HTPBx+rhwBeiLqMVbRBHV O8e3fxJW5LQ9BD72NR0hlSTtJ3MmFX9widL4iXeVu4kjh5cRBWfWW5G1tLu6VGcjNQCtp4eaedQ mWEWUV8dDVL4bbyy4Dqlo6sgbXuRtUzDdczoOZKH+WZjHu5K6JR5dpLSpbTz/5Ry2qYLyKzU0ot YyIXqF0rWp8wApwKUOrIUd04cxxrJYMdB2KDN54ARS2uxNsbmMyizksM9WiQKePh9gixFnEvP/W LjlyxUNDwrTRuLjPIXTW2gkBM0Fb1HVx9krns4yo9FRfcmTD6saLHsOYo2pPHPebDreIYgeK4EG 8eGXpnRrGNVVC/yIji3JnkI123YuXMg== X-Received: by 2002:a05:6a00:418f:b0:848:75a1:a0fa with SMTP id d2e1a72fcca58-84c294ca1d9mr12215376b3a.67.1784549250770; Mon, 20 Jul 2026 05:07:30 -0700 (PDT) X-Received: by 2002:a05:6a00:418f:b0:848:75a1:a0fa with SMTP id d2e1a72fcca58-84c294ca1d9mr12215329b3a.67.1784549250309; Mon, 20 Jul 2026 05:07:30 -0700 (PDT) Received: from [10.206.100.243] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c3793ec61sm4276969b3a.42.2026.07.20.05.07.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 05:07:29 -0700 (PDT) Message-ID: <6c89ef9d-3551-4b92-904c-316dbcffcfbd@oss.qualcomm.com> Date: Mon, 20 Jul 2026 17:37:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel To: Konrad Dybcio , Dmitry Baryshkov Cc: Nabige Aala , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260706-shikra-dt-changes-v2-0-56fcd1659ea4@oss.qualcomm.com> <20260706-shikra-dt-changes-v2-2-56fcd1659ea4@oss.qualcomm.com> <8a3cc857-0b1c-4bd5-a5ce-a564823ca614@oss.qualcomm.com> <6f8d8cf5-1e35-4d45-b2c1-6f36ac51ad4a@oss.qualcomm.com> <4efaa8d7-56c8-4581-a161-51abb319bdcf@oss.qualcomm.com> Content-Language: en-US From: Arpit Saini In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDEzNSBTYWx0ZWRfX0Gfp79zLM+76 6LFtq+Bm02ajwSVRBwnx5CfxTf32iNyStJGufwXkcgHeHETC3M6sBF1xsRcEDx1cwAUwLKeWrBS HmXqODGU+dIpO29QkW6wNFQjCR1UPH0= X-Proofpoint-GUID: KTUcnJeLhsqyCOCXmP5jVsaNzAWRfiHj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDEzNSBTYWx0ZWRfX8Tl1YSaWJTDu y7YzRTZaA0f8SIDs44vD1L85QHPyTLcdi4nooiVD1iwu2WBoF9n4xT7Lpsv9eumVEFjsBNroWFJ Hf/6RD4Hf2gjT81OlW6beLn60mM+Ox20dzFNLdAMo+YswABaMnyw+7Y8mDYZPWBmTjNcTdJiAXL u2xp4tSAVnsgd+GwHc5y37wUOcFxwmAbhQ8NV0kkPRTqqIwSste0Kg0k/L+M3S3SrehoHYsE41s xUcpP/kR25pU5NXv1oqRC2f+LLUzLuS6uy7exMUlhzx4DMLDcvCe8jyDHFaYbILu5JLFBbGPg0M z4iV7pXm1rNekRpFIZFyJuFH/PTLDl82gYQaRIZOukZN4ZxA4qvlxnksO+hr9qq18LqZWEiDKui 9b3Pa6vSlhn3ffQIIFlbwjQWeNOcJQ4snjHjiYpZLuQ8rXlMRS7NYjxq9xFjq6K16P6QxEpLJKk 8wSVe3gQw9UWv4fazUw== X-Proofpoint-ORIG-GUID: KTUcnJeLhsqyCOCXmP5jVsaNzAWRfiHj X-Authority-Analysis: v=2.4 cv=f/x4wuyM c=1 sm=1 tr=0 ts=6a5e0f83 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=U5k8SXBAhPj4dsil1kcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_02,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200135 Hi Konrad, On 7/16/2026 11:21 PM, Konrad Dybcio wrote: > On 7/14/26 9:21 AM, Arpit Saini wrote: >> Hi Dmitry,Konrad >> >> On 7/10/2026 6:09 PM, Dmitry Baryshkov wrote: >>> On Fri, Jul 10, 2026 at 05:28:04PM +0530, Arpit Saini wrote: >>>> Hi Konrad, >>>> >>>> On 7/10/2026 2:31 PM, Arpit Saini wrote: > > [...] > >>>> Normally the backlight EN pin is controlled by a backlight driver. >>>> >>>> However, this panel uses MIPI DCS based backlight control with no >>>> >>>> separate backlight driver. Since there is no driver to assert gpio91, >>>> >>>> we control it via the panel's pinctrl default state.. >>>> >>>> So this is platform specific pin , we need this to enable/disable >>>> >>>> the backlight. >>> >>> Handle it from the panel driver. Also please fix your editor to prevent >>> it from inserting extra empty lines. >>> >> >> Earlier I handled it through panel driver, but this GPIO is specific to our >> Qualcomm Daughter Card, it is not going to the panel connector. > > So is it an enable pin of a voltage regulator maybe? I'm having trouble > understanding how this is all tied together, given the panel driver > uses DCS commands to control the backlight status > > Konrad No, it is not a voltage regulator enable. GPIO91 (WLED_P1_EN) is the enable pin of the WLED driver IC on the Qualcomm daughter card. The WLED driver is a boost LED driver that powers the backlight LEDs. The backlight control works in two parts: 1. GPIO91 must be asserted to enable the WLED driver IC itself. 2. The panel's CABC output (a PWM signal) is connected to the WLED driver's PWM input and controls the actual brightness. This CABC output is driven by the DCS set_display_brightness command sent from the panel driver. So the DCS commands control brightness via the panel's PWM/CABC output, but the WLED driver IC needs to be enabled first via GPIO91. Since GPIO91 is on the Qualcomm daughter card and not on the panel connector. Dmitry suggested , it is not appropriate to model it in the panel binding. The current approach of asserting it via pinctrl default state in the board DTS keeps it board-specific. If you have a better suggestion for modelling this, I'm happy to follow your guidance. SoC (ITP Baseband Card) ├── GPIO91 (WLED_P1_EN) ─────────────────────────────────────┐ │ │ └── DSI ──────────────────────────────────────────────────┐ │ │ │ ┌──────────────────────────────────────────────────────────┼──┼──────────────────────────────────┐ │ Qualcomm Display Daughter Card │ │ │ │ │ │ │ │ ┌─────────────────────────────────┐ │ │ ┌──────────────────────┐ │ │ │ DLC DLC0697 Panel (ILI7807S) │◄────────────────────┘ │ │ WLED Driver IC │ │ │ │ │ | │ │ │ │ │ DCS set_display_brightness() │ └──►│ EN │ │ │ │ │ │ │ │ │ │ │ ▼ │ │ │ │ │ │ CABC output ───────────────────┼───────────────────────────►│ PWM │ │ │ │ │ │ │ │ │ │ │ │ LED outputs ────────┼──► Backlight LEDs │ └─────────────────────────────────┘ └──────────────────────┘ │ │ │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ Thanks, Arpit