From: Randy Dunlap <rdunlap@infradead.org>
To: Arnd Bergmann <arnd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Nishanth Menon <nm@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: ti-sci: fix compile test dependencies
Date: Thu, 15 Dec 2022 09:08:08 -0800 [thread overview]
Message-ID: <6c8d0815-a64c-a4ea-4bc9-d38a2b6c3121@infradead.org> (raw)
In-Reply-To: <20221215170036.2308972-1-arnd@kernel.org>
On 12/15/22 09:00, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The SCI reset driver can be compile testing on targets that
> do not support the SCI firmware, but it fails to link when
> the firmware driver is built as a module, and the reset driver
> is built-in:
>
> arm-linux-gnueabi-ld: drivers/reset/reset-ti-sci.o: in function `ti_sci_reset_probe':
> reset-ti-sci.c:(.text+0x422): undefined reference to `devm_ti_sci_get_handle'
>
> Prevent this configuration by limiting the compile test
> to configurations without SCI firmware.
>
> Fixes: a6af504184c9 ("reset: ti-sci: Allow building under COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
https://lore.kernel.org/lkml/20221030055636.3139-1-rdunlap@infradead.org/
> ---
> drivers/reset/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index de176c2fbad9..2a52c990d4fe 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -257,7 +257,7 @@ config RESET_SUNXI
>
> config RESET_TI_SCI
> tristate "TI System Control Interface (TI-SCI) reset driver"
> - depends on TI_SCI_PROTOCOL || COMPILE_TEST
> + depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n)
> help
> This enables the reset driver support over TI System Control Interface
> available on some new TI's SoCs. If you wish to use reset resources
--
~Randy
prev parent reply other threads:[~2022-12-15 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 17:00 Arnd Bergmann
2022-12-15 17:08 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c8d0815-a64c-a4ea-4bc9-d38a2b6c3121@infradead.org \
--to=rdunlap@infradead.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®