From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8247C433DB for ; Wed, 6 Jan 2021 01:03:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE9A2221E2 for ; Wed, 6 Jan 2021 01:03:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725800AbhAFBDz (ORCPT ); Tue, 5 Jan 2021 20:03:55 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:10548 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbhAFBDx (ORCPT ); Tue, 5 Jan 2021 20:03:53 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4D9WKh0WRbzMFxr; Wed, 6 Jan 2021 09:02:00 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.498.0; Wed, 6 Jan 2021 09:03:08 +0800 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks To: Daeho Jeong CC: Markus Elfring , , , Colin Ian King , , References: <20210105041630.1393157-1-daeho43@gmail.com> From: Chao Yu Message-ID: <6c8e6561-8a5d-010f-3d7c-8c051b4027e6@huawei.com> Date: Wed, 6 Jan 2021 09:03:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daeho, FYI https://www.spinics.net/lists/kernel/msg3595944.html On 2021/1/5 20:04, Markus Elfring wrote: >> Fixed null page reference when find_lock_page() fails in >> redirty_blocks(). > > I suggest to choose an other imperative wording for this change description. > > See also: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n89 > > >> v2: changed error value and break the loop when error occurs > > I propose to use a return statement instead of a break in the second if branch > for this function implementation. > > See also: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n481 > > Regards, > Markus > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . >