From: Jason Wang <jasowang@redhat.com>
To: Markus Elfring <Markus.Elfring@web.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Andrzej Hajda <a.hajda@samsung.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Rob Herring <robh@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Stephen Boyd <swboyd@chromium.org>,
Tang Bin <tangbin@cmss.chinamobile.com>
Subject: Re: virtio-mmio: Delete an error message in vm_find_vqs()
Date: Thu, 9 Apr 2020 14:20:38 +0800 [thread overview]
Message-ID: <6c94db13-ae46-cf8e-f3c4-6f270112ad87@redhat.com> (raw)
In-Reply-To: <96031fc7-dced-95bd-fc57-a5fe890638f4@web.de>
On 2020/4/9 下午2:02, Markus Elfring wrote:
>>> The function “platform_get_irq” can log an error already.
>>> Thus omit a redundant message for the exception handling in the
>>> calling function.
>> It looks to me that not all error path of platform_get_irq() were loggd.
> How do you think about to clarify the handling of the error code “-EPROBE_DEFER” any more?
> https://elixir.bootlin.com/linux/v5.6.3/source/drivers/base/platform.c#L202
Aha, it looks to me that I'm on the wrong branch. Sorry.
>
>
>> And git grep told me there're other users of platform_get_irq() that check and log by themselves.
> Source code analysis can point further update candidates out, can't it?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/base/platform.c?id=7723f4c5ecdb8d832f049f8483beb0d1081cedf6
Yes, it can.
>
> Would you like to achieve collateral evolution?
Yes and it's probably be better to put all the fixes in one series.
For this patch.
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
>
> Regards,
> Markus
>
prev parent reply other threads:[~2020-04-09 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 17:19 [PATCH] " Markus Elfring
2020-04-09 3:19 ` Jason Wang
2020-04-09 6:02 ` Markus Elfring
2020-04-09 6:20 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c94db13-ae46-cf8e-f3c4-6f270112ad87@redhat.com \
--to=jasowang@redhat.com \
--cc=Markus.Elfring@web.de \
--cc=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=javierm@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mst@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®