From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B9FC31E4D for ; Fri, 14 Jun 2019 14:19:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C24F72173C for ; Fri, 14 Jun 2019 14:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728551AbfFNOTU (ORCPT ); Fri, 14 Jun 2019 10:19:20 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:49338 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726335AbfFNOTT (ORCPT ); Fri, 14 Jun 2019 10:19:19 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 882E21C88C98E2127566; Fri, 14 Jun 2019 22:19:15 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.439.0; Fri, 14 Jun 2019 22:19:12 +0800 Subject: Re: [PATCH] PCI: hv: Fix build error without CONFIG_SYSFS To: , , , References: <20190531150923.12376-1-yuehaibing@huawei.com> CC: , From: Yuehaibing Message-ID: <6c97b2ae-b151-5610-d8d5-ef626d1f9bbb@huawei.com> Date: Fri, 14 Jun 2019 22:19:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190531150923.12376-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, Friendly ping... On 2019/5/31 23:09, YueHaibing wrote: > while building without CONFIG_SYSFS, fails as below: > > drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_assign_slots': > pci-hyperv.c:(.text+0x40a): undefined reference to 'pci_create_slot' > drivers/pci/controller/pci-hyperv.o: In function 'pci_devices_present_work': > pci-hyperv.c:(.text+0xc02): undefined reference to 'pci_destroy_slot' > drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_remove': > pci-hyperv.c:(.text+0xe50): undefined reference to 'pci_destroy_slot' > drivers/pci/controller/pci-hyperv.o: In function 'hv_eject_device_work': > pci-hyperv.c:(.text+0x11f9): undefined reference to 'pci_destroy_slot' > > Select SYSFS while PCI_HYPERV is set to fix this. > > Reported-by: Hulk Robot > Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot information") > Signed-off-by: YueHaibing > --- > drivers/pci/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > index 2ab9240..6722952 100644 > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -182,6 +182,7 @@ config PCI_LABEL > config PCI_HYPERV > tristate "Hyper-V PCI Frontend" > depends on X86 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && X86_64 > + select SYSFS > help > The PCI device frontend driver allows the kernel to import arbitrary > PCI devices from a PCI backend to support PCI driver domains. >