From: Mark Salyzyn <salyzyn@android.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Andy Lutomirski <luto@amacapital.net>,
Dmitry Safonov <dsafonov@virtuozzo.com>,
John Stultz <john.stultz@linaro.org>,
Laura Abbott <labbott@redhat.com>,
Kees Cook <keescook@chromium.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Andrew Pinski <apinski@cavium.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/12] arm+arm64: vdso unification to lib/vdso/
Date: Mon, 30 Oct 2017 13:34:13 -0700 [thread overview]
Message-ID: <6c9aa942-bfc0-4c54-888a-85fd1d43e40c@android.com> (raw)
In-Reply-To: <20171030141813.nozm5bgumb5qp2ol@lakrids.cambridge.arm.com>
On 10/30/2017 07:18 AM, Mark Rutland wrote:
> Hi,
>
> On Fri, Oct 27, 2017 at 03:23:48PM -0700, Mark Salyzyn wrote:
>> Note I noticed a bug in the old implementation of __kernel_clock_getres;
>> it was checking only the lower 32bits of the pointer; this would work
>> for most cases but could fail in a few.
> Sorry if this is a stupid question, but do you mean from a prior version
> of this series, or the one in the kernel today?
apinski@cavium.com noticed this as part of the existing upstream arm64
assembler when he did the original conversion to C.
Yes, I am aware that a separate patch will need to be made on the
assembler code for 'stable' trees. And it needs to be addressed
(separately from this patch series IMHO, but if forced, it would be a
pre-patch that gets swallowed in patch 10 of the series).
I have not looked into it in depth, because from Android's point of
view, this patch series (once approved) is going to be back-ported to
our android-common kernels and will be the solution to the problem. I
must declare I have to be humble about my understanding of arm64
assembler, so there is _that_ ...
-- MarkS
next prev parent reply other threads:[~2017-10-30 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 22:23 Mark Salyzyn
2017-10-30 14:18 ` Mark Rutland
2017-10-30 20:34 ` Mark Salyzyn [this message]
2017-10-30 21:44 ` Mark Rutland
2017-10-31 9:49 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c9aa942-bfc0-4c54-888a-85fd1d43e40c@android.com \
--to=salyzyn@android.com \
--cc=andy.gross@linaro.org \
--cc=apinski@cavium.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=dsafonov@virtuozzo.com \
--cc=james.morse@arm.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kevin.brodsky@arm.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@amacapital.net \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®