From: Pierre Yves MORDRET <pierre-yves.mordret@foss.st.com>
To: Alain Volmat <alain.volmat@foss.st.com>, <wsa@kernel.org>,
<robh+dt@kernel.org>
Cc: <mark.rutland@arm.com>, <mcoquelin.stm32@gmail.com>,
<alexandre.torgue@foss.st.com>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <fabrice.gasnier@foss.st.com>,
<amelie.delaunay@foss.st.com>
Subject: Re: [PATCH 4/4] i2c: stm32: add support for the STM32MP13 soc
Date: Tue, 21 Jun 2022 15:40:48 +0200 [thread overview]
Message-ID: <6ca11af0-9c13-4e41-07fd-7fe90f202667@foss.st.com> (raw)
In-Reply-To: <20220620105405.145959-5-alain.volmat@foss.st.com>
Hi All
Look good to me.
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com>
Regards
On 6/20/22 12:54, Alain Volmat wrote:
> Add a new compatible for the stm32mp13. Fast Mode Plus control
> register address differ from the one for STM32MP15.
>
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index b29d8e476342..9946b330ddce 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -410,6 +410,12 @@ static const struct stm32f7_i2c_setup stm32mp15_setup = {
> .fmp_clr_offset = 0x40,
> };
>
> +static const struct stm32f7_i2c_setup stm32mp13_setup = {
> + .rise_time = STM32F7_I2C_RISE_TIME_DEFAULT,
> + .fall_time = STM32F7_I2C_FALL_TIME_DEFAULT,
> + .fmp_clr_offset = 0x4,
> +};
> +
> static inline void stm32f7_i2c_set_bits(void __iomem *reg, u32 mask)
> {
> writel_relaxed(readl_relaxed(reg) | mask, reg);
> @@ -2469,6 +2475,7 @@ static const struct dev_pm_ops stm32f7_i2c_pm_ops = {
> static const struct of_device_id stm32f7_i2c_match[] = {
> { .compatible = "st,stm32f7-i2c", .data = &stm32f7_setup},
> { .compatible = "st,stm32mp15-i2c", .data = &stm32mp15_setup},
> + { .compatible = "st,stm32mp13-i2c", .data = &stm32mp13_setup},
> {},
> };
> MODULE_DEVICE_TABLE(of, stm32f7_i2c_match);
--
--
~ Py MORDRET
--
prev parent reply other threads:[~2022-06-21 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 10:54 [PATCH 0/4] i2c: stm32: addition of STM32MP13 support Alain Volmat
2022-06-20 10:54 ` [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line Alain Volmat
2022-06-28 13:41 ` Rob Herring
2022-06-29 19:44 ` Wolfram Sang
2022-07-06 22:46 ` Rob Herring
2022-07-07 6:38 ` Alain Volmat
2022-06-20 10:54 ` [PATCH 2/4] i2c: stm32: only perform a reset if there is a reset property Alain Volmat
2022-06-21 13:39 ` Pierre Yves MORDRET
2022-06-20 10:54 ` [PATCH 3/4] dt-bindings: i2c: st,stm32-i2c: add entry for stm32mp13 Alain Volmat
2022-06-20 10:54 ` [PATCH 4/4] i2c: stm32: add support for the STM32MP13 soc Alain Volmat
2022-06-21 13:40 ` Pierre Yves MORDRET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ca11af0-9c13-4e41-07fd-7fe90f202667@foss.st.com \
--to=pierre-yves.mordret@foss.st.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®