From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794672210; b=JWr05QtGZj8JSccc6San5fJ9i3UPGHZiXNW6hCyQaZ2Kp6FF0Z9mEB9PLiE8QpJmNv+J 0h4sZx5WhTRY5N3TNW51mmFePJfL3801PY97dDCUZs/42+KcqnchswBkHXY4q7HIYptCR 6dF8WxaiQN3lHA2zGhTHbZh8DOwFZ0adphxzOQ1p+fiP9i80SFxY8mEO+qLKdPOyeN4hv paaT4SLVPqq8eykRj8GhmsqQQOsJadt4p9TZIUUuE3OUYcM7s+9FGg9lGIz5yQVXEi4Cz qfk9PMTlK8NBlRWSgoQ+/E1zh9lSIPeWAsWOT8gBr7Y0rK5u+ZKU+ZgPqwXCXE9x5Vw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794672210; h=DMARC-Filter:Received:Received:X-Authority-Analysis:DKIM-Signature: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To:X-AntiAbuse:X-AntiAbuse: X-AntiAbuse:X-AntiAbuse:X-AntiAbuse:X-BWhitelist:X-Source-IP: X-Source-L:X-Exim-ID:X-Source:X-Source-Args:X-Source-Dir: X-Source-Sender:X-Source-Auth:X-Email-Count:X-Org:X-Source-Cap: X-Local-Domain:X-CMAE-Envelope; bh=HLZcm2kGGNPkHrolsS7QSodgMr1auiEM7m7otpV8Qpc=; b=ir56BWODQM2uoTAXcXl1smGHFXE7fRtm8XfCfDJpWdiVCFj1Ot0LMo/rfllJAdFaoIHd 9gNlY79L35VWYkhn45YV9Ad/cfDc8tG80vfKWngZhApAz+w7QtYVP53A0U/S29Uh3ur5x PJs7CGyKiJ6lSHG9gMadnqZewShEXExUXiYxPXaXIRdO5gvv2xFepOka9F4NtyQo1Axdt A6S64jO9njNc4lq/9dI2o77O4lDERwrUA5R+YNZRHEYdXVD5H51GQZ2TOMIq6hFBFWzX4 QiSy0Qabl62tvoBi297h+UIP/VsJUkHGKSpHx2eKd/a6rShru+IqD8nL1JUpf4VXbVQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=roeck-us.net; spf=fail smtp.mailfrom=roeck-us.net; dkim=pass header.d=roeck-us.net header.i=@roeck-us.net header.a=rsa-sha256 header.s=default header.b=vuGp4CDe; arc=none smtp.remote-ip=35.89.44.39 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99717606A331 for ; Sat, 14 Nov 2026 16:03:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 99717606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=roeck-us.net header.i=@roeck-us.net header.a=rsa-sha256 header.s=default header.b=vuGp4CDe Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id S7k2xeMpwyb4YSGDyxg7uj; Sat, 14 Nov 2026 16:03:30 +0000 Received: from 162-215-252-36.unifiedlayer.com ([208.91.199.152]) by cmsmtp with ESMTPS id SGDxxvhT0YskhSGDxxYOO1; Sat, 14 Nov 2026 16:03:30 +0000 X-Authority-Analysis: v=2.4 cv=CKMqXQrD c=1 sm=1 tr=0 ts=6af88652 a=QNED+QcLUkoL9qulTODnwA==:117 a=2cfIYNtKkjgZNaOwnGXpGw==:17 a=kj9zAlcOel0A:10 a=zJRp6_cAMcgA:10 a=M0FbrtG7MMAA:10 a=PJTSTX75uoluVfBDKb4A:9 a=CjuIK1q_8ugA:10 a=KPbNTLLc3YvdawN95zVk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=In-Reply-To:Content-Type:MIME-Version:References :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HLZcm2kGGNPkHrolsS7QSodgMr1auiEM7m7otpV8Qpc=; b=vuGp4CDeVz+rwR3TUp3oAyehS4 0L/a548VOLey5fO3Nc90aSLAgqL2+/53GCRGby1g4J/mvtI8p67am2BwPIVktAx6EkTjmBeYUH3t8 mBUiG/scRNANP+hSFM7B/teGf2me17VWOAY+oQtwdjIgsJyKLJfv9YVNKOgAXQoKZgladbrZ7qYB4 uM2D01e2GPTdCtwUSOYuTboUG9P0U7fW7IcskXBZQdTx4zQZpEI5m8/ISGk4T92WD0irIakKlZ+SA rY6I8uu31+CocRiLGtIJ1iXnSWE4feU/cmLbT5tdZ+cfqbkMWwXEbn+OIzz4U80NwQRCjQ9rHlJFg YoSaxn4g==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:33236 helo=server.roeck-us.net) by bh-25.webhostbox.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xSGDx-000000001VK-0hDI; Sat, 14 Nov 2026 21:33:29 +0530 Date: Sat, 14 Nov 2026 08:03:28 -0800 From: Guenter Roeck To: Tomasz Bojanowski Cc: linux-hwmon@vger.kernel.org, Hamza Mahfooz , Jonathan Corbet , Shuah Khan , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] hwmon: (nct6683) Make the fan curves of NCT6687D-R writable Message-ID: <6ca20e71-bcfd-4f60-9471-08c39da1a4ee@roeck-us.net> References: <20261109223442.509238-1-tomasz@bojanowski.me> <20261109223442.509238-3-tomasz@bojanowski.me> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261109223442.509238-3-tomasz@bojanowski.me> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-BWhitelist: no X-Source-IP: 108.223.40.66 X-Source-L: No X-Exim-ID: 1xSGDx-000000001VK-0hDI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 108-223-40-66.lightspeed.sntcca.sbcglobal.net (server.roeck-us.net) [108.223.40.66]:33236 X-Source-Auth: guenter@roeck-us.net X-Email-Count: 9 X-Org: HG=direseller_whb_net_legacy;ORG=directi; X-Source-Cap: cm9lY2s7YWN0aXZzdG07YmgtMjUud2ViaG9zdGJveC5uZXQ= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFj8nynO7KC+mQbdek1M/jDAswNX0JyoaDF0i2WsnoFtQ8yzv8SWnIk7FB0E9K7YmeazQUfZwYcvPYjVIJbnxdWj/7cDeSORpouTdy7mfSYGG7OSEjKH QCbfkxX1Bawl2DIqMQSwYhCR2yXeDD1TjmvxlUrFtrUT33eLuINVRtDj8bxtUDg2olEs8OXro14pxZly0glpGzOUxq554clXog4VekkyqGh2FsWqR4DPHobv On Mon, Nov 09, 2026 at 11:34:42PM +0100, Tomasz Bojanowski wrote: > Allow writing pwmN_auto_point[1-7]_temp and pwmN_auto_point[1-7]_pwm in > manual and in automatic mode. The points are writable if, when the driver > is loaded, the temperatures and the duty cycles of the curve do not > decrease and the temperatures are at most 127 degrees Celsius. The EC > firmware is not documented and does not take a curve whose duty cycles > decrease, so only curves like those set by the BIOS are written. The > limit of 127 degrees Celsius reads the same whether the EC treats the > temperature registers as signed or unsigned. > > Temperatures and duty cycles are clamped to those of the adjacent points, > temperatures also to 0-127 degrees Celsius and duty cycles to 0-255. The > whole curve is written in one configuration phase and read back, to check > that the EC uses it as written. If that fails while the EC responds, the > previous curve is written again. > > The BIOS may restore its own settings when resuming from suspend, so > restore the curves written through sysfs on resume, before manual mode. > > Tested on an MSI MAG B850M MORTAR WIFI (MS-7E61) with pwm16: writing and > clamping of curve points, the written curve after suspend to RAM, and > manual mode after resume. > > Signed-off-by: Tomasz Bojanowski Applied. Thanks, Guenter